Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-358

Implement initcap(string) function

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      I'd like to implement this function.
      Please assign to me.

      1. TAJO-358.patch
        4 kB
        Seungun Choe

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        I've assigned this issue to you. Thank you for your participation.

        Show
        hyunsik Hyunsik Choi added a comment - I've assigned this issue to you. Thank you for your participation.
        Hide
        seungunchoe Seungun Choe added a comment -

        I was confirm with mvn clean install.

        Show
        seungunchoe Seungun Choe added a comment - I was confirm with mvn clean install.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Show
        hyunsik Hyunsik Choi added a comment - +1
        Hide
        sirpkt Keuntae Park added a comment -

        It looks good to me.
        However, duplicated test cases exist in TestStringOperatorsAndFunctions.Java as follows:

          @Test
          public void testInitcap() throws IOException {
            testSimpleEval("select initcap('hi bro') ", new String[]{"Hi Bro"});
            testSimpleEval("select initcap('hi bro') ", new String[]{"Hi Bro"});
          }
        }
        
        Show
        sirpkt Keuntae Park added a comment - It looks good to me. However, duplicated test cases exist in TestStringOperatorsAndFunctions.Java as follows: @Test public void testInitcap() throws IOException { testSimpleEval("select initcap('hi bro') ", new String[]{"Hi Bro"}); testSimpleEval("select initcap('hi bro') ", new String[]{"Hi Bro"}); } }
        Hide
        hyunsik Hyunsik Choi added a comment -

        Actually, there are duplicate tests, and initcap has different semantic. For example, initcap('HI BRO') should be result in 'Hi Bro'. But, I've just revised the patch because this is trivial.

        Show
        hyunsik Hyunsik Choi added a comment - Actually, there are duplicate tests, and initcap has different semantic. For example, initcap('HI BRO') should be result in 'Hi Bro'. But, I've just revised the patch because this is trivial.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #584 (See https://builds.apache.org/job/Tajo-trunk-postcommit/584/)
        TAJO-358: Implement initcap(string) function. (Seungun Choe via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=3e2a2636e902137740d5e6e3510af565d8d33106)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/InitCap.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #584 (See https://builds.apache.org/job/Tajo-trunk-postcommit/584/ ) TAJO-358 : Implement initcap(string) function. (Seungun Choe via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=3e2a2636e902137740d5e6e3510af565d8d33106 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/InitCap.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java CHANGES.txt

          People

          • Assignee:
            seungunchoe Seungun Choe
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development