Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      We don't have testcase to verify TAJO-16. So, I'll add one here. And I'll use DerbyDB as a Hive Metasore.

      1. TAJO-327_2.patch
        20 kB
        Jaehwa Jung
      2. TAJO-327_3.patch
        20 kB
        Jaehwa Jung
      3. TAJO-327.patch
        20 kB
        Jaehwa Jung

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #621 (See https://builds.apache.org/job/Tajo-trunk-postcommit/621/)
        TAJO-327: Add testcase to verify TAJO-16. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=1d2bd0d97949c6a0475c4e180505aeaa12188b51)

        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/DummyListener.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml
        • tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #621 (See https://builds.apache.org/job/Tajo-trunk-postcommit/621/ ) TAJO-327 : Add testcase to verify TAJO-16 . (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=1d2bd0d97949c6a0475c4e180505aeaa12188b51 ) tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/DummyListener.java CHANGES.txt tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        Hide
        blrunner Jaehwa Jung added a comment -

        Thank you Jihoon.
        I've just committed now.

        Show
        blrunner Jaehwa Jung added a comment - Thank you Jihoon. I've just committed now.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks!
        +1. This patch looks good to me/

        Show
        jihoonson Jihoon Son added a comment - Thanks! +1. This patch looks good to me/
        Hide
        blrunner Jaehwa Jung added a comment -

        Jihoon, you're welcome.
        I misunderstood your opinion.
        I uploaded the modified patch. Please, check it again.

        Show
        blrunner Jaehwa Jung added a comment - Jihoon, you're welcome. I misunderstood your opinion. I uploaded the modified patch. Please, check it again.
        Hide
        jihoonson Jihoon Son added a comment -

        JaeHwa, sorry for my insufficient description.
        I meant that the table name would be better to be checked with Set.contains() instead of iterating each element.
        So, how about check with the following code?

        assertTrue(tables.contains(DB_NAME + "." + NATION));
        assertTrue(tables.contains(DB_NAME + "." + CUSTOMER));
        
        Show
        jihoonson Jihoon Son added a comment - JaeHwa, sorry for my insufficient description. I meant that the table name would be better to be checked with Set.contains() instead of iterating each element. So, how about check with the following code? assertTrue(tables.contains(DB_NAME + "." + NATION)); assertTrue(tables.contains(DB_NAME + "." + CUSTOMER));
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks Jihoon.
        I modified the patch.

        Show
        blrunner Jaehwa Jung added a comment - Thanks Jihoon. I modified the patch.
        Hide
        jihoonson Jihoon Son added a comment -

        +1 for the patch.
        I have just a question for the CatalogStore.getAllTableNames() function.
        Are the results of the function always sorted by the lexicographical order?
        If not, it would be better to use HashSet instead of List in testGetAllTableNames().

        Show
        jihoonson Jihoon Son added a comment - +1 for the patch. I have just a question for the CatalogStore.getAllTableNames() function. Are the results of the function always sorted by the lexicographical order? If not, it would be better to use HashSet instead of List in testGetAllTableNames().
        Hide
        blrunner Jaehwa Jung added a comment -

        I'm glad to implement unit tests for HCatalogStore.
        It was risk because we couldn't verify HCatalogStore ourselves.

        I implemented unit test with DerbyDB and HiveMetastore client.
        The patch progress unit tests as follows:

        • Set up hive warehouse and hive metastore.
        • Start up hive metastore server.
        • Create hive tables by HCatalogStore.
        • Check hive tables are exist by HCatalogStore.
        • Check hive table detail informations by HCatalogStore.
        • Delete hive tables by HCatalogStore.
        Show
        blrunner Jaehwa Jung added a comment - I'm glad to implement unit tests for HCatalogStore. It was risk because we couldn't verify HCatalogStore ourselves. I implemented unit test with DerbyDB and HiveMetastore client. The patch progress unit tests as follows: Set up hive warehouse and hive metastore. Start up hive metastore server. Create hive tables by HCatalogStore. Check hive tables are exist by HCatalogStore. Check hive table detail informations by HCatalogStore. Delete hive tables by HCatalogStore.

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development