Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-310

Make the DataLocation class as a separate class and move it to the tajo-core-storage package.

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.8.0
        • Component/s: None
        • Labels:
          None

          Description

          In the current implementation, DataLocation is a inner class of QueryUnit.
          Thus, it cannot be used in the classes of the tajo-core-storage package.
          However, it is useful for many other classes in the tajo-core-storage package such as FileFragment.

          1. Text File
            TAJO-310_2.patch
            6 kB
            Jihoon Son
          2. Text File
            TAJO-310_3.patch
            7 kB
            Jihoon Son
          3. Text File
            TAJO-310.patch
            3 kB
            Jihoon Son

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jihoonson Jihoon Son added a comment -

            I submitted a patch.

            Show
            jihoonson Jihoon Son added a comment - I submitted a patch.
            Hide
            Permalink
            hyunsik Hyunsik Choi added a comment -

            I agree with this refactoring work. But, some 'cannot find symbol' errors occur in TaskScheduleEvent, QueryUnitAttempt, and TaskSchedulerImpl classes.

            Show
            hyunsik Hyunsik Choi added a comment - I agree with this refactoring work. But, some 'cannot find symbol' errors occur in TaskScheduleEvent, QueryUnitAttempt, and TaskSchedulerImpl classes.
            Hide
            Permalink
            jihoonson Jihoon Son added a comment -

            Sorry, I missed some changes.
            I attached the second patch.
            It passed 'mvn verify'.

            Show
            jihoonson Jihoon Son added a comment - Sorry, I missed some changes. I attached the second patch. It passed 'mvn verify'.
            Hide
            Permalink
            jihoonson Jihoon Son added a comment -

            The changes in the first patch is not included in the second patch.
            I'm so sorry for my mistake.

            Show
            jihoonson Jihoon Son added a comment - The changes in the first patch is not included in the second patch. I'm so sorry for my mistake.
            Hide
            Permalink
            hyunsik Hyunsik Choi added a comment -

            +1

            ship it!

            Show
            hyunsik Hyunsik Choi added a comment - +1 ship it!
            Hide
            Permalink
            jihoonson Jihoon Son added a comment -

            Thanks, Hyunsik

            I've just committed it.

            Show
            jihoonson Jihoon Son added a comment - Thanks, Hyunsik I've just committed it.
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Tajo-trunk-postcommit #557 (See https://builds.apache.org/job/Tajo-trunk-postcommit/557/)
            TAJO-310: Make the DataLocation class as a separate class and move it to the tajo-core-storage package. (jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=6e2db3baf86d68ec844a523b5fb2de5d800494c5)

            • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TaskSchedulerImpl.java
            • CHANGES.txt
            • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/DataLocation.java
            • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/TaskScheduleEvent.java
            • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #557 (See https://builds.apache.org/job/Tajo-trunk-postcommit/557/ ) TAJO-310 : Make the DataLocation class as a separate class and move it to the tajo-core-storage package. (jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=6e2db3baf86d68ec844a523b5fb2de5d800494c5 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TaskSchedulerImpl.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/DataLocation.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/TaskScheduleEvent.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java

              People

              • Assignee:
                jihoonson Jihoon Son
                Reporter:
                jihoonson Jihoon Son
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development