Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Function/UDF
    • Labels:

      Description

      chr function returns one character from the ascii code argument.

      text chr(int)
      
      1. TAJO-307.patch
        4 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        I'd like to solve this issue. please assign to me

        Show
        charsyam DaeMyung Kang added a comment - I'd like to solve this issue. please assign to me
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks, DaeMyung.
        I assigned to you.

        Show
        jihoonson Jihoon Son added a comment - Thanks, DaeMyung. I assigned to you.
        Hide
        hyunsik Hyunsik Choi added a comment -

        DaeMyung,

        Because you are already a contributor, you can assign issues to yourself.
        Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - DaeMyung, Because you are already a contributor, you can assign issues to yourself. Thanks!
        Hide
        charsyam DaeMyung Kang added a comment -

        Please review this.

        It's operations is somewhat different from posgresql's
        I just limit it's bound from 1 to 65525(Unicode UCS2 range)

        but postgresql allow to input until 2097151(but it just returns "")

        so I need some advice.
        Should we make this function like postgresql's?

        Show
        charsyam DaeMyung Kang added a comment - Please review this. It's operations is somewhat different from posgresql's I just limit it's bound from 1 to 65525(Unicode UCS2 range) but postgresql allow to input until 2097151(but it just returns "") so I need some advice. Should we make this function like postgresql's?
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        PostgreSQL String function manual describes that chr() can take UTF8 code point. However, in this time, the given range limit may be proper. When needed, we would expand the range limit.

        Show
        hyunsik Hyunsik Choi added a comment - +1 PostgreSQL String function manual describes that chr() can take UTF8 code point. However, in this time, the given range limit may be proper. When needed, we would expand the range limit.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master. Thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #608 (See https://builds.apache.org/job/Tajo-trunk-postcommit/608/)
        TAJO-307: Implement chr(int) function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=ad6ff6ede187bea29e64c1745fad4d90f7049433)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Chr.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #608 (See https://builds.apache.org/job/Tajo-trunk-postcommit/608/ ) TAJO-307 : Implement chr(int) function. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=ad6ff6ede187bea29e64c1745fad4d90f7049433 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Chr.java CHANGES.txt

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development