Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-290

TajoDataType.Type.NULL should be NULL_TYPE

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:

      Description

      NULL is a reserved word in C+. It doesn't work in C+ implementation.

      1. TAJO-290.patch
        26 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        It passed unittests

        I changed only NULL value is involved with TajoDataType.Type.NULL to NULL_TYPE.

        Show
        charsyam DaeMyung Kang added a comment - It passed unittests I changed only NULL value is involved with TajoDataType.Type.NULL to NULL_TYPE.
        Hide
        jhkim Jinho Kim added a comment -

        +1

        Thank you for your contribution!
        I reviewed the patch. The patch looks good, and passes all unit tests

        Show
        jhkim Jinho Kim added a comment - +1 Thank you for your contribution! I reviewed the patch. The patch looks good, and passes all unit tests
        Hide
        jhkim Jinho Kim added a comment -

        I've removed some unused imports.Then, I've committed the patch, fixing it as resolved.

        Show
        jhkim Jinho Kim added a comment - I've removed some unused imports.Then, I've committed the patch, fixing it as resolved.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #571 (See https://builds.apache.org/job/Tajo-trunk-postcommit/571/)
        TAJO-290: TajoDataType.Type.NULL should be NULL_TYPE. (DaeMyung Kang via jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=2e27a0232ac1bf48fe277a22a818d282866216c7)

        • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/BinarySerializeDeserialize.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RowFile.java
        • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/IsNullEval.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializeDeserialize.java
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RawFile.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java
        • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FunctionEval.java
        • tajo-common/src/main/proto/DataTypes.proto
        • tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java
        • CHANGES.txt
        • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java
        • tajo-common/src/main/java/org/apache/tajo/datum/NullDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #571 (See https://builds.apache.org/job/Tajo-trunk-postcommit/571/ ) TAJO-290 : TajoDataType.Type.NULL should be NULL_TYPE. (DaeMyung Kang via jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=2e27a0232ac1bf48fe277a22a818d282866216c7 ) tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/BinarySerializeDeserialize.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RowFile.java tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/IsNullEval.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializeDeserialize.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RawFile.java tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FunctionEval.java tajo-common/src/main/proto/DataTypes.proto tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java CHANGES.txt tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java tajo-common/src/main/java/org/apache/tajo/datum/NullDatum.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development