Details

      Description

      We have to update HiveQLAnalyzer for cast expression.

      1. TAJO-218.patch
        6 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded the patch.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded the patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18422/.

        Show
        blrunner Jaehwa Jung added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18422/ .
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630640/TAJO-218.patch
        against master revision 9cce80c.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/159//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/159//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/159//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630640/TAJO-218.patch against master revision 9cce80c. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/159//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/159//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/159//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        This issue got +1 at RB.
        I committed it the the master branch and 0.8.0 branch.

        Show
        blrunner Jaehwa Jung added a comment - This issue got +1 at RB. I committed it the the master branch and 0.8.0 branch.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #86 (See https://builds.apache.org/job/Tajo-master-build/86/)
        TAJO-218: HiveQLAnalyzer has to support cast expression. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=a33b836659fe1236db8d9ea3883b3bddefe131a1)

        • tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.hiveql
        • tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.sql
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #86 (See https://builds.apache.org/job/Tajo-master-build/86/ ) TAJO-218 : HiveQLAnalyzer has to support cast expression. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=a33b836659fe1236db8d9ea3883b3bddefe131a1 ) tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.hiveql tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.sql tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java CHANGES.txt

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development