Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-408 Improve function system
  3. TAJO-215

Catalog should allow compatible types when finding functions

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Catalog, Function/UDF
    • Labels:

      Description

      Current catalog is strong typed. Given a find request, it only can search for a certain function with the same argument types. However, in many cases, catalog should find functions with compatible parameter types.

      1. TAJO-215_2.patch
        9 kB
        Hyunsik Choi
      2. TAJO-215.Henrick.01.patch.txt
        5 kB
        Alvin Henrick
      3. TAJO-215.Henrick.02.patch.txt
        10 kB
        Alvin Henrick
      4. TAJO-215.Henrick.03.patch.txt
        14 kB
        Alvin Henrick
      5. TAJO-215.Hyunsik.140410.patch
        17 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        This problem is also caused when a function is called with NULL parameters. For example, consider regexp_replace as follows:

        select regexp_replace(null, '^AB', 'ab') as result;
        

        This expression will find a function whose parameter type is (null type, text, text). This call cannot find regexp_replace(text, text, text) function.

        Show
        hyunsik Hyunsik Choi added a comment - This problem is also caused when a function is called with NULL parameters. For example, consider regexp_replace as follows: select regexp_replace( null , '^AB', 'ab') as result; This expression will find a function whose parameter type is (null type, text, text). This call cannot find regexp_replace(text, text, text) function.
        Hide
        alvinhenrick Alvin Henrick added a comment -

        I have resolved the NULL Data Type issues with compatible type like CHAR , VARCHAR ,TEXT etc.

        Please let me know if I have missed anything to be handled.

        Thanks!
        Warm Regards,
        Alvin.

        Show
        alvinhenrick Alvin Henrick added a comment - I have resolved the NULL Data Type issues with compatible type like CHAR , VARCHAR ,TEXT etc. Please let me know if I have missed anything to be handled. Thanks! Warm Regards, Alvin.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638000/TAJO-215.Henrick.01.patch.txt
        against master revision bd418a5.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/295//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/295//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/295//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/295//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638000/TAJO-215.Henrick.01.patch.txt against master revision bd418a5. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/295//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/295//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/295//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/295//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Alvin,

        Thank you for your work! Your patch looks nice for me. You seem to get the point the issue intended even though the description is very brief.

        In addition, there are more compatible relationships by using upper casting. For example, INT1 can be casted to INT2, INT4, INT8 in our Datum system. Also, FLOAT4 can be casted to FLOAT8.

        With these compatible relationships, we may use the following priority of function finding.

        1) Find a exact matched function
        2) Find a compatible function by using upper casting

        For example, let us assume that there are two functions:

        • INT4 func1(INT4)
        • INT8 func1(INT8

        When a function call func1(INT4) is issued, the exact matched function func1(INT4) will be retrieved. If there were no func1(INT4), func1(INT8) will be retrieved.

        If there are more than one compatible function, it would be great to retrieve a more close compatible function. For example, there are func1(INT2), func1(INT4), and func1(INT8). When func1(INT2) is issued, it would be better to retrieve func1(INT4) instead of func1(INT8) for more computation efficiency.

        If you have any suggestion, feel free suggest anything.

        Best regards,
        Hyunsik

        Show
        hyunsik Hyunsik Choi added a comment - Hi Alvin, Thank you for your work! Your patch looks nice for me. You seem to get the point the issue intended even though the description is very brief. In addition, there are more compatible relationships by using upper casting. For example, INT1 can be casted to INT2, INT4, INT8 in our Datum system. Also, FLOAT4 can be casted to FLOAT8. With these compatible relationships, we may use the following priority of function finding. 1) Find a exact matched function 2) Find a compatible function by using upper casting For example, let us assume that there are two functions: INT4 func1(INT4) INT8 func1(INT8 When a function call func1(INT4) is issued, the exact matched function func1(INT4) will be retrieved. If there were no func1(INT4) , func1(INT8) will be retrieved. If there are more than one compatible function, it would be great to retrieve a more close compatible function. For example, there are func1(INT2) , func1(INT4) , and func1(INT8) . When func1(INT2) is issued, it would be better to retrieve func1(INT4) instead of func1(INT8) for more computation efficiency. If you have any suggestion, feel free suggest anything. Best regards, Hyunsik
        Hide
        alvinhenrick Alvin Henrick added a comment -

        Thanks! Hyunsik.
        Yes , That was my intention. I will handle other data types and upload the patch.

        Warm Regards,
        Alvin.

        Show
        alvinhenrick Alvin Henrick added a comment - Thanks! Hyunsik. Yes , That was my intention. I will handle other data types and upload the patch. Warm Regards, Alvin.
        Hide
        alvinhenrick Alvin Henrick added a comment -

        Added UPPER CAST SUPPORT for most of the common data types. Was not feeling comfortable with TIME / DATE RELATED functions so left them untouched.

        Thanks!
        Warm Regards,
        Alvin.

        Show
        alvinhenrick Alvin Henrick added a comment - Added UPPER CAST SUPPORT for most of the common data types. Was not feeling comfortable with TIME / DATE RELATED functions so left them untouched. Thanks! Warm Regards, Alvin.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638720/TAJO-215.Henrick.02.patch.txt
        against master revision bbee120.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/307//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/307//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/307//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638720/TAJO-215.Henrick.02.patch.txt against master revision bbee120. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/307//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/307//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/307//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Alvin Henrick,

        Thank you for your contribution. The patch looks nice for me. I leave some comments.

        I think that there are two find methods for exact matching and compatible matching. The exact matching will be used to check if one creating function already exists. The compatible match will be used to find functions used in query processing.

        The latest patch omits exact matching method and function existence check, which should be performed when a function is created. Could you add both exact matching method and function existence check? In addition, It would be great to add unit tests which verify compatible functions.

        Best regards,
        Hyunsik

        Show
        hyunsik Hyunsik Choi added a comment - Hi Alvin Henrick , Thank you for your contribution. The patch looks nice for me. I leave some comments. I think that there are two find methods for exact matching and compatible matching. The exact matching will be used to check if one creating function already exists. The compatible match will be used to find functions used in query processing. The latest patch omits exact matching method and function existence check, which should be performed when a function is created. Could you add both exact matching method and function existence check? In addition, It would be great to add unit tests which verify compatible functions. Best regards, Hyunsik
        Hide
        hyunsik Hyunsik Choi added a comment -

        This is the rebased patch against the latest git revision.

        Show
        hyunsik Hyunsik Choi added a comment - This is the rebased patch against the latest git revision.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639136/TAJO-215_2.patch
        against master revision 5b0cf0d.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/315//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/315//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/315//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639136/TAJO-215_2.patch against master revision 5b0cf0d. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/315//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/315//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/315//console This message is automatically generated.
        Hide
        alvinhenrick Alvin Henrick added a comment -

        Hi Hyunsik , Here is the ultimate patch you were looking for.I Apologize for the delay was busy with the work for the company I work for.

        Thanks!
        Warm Regards,
        Alvin.

        Show
        alvinhenrick Alvin Henrick added a comment - Hi Hyunsik , Here is the ultimate patch you were looking for.I Apologize for the delay was busy with the work for the company I work for. Thanks! Warm Regards, Alvin.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639465/TAJO-215.Henrick.03.patch.txt
        against master revision d952b61.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 203 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/320//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/320//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/320//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/320//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639465/TAJO-215.Henrick.03.patch.txt against master revision d952b61. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 203 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/320//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/320//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/320//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        No problem. I understand that you spend your own time. Nevertheless, you have done great contributions in Tajo.

        I'll review it soon!

        Show
        hyunsik Hyunsik Choi added a comment - No problem. I understand that you spend your own time. Nevertheless, you have done great contributions in Tajo. I'll review it soon!
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Alvin Henrick,

        +1 for your latest patch.

        I reviewed and tested all unit tests. The patch looks pretty nice to me. I had some comments. It's for the use of integer constants in isCompatibleType() as follows:

        if (exitingTypeNumber >= 2 && exitingTypeNumber <= 6) {
                  // INT1 ==> INT2 ==> INT4 ==> INT8
                  if (argTypeNumber >= 2 && argTypeNumber <= exitingTypeNumber) {
                    flag = true;
                  }
        }
        

        I think that the direct use of integer constant may have some limit to change the TajoDataType class generated by protocol buffer. But, it's very trivial, so I've updated them rather than commenting it and waiting for your patch update.

        In addition, I added one trivial change for ANY type in isCompatibleType, which allows all data types. Also, I added its unit test in TestCatalog.

        I hope that my update is matched to your intention. If you agree, I'll commit it shortly.

        Best regards,
        Hyunsik

        Show
        hyunsik Hyunsik Choi added a comment - Hi Alvin Henrick , +1 for your latest patch. I reviewed and tested all unit tests. The patch looks pretty nice to me. I had some comments. It's for the use of integer constants in isCompatibleType() as follows: if (exitingTypeNumber >= 2 && exitingTypeNumber <= 6) { // INT1 ==> INT2 ==> INT4 ==> INT8 if (argTypeNumber >= 2 && argTypeNumber <= exitingTypeNumber) { flag = true ; } } I think that the direct use of integer constant may have some limit to change the TajoDataType class generated by protocol buffer. But, it's very trivial, so I've updated them rather than commenting it and waiting for your patch update. In addition, I added one trivial change for ANY type in isCompatibleType, which allows all data types. Also, I added its unit test in TestCatalog. I hope that my update is matched to your intention. If you agree, I'll commit it shortly. Best regards, Hyunsik
        Hide
        alvinhenrick Alvin Henrick added a comment -

        Thank You so much Hyunsik.

        Yes,You did the right thing.I wanted to use the constant instead of hard coding the values..I wanted to get it right and then move on to use the Enum Constants .....I am glad you caught it.

        I will move on to work on 704

        Warm Regards,
        Alvin.

        Show
        alvinhenrick Alvin Henrick added a comment - Thank You so much Hyunsik. Yes,You did the right thing.I wanted to use the constant instead of hard coding the values..I wanted to get it right and then move on to use the Enum Constants .....I am glad you caught it. I will move on to work on 704 Warm Regards, Alvin.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639588/TAJO-215.Hyunsik.140410.patch
        against master revision 838b522.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 204 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/323//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/323//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/323//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/323//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639588/TAJO-215.Hyunsik.140410.patch against master revision 838b522. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 204 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/323//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/323//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/323//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/323//console This message is automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #67 (See https://builds.apache.org/job/Tajo-0.8.0-build/67/)
        TAJO-215: Catalog should allow compatible types when finding functions. (Alvin Henrick via hyunsik) (hyunsik: rev 3d00cd829a97a108272ec3338e6556c09baf84af)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #67 (See https://builds.apache.org/job/Tajo-0.8.0-build/67/ ) TAJO-215 : Catalog should allow compatible types when finding functions. (Alvin Henrick via hyunsik) (hyunsik: rev 3d00cd829a97a108272ec3338e6556c09baf84af) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #168 (See https://builds.apache.org/job/Tajo-master-build/168/)
        TAJO-215: Catalog should allow compatible types when finding functions. (Alvin Henrick via hyunsik) (hyunsik: rev 24805e209a7c5d443ced01bbfbbb402f011a86ac)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #168 (See https://builds.apache.org/job/Tajo-master-build/168/ ) TAJO-215 : Catalog should allow compatible types when finding functions. (Alvin Henrick via hyunsik) (hyunsik: rev 24805e209a7c5d443ced01bbfbbb402f011a86ac) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java CHANGES.txt tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you Alvin for your awesome contribution. committed it to master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you Alvin for your awesome contribution. committed it to master and branch-0.8.0.
        Hide
        alvinhenrick Alvin Henrick added a comment -

        Thank You Hyunsik.

        Show
        alvinhenrick Alvin Henrick added a comment - Thank You Hyunsik.

          People

          • Assignee:
            alvinhenrick Alvin Henrick
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development