Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2142

Temporarily disable NOT IN subquery

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0, 0.11.1, 0.11.2
    • Fix Version/s: 0.12.0, 0.11.3
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      TAJO-2141 is a ticket to fix the problem of invalid result of NOT IN subquery with null values, but I think we need to disable this feature right now to avoid delaying our next release.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/1010

        TAJO-2142: Temporarily disable NOT IN subquery

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-2142

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/1010.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #1010


        commit 6702654fef63a4862ae3894c30cf392609391cc1
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-23T03:16:38Z

        Fix the bug and add an optimization rule

        commit 9fe133c7e1b75c3bb3165f56efc52051460c22bd
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-26T12:53:31Z

        Improve optimization rule to consider alias

        commit b90ed663b0e261e5796893bf7ac057305a2daff6
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-29T00:15:46Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-2135

        commit 01a9762aecd07fbd49120fd8d645ce9fc5bc2195
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-29T08:06:47Z

        • Added null values to all tpch tables.
        • Fixed join, sort tests.

        commit 200113196cb31ff7e26ce92d60c3ed1149af012d
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-29T11:07:21Z

        Fix group by test

        commit 5e699f271d53b0e8673c2768494444c84c43e324
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-30T05:39:53Z

        Fix all test failures

        commit 0f4335deee5961ce4794cbdf27225dbca0d3251b
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-30T05:55:48Z

        Code cleanup

        commit 45432f25616093e368f45342272386b3f20eeb38
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-01T05:33:48Z

        Fix invalid result in full outer join

        commit 450bee298dba9c67a024dafb520ab9d7bde109ce
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-01T10:48:30Z

        Fix full outer join bug

        commit 44039abb4dea8e45d9098916f6e40b3a75f76771
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-01T14:01:05Z

        Fixed all tests except window function

        commit b0ffd13098c4b06bf27a42a599086c9d11f8fd45
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-01T14:38:04Z

        Add tpch test data set without nulls for pgsql tests

        commit 17b7ec84360e4b207ea8bdfe75b49b90d430f43b
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-02T02:02:23Z

        • Fix remaining window function test failures
        • Fix rank function bug

        commit 2c2dad0bec523007a391346512223d0dbb220437
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-03T01:53:46Z

        Delete dupliacted line

        commit ce8fb68165ea542258ff76df7d316ca9359575d4
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-05-03T07:10:07Z

        TAJO-2142


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/1010 TAJO-2142 : Temporarily disable NOT IN subquery You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-2142 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/1010.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1010 commit 6702654fef63a4862ae3894c30cf392609391cc1 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-23T03:16:38Z Fix the bug and add an optimization rule commit 9fe133c7e1b75c3bb3165f56efc52051460c22bd Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-26T12:53:31Z Improve optimization rule to consider alias commit b90ed663b0e261e5796893bf7ac057305a2daff6 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-29T00:15:46Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-2135 commit 01a9762aecd07fbd49120fd8d645ce9fc5bc2195 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-29T08:06:47Z Added null values to all tpch tables. Fixed join, sort tests. commit 200113196cb31ff7e26ce92d60c3ed1149af012d Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-29T11:07:21Z Fix group by test commit 5e699f271d53b0e8673c2768494444c84c43e324 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-30T05:39:53Z Fix all test failures commit 0f4335deee5961ce4794cbdf27225dbca0d3251b Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-30T05:55:48Z Code cleanup commit 45432f25616093e368f45342272386b3f20eeb38 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-01T05:33:48Z Fix invalid result in full outer join commit 450bee298dba9c67a024dafb520ab9d7bde109ce Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-01T10:48:30Z Fix full outer join bug commit 44039abb4dea8e45d9098916f6e40b3a75f76771 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-01T14:01:05Z Fixed all tests except window function commit b0ffd13098c4b06bf27a42a599086c9d11f8fd45 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-01T14:38:04Z Add tpch test data set without nulls for pgsql tests commit 17b7ec84360e4b207ea8bdfe75b49b90d430f43b Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-02T02:02:23Z Fix remaining window function test failures Fix rank function bug commit 2c2dad0bec523007a391346512223d0dbb220437 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-03T01:53:46Z Delete dupliacted line commit ce8fb68165ea542258ff76df7d316ca9359575d4 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-05-03T07:10:07Z TAJO-2142
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/1010#issuecomment-216455567

        This patch is based on #1009.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/1010#issuecomment-216455567 This patch is based on #1009.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/1010#issuecomment-217079733

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/1010#issuecomment-217079733 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/1010#issuecomment-217080493

        Thanks for your review!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/1010#issuecomment-217080493 Thanks for your review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/1010

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/1010
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #719 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/719/)
        TAJO-2142: Temporarily disable NOT IN subquery. (jihoonson: rev 0a2535e677e192574221aa0547b4cbc1027a7c8b)

        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/InSubqueryRewriteRule.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestInSubquery.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #719 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/719/ ) TAJO-2142 : Temporarily disable NOT IN subquery. (jihoonson: rev 0a2535e677e192574221aa0547b4cbc1027a7c8b) tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/InSubqueryRewriteRule.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestInSubquery.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1138 (See https://builds.apache.org/job/Tajo-master-build/1138/)
        TAJO-2142: Temporarily disable NOT IN subquery. (jihoonson: rev 0a2535e677e192574221aa0547b4cbc1027a7c8b)

        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/InSubqueryRewriteRule.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestInSubquery.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1138 (See https://builds.apache.org/job/Tajo-master-build/1138/ ) TAJO-2142 : Temporarily disable NOT IN subquery. (jihoonson: rev 0a2535e677e192574221aa0547b4cbc1027a7c8b) tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/InSubqueryRewriteRule.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestInSubquery.java CHANGES

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development