Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2119

Invalid sort result when sort key columns contain non-ascii values

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.3
    • Component/s: Sort algorithm
    • Labels:
      None

      Description

      See the title. You can reproduce like below.

      tpcds> select c_birth_country from customer order by c_birth_country;
      
      ...
      CAYMAN ISLANDS
      CAYMAN ISLANDS
      CAYMAN ISLANDS
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CÔTE D'IVOIRE
      CANADA
      CANADA
      CANADA
      CANADA
      CANADA
      CANADA
      CANADA
      CAPE VERDE
      CAPE VERDE
      CAPE VERDE
      CAYMAN ISLANDS
      CAYMAN ISLANDS
      CAYMAN ISLANDS
      CÔTE D'IVOIRE
      CANADA
      CANADA
      ...
      

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        This patch is to fix a critical bug, so necessary to commit to our next minor release 0.11.3.

        Show
        jihoonson Jihoon Son added a comment - This patch is to fix a critical bug, so necessary to commit to our next minor release 0.11.3.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson closed the pull request at:

        https://github.com/apache/tajo/pull/998

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson closed the pull request at: https://github.com/apache/tajo/pull/998
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1121 (See https://builds.apache.org/job/Tajo-master-build/1121/)
        TAJO-2119: Invalid sort result when sort key columns contain non-ascii (jihoonson: rev 45100ced2c44e92eed1c24bc58a118e74f58d277)

        • CHANGES
        • tajo-common/src/test/java/org/apache/tajo/tuple/memory/TestUnSafeTupleBytesComparator.java
        • tajo-common/src/main/java/org/apache/tajo/tuple/memory/UnSafeTupleBytesComparator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1121 (See https://builds.apache.org/job/Tajo-master-build/1121/ ) TAJO-2119 : Invalid sort result when sort key columns contain non-ascii (jihoonson: rev 45100ced2c44e92eed1c24bc58a118e74f58d277) CHANGES tajo-common/src/test/java/org/apache/tajo/tuple/memory/TestUnSafeTupleBytesComparator.java tajo-common/src/main/java/org/apache/tajo/tuple/memory/UnSafeTupleBytesComparator.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #706 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/706/)
        TAJO-2119: Invalid sort result when sort key columns contain non-ascii (jihoonson: rev 45100ced2c44e92eed1c24bc58a118e74f58d277)

        • tajo-common/src/test/java/org/apache/tajo/tuple/memory/TestUnSafeTupleBytesComparator.java
        • tajo-common/src/main/java/org/apache/tajo/tuple/memory/UnSafeTupleBytesComparator.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #706 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/706/ ) TAJO-2119 : Invalid sort result when sort key columns contain non-ascii (jihoonson: rev 45100ced2c44e92eed1c24bc58a118e74f58d277) tajo-common/src/test/java/org/apache/tajo/tuple/memory/TestUnSafeTupleBytesComparator.java tajo-common/src/main/java/org/apache/tajo/tuple/memory/UnSafeTupleBytesComparator.java CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/998#issuecomment-210293908

        Thanks for quick review!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/998#issuecomment-210293908 Thanks for quick review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/998#issuecomment-210290864

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/998#issuecomment-210290864 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/998

        TAJO-2119: Invalid sort result when sort key columns contain non-ascii values

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-2119

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/998.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #998


        commit c714d920e60ecbb9bb2f2bf76c210d778c85efe1
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-04-15T03:22:36Z

        TAJO-2119


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/998 TAJO-2119 : Invalid sort result when sort key columns contain non-ascii values You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-2119 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/998.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #998 commit c714d920e60ecbb9bb2f2bf76c210d778c85efe1 Author: Jihoon Son <jihoonson@apache.org> Date: 2016-04-15T03:22:36Z TAJO-2119

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development