Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2100

Add missing cancellation in defaultTaskScheduler when a worker is no respond

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      if a worker is not respond, requested task should be canceled

      2016-03-17 11:53:36,270 INFO org.apache.tajo.querymaster.DefaultTaskScheduler: [eb_1458117238659_0223_000002] Assigned Local/Rack/Total: (0/1/1), Attempted Cancel/Assign/Total: (0/1/1), Locality: 0.00%, Rack host: host03
      2016-03-17 11:53:36,352 ERROR org.apache.tajo.rpc.NettyClientBase: Exception [org.apache.tajo.ipc.TajoWorkerProtocol(xx.xxx.xxx.xxx:28091)]: 
      2016-03-17 11:53:36,352 ERROR org.apache.tajo.querymaster.DefaultTaskScheduler: java.util.concurrent.ExecutionException: com.google.protobuf.ServiceException:
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.2-build #182 (See https://builds.apache.org/job/Tajo-0.11.2-build/182/)
        TAJO-2100: Add missing cancellation in defaultTaskScheduler when a (jhkim: rev 1ec59c12af5020cbcb65d13dde4de37a96d10eb1)

        • tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.2-build #182 (See https://builds.apache.org/job/Tajo-0.11.2-build/182/ ) TAJO-2100 : Add missing cancellation in defaultTaskScheduler when a (jhkim: rev 1ec59c12af5020cbcb65d13dde4de37a96d10eb1) tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1104 (See https://builds.apache.org/job/Tajo-master-build/1104/)
        TAJO-2100: Add missing cancellation in defaultTaskScheduler when a (jhkim: rev dbaf9725a7063ed4185671a3beda436494a00bfd)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1104 (See https://builds.apache.org/job/Tajo-master-build/1104/ ) TAJO-2100 : Add missing cancellation in defaultTaskScheduler when a (jhkim: rev dbaf9725a7063ed4185671a3beda436494a00bfd) CHANGES tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #694 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/694/)
        TAJO-2100: Add missing cancellation in defaultTaskScheduler when a (jhkim: rev dbaf9725a7063ed4185671a3beda436494a00bfd)

        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #694 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/694/ ) TAJO-2100 : Add missing cancellation in defaultTaskScheduler when a (jhkim: rev dbaf9725a7063ed4185671a3beda436494a00bfd) tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/querymaster/TaskAttempt.java CHANGES
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks for your quick review!

        Show
        jhkim Jinho Kim added a comment - committed it Thanks for your quick review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/983

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/983
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/983#issuecomment-198164623

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/983#issuecomment-198164623 +1 ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/983

        TAJO-2100: Add missing cancellation in defaultTaskScheduler when a wo…

        …rker is no respond.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-2100

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/983.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #983


        commit f556045a2f6331f47954d653d0317dce2cfcb2ac
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2016-03-17T09:39:00Z

        TAJO-2100: Add missing cancellation in defaultTaskScheduler when a worker is no respond.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/983 TAJO-2100 : Add missing cancellation in defaultTaskScheduler when a wo… …rker is no respond. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2100 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #983 commit f556045a2f6331f47954d653d0317dce2cfcb2ac Author: Jinho Kim <jhkim@apache.org> Date: 2016-03-17T09:39:00Z TAJO-2100 : Add missing cancellation in defaultTaskScheduler when a worker is no respond.

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development