Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2095

HiveCatalogStore::existIndexesByTable should not throw UnsupportedOperationException.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: Catalog
    • Labels:
      None

      Description

      \d command in tsql will cause the following exception on tables in Hive metastore. It shouldn't throw the verbose exception. Also, the exception must be new TajoRuntimeException(new UnsupportedException) instead of UnsupportedOperationException.

      java.lang.UnsupportedOperationException
              at org.apache.tajo.catalog.store.HiveCatalogStore.existIndexesByTable(HiveCatalogStore.java:992)
              at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.existIndexesByTable(CatalogServer.java:1182)
              at org.apache.tajo.catalog.AbstractCatalogClient.existIndexesByTable(AbstractCatalogClient.java:671)
              at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.existIndexesForTable(TajoMasterClientService.java:1092)
              at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:729)
              at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.channelRead0(BlockingRpcServer.java:100)
              at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.channelRead0(BlockingRpcServer.java:61)
              at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
      

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        Some boolean methods should return just false. Other methods which returns some objects should throw new TajoRuntimeException(new UnsupportedException).

        Show
        hyunsik Hyunsik Choi added a comment - - edited Some boolean methods should return just false. Other methods which returns some objects should throw new TajoRuntimeException(new UnsupportedException) .
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/976

        TAJO-2095: HiveCatalogStore::existIndexesByTable should not throw upportedOperationException.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-2095

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/976.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #976


        commit 0731613bd4642670153525c5b2a6154c3d111a1e
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2016-03-14T23:50:08Z

        TAJO-2095: HiveCatalogStore::existIndexesByTable should not throw UnsupportedOperationException.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/976 TAJO-2095 : HiveCatalogStore::existIndexesByTable should not throw upportedOperationException. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-2095 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/976.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #976 commit 0731613bd4642670153525c5b2a6154c3d111a1e Author: Hyunsik Choi <hyunsik@apache.org> Date: 2016-03-14T23:50:08Z TAJO-2095 : HiveCatalogStore::existIndexesByTable should not throw UnsupportedOperationException.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/976#issuecomment-197165570

        +1 LGTM!
        Travis failure is not related this PR

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/976#issuecomment-197165570 +1 LGTM! Travis failure is not related this PR
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed this patch to master and branch-0.11.2.

        Show
        hyunsik Hyunsik Choi added a comment - committed this patch to master and branch-0.11.2.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/976

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/976
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.2-build #180 (See https://builds.apache.org/job/Tajo-0.11.2-build/180/)
        TAJO-2095: HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev ff816003a4c0f621452ee4510799b6acbae6d813)

        • CHANGES
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.2-build #180 (See https://builds.apache.org/job/Tajo-0.11.2-build/180/ ) TAJO-2095 : HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev ff816003a4c0f621452ee4510799b6acbae6d813) CHANGES tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #693 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/693/)
        TAJO-2095: HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev 87e2a7a22122d3d70b2f3aa83b09c2539426fdf7)

        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #693 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/693/ ) TAJO-2095 : HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev 87e2a7a22122d3d70b2f3aa83b09c2539426fdf7) tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1102 (See https://builds.apache.org/job/Tajo-master-build/1102/)
        TAJO-2095: HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev 87e2a7a22122d3d70b2f3aa83b09c2539426fdf7)

        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1102 (See https://builds.apache.org/job/Tajo-master-build/1102/ ) TAJO-2095 : HiveCatalogStore::existIndexesByTable should not throw (hyunsik: rev 87e2a7a22122d3d70b2f3aa83b09c2539426fdf7) tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development