Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2091

Error or progress update should use stderr instead of stdout

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: cli
    • Labels:
      None

      Description

      Error or progress update message should be separated from stderr for those who want to use "tsql -c" command.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/977

        TAJO-2091: Error or progress update should use stderr instead of stdout.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-2091

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/977.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #977


        commit 02da23b62b4124c59565435f58ceaeaecc20c842
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2016-03-15T00:42:22Z

        TAJO-2091: Error or progress update should use stderr instead of stdout.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/977 TAJO-2091 : Error or progress update should use stderr instead of stdout. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-2091 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/977.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #977 commit 02da23b62b4124c59565435f58ceaeaecc20c842 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2016-03-15T00:42:22Z TAJO-2091 : Error or progress update should use stderr instead of stdout.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/977#issuecomment-199138510

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/977#issuecomment-199138510 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/977

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/977
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed to master branch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #696 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/696/)
        TAJO-2091: Error or progress update should use stderr instead of stdout. (hyunsik: rev 9fcc9fd3af4479c3042e4907938b18b6e264b500)

        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result
        • CHANGES
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #696 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/696/ ) TAJO-2091 : Error or progress update should use stderr instead of stdout. (hyunsik: rev 9fcc9fd3af4479c3042e4907938b18b6e264b500) tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result CHANGES tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1106 (See https://builds.apache.org/job/Tajo-master-build/1106/)
        TAJO-2091: Error or progress update should use stderr instead of stdout. (hyunsik: rev 9fcc9fd3af4479c3042e4907938b18b6e264b500)

        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • CHANGES
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1106 (See https://builds.apache.org/job/Tajo-master-build/1106/ ) TAJO-2091 : Error or progress update should use stderr instead of stdout. (hyunsik: rev 9fcc9fd3af4479c3042e4907938b18b6e264b500) tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java CHANGES tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to branch-0.11.2 too.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to branch-0.11.2 too.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.2-build #184 (See https://builds.apache.org/job/Tajo-0.11.2-build/184/)
        TAJO-2091: Error or progress update should use stderr instead of stdout. (hyunsik: rev 239370a8b52d46b2d815f27a0034f9fb33e84d5c)

        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java
        • tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.2-build #184 (See https://builds.apache.org/job/Tajo-0.11.2-build/184/ ) TAJO-2091 : Error or progress update should use stderr instead of stdout. (hyunsik: rev 239370a8b52d46b2d815f27a0034f9fb33e84d5c) tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.result tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.result tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestHdfsCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.err tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoAdminCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.err tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExecExternalShellCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testSelectResultWithNullTrueDeprecated.result tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoHAAdminCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenError.result tajo-core-tests/src/test/resources/results/TestTajoCli/testAddPartitionNotimplementedException.err tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/commands/TestExecExternalShellCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ExitCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HdfsCommand.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java tajo-core-tests/src/test/resources/results/TestTajoCli/testStopWhenErrorDeprecated.err tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/HelpCommand.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development