Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2089

Improve null handling in UDF

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.12.0, 0.11.2
        • Component/s: Function/UDF
        • Labels:
          None

          Description

          A null value should convert to NullDatum in UDF. if not, it throw a TajoInternalError. Many people mistake the null handling.
          So we add null handling, it would be better

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            GitHub user jinossy opened a pull request:

            https://github.com/apache/tajo/pull/972

            TAJO-2089: Improve null handling in UDF.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/jinossy/tajo TAJO-2089

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/tajo/pull/972.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #972

            commit 07b64dec0f904e2a9d0453e46340d4ca6efed318
            Author: Jinho Kim <jhkim@apache.org>
            Date: 2016-03-07T05:45:47Z

            TAJO-2089: Improve null handling in UDF.

            Show
            githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/972 TAJO-2089 : Improve null handling in UDF. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2089 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/972.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #972 commit 07b64dec0f904e2a9d0453e46340d4ca6efed318 Author: Jinho Kim <jhkim@apache.org> Date: 2016-03-07T05:45:47Z TAJO-2089 : Improve null handling in UDF.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user blrunner commented on the pull request:

            https://github.com/apache/tajo/pull/972#issuecomment-193561687

            +1

            LGTM! I found that ResultSet of TajoClient using some test queries had retrieved null values.

            Show
            githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/972#issuecomment-193561687 +1 LGTM! I found that ResultSet of TajoClient using some test queries had retrieved null values.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/tajo/pull/972

            Show
            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/972
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            committed it
            Thanks for your review!

            Show
            jhkim Jinho Kim added a comment - committed it Thanks for your review!
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Tajo-master-CODEGEN-build #690 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/690/)
            TAJO-2089: Improve null handling in UDF. (jhkim: rev 6942fa39900bfd6c41ffb305844101ab9ea4c933)

            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java
            • CHANGES
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
            • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java
            • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #690 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/690/ ) TAJO-2089 : Improve null handling in UDF. (jhkim: rev 6942fa39900bfd6c41ffb305844101ab9ea4c933) tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Tajo-master-build #1099 (See https://builds.apache.org/job/Tajo-master-build/1099/)
            TAJO-2089: Improve null handling in UDF. (jhkim: rev 6942fa39900bfd6c41ffb305844101ab9ea4c933)

            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
            • CHANGES
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
            • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
            • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1099 (See https://builds.apache.org/job/Tajo-master-build/1099/ ) TAJO-2089 : Improve null handling in UDF. (jhkim: rev 6942fa39900bfd6c41ffb305844101ab9ea4c933) tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Tajo-0.11.2-build #178 (See https://builds.apache.org/job/Tajo-0.11.2-build/178/)
            TAJO-2089: Improve null handling in UDF. (jhkim: rev e65f4a2b406210bd25daf8e2f68b5d332b2eec45)

            • CHANGES
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
            • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
            • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java
            • tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.2-build #178 (See https://builds.apache.org/job/Tajo-0.11.2-build/178/ ) TAJO-2089 : Improve null handling in UDF. (jhkim: rev e65f4a2b406210bd25daf8e2f68b5d332b2eec45) CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestPatternMatchingPredicates.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestUserDefinedFunctions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core-tests/src/test/java/org/apache/tajo/engine/codegen/TestEvalCodeGenerator.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/TestJsonFunctions.java tajo-core-tests/src/test/java/org/apache/tajo/engine/function/NullTestFunction.java

              People

              • Assignee:
                jhkim Jinho Kim
                Reporter:
                jhkim Jinho Kim
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development