Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2057

Remove redundant class loading in plan optimizer

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.12.0, 0.11.1
        • Component/s: Planner/Optimizer
        • Labels:
          None

          Description

          Some static rules of optimizer is loaded per query. we should remove redundant class loading for low latency

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            GitHub user jinossy opened a pull request:

            https://github.com/apache/tajo/pull/943

            TAJO-2057: Remove redundant class loading in plan optimizer.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/jinossy/tajo TAJO-2057

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/tajo/pull/943.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #943

            commit 9a386422d7d3decc27bf7fe2bc9ac311a825b9a8
            Author: Jinho Kim <jhkim@apache.org>
            Date: 2016-01-15T06:45:01Z

            TAJO-2057: Remove redundant class loading in plan optimizer.

            Show
            githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/943 TAJO-2057 : Remove redundant class loading in plan optimizer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/943.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #943 commit 9a386422d7d3decc27bf7fe2bc9ac311a825b9a8 Author: Jinho Kim <jhkim@apache.org> Date: 2016-01-15T06:45:01Z TAJO-2057 : Remove redundant class loading in plan optimizer.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user eminency commented on the pull request:

            https://github.com/apache/tajo/pull/943#issuecomment-171945025

            +1
            It looks so clear.

            Show
            githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/943#issuecomment-171945025 +1 It looks so clear.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user jihoonson commented on the pull request:

            https://github.com/apache/tajo/pull/943#issuecomment-172037396

            +1 LGTM

            Show
            githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/943#issuecomment-172037396 +1 LGTM
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/tajo/pull/943

            Show
            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/943
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Tajo-master-CODEGEN-build #655 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/655/)
            TAJO-2057: Remove redundant class loading in plan optimizer. (jhkim: rev 099c2cd837c71bf0d80a13ddc6e5bff8e5c8e3ae)

            • tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java
            • CHANGES
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #655 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/655/ ) TAJO-2057 : Remove redundant class loading in plan optimizer. (jhkim: rev 099c2cd837c71bf0d80a13ddc6e5bff8e5c8e3ae) tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            committed it
            Thanks for the review!

            Show
            jhkim Jinho Kim added a comment - committed it Thanks for the review!
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Tajo-master-build #1053 (See https://builds.apache.org/job/Tajo-master-build/1053/)
            TAJO-2057: Remove redundant class loading in plan optimizer. (jhkim: rev 099c2cd837c71bf0d80a13ddc6e5bff8e5c8e3ae)

            • CHANGES
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #1053 (See https://builds.apache.org/job/Tajo-master-build/1053/ ) TAJO-2057 : Remove redundant class loading in plan optimizer. (jhkim: rev 099c2cd837c71bf0d80a13ddc6e5bff8e5c8e3ae) CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Tajo-0.11.1-build #151 (See https://builds.apache.org/job/Tajo-0.11.1-build/151/)
            TAJO-2057: Remove redundant class loading in plan optimizer. (jhkim: rev b1e0149421b6a520e3f636d922a69688e99979c9)

            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java
            • CHANGES
            • tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java
            • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.1-build #151 (See https://builds.apache.org/job/Tajo-0.11.1-build/151/ ) TAJO-2057 : Remove redundant class loading in plan optimizer. (jhkim: rev b1e0149421b6a520e3f636d922a69688e99979c9) tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessPhaseProvider.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/exprrewrite/EvalTreeOptimizer.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanPreprocessEngine.java

              People

              • Assignee:
                jhkim Jinho Kim
                Reporter:
                jhkim Jinho Kim
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development