Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Storage
    • Labels:
      None

      Description

      getProgress can cause NPE when scanner are closed

      2016-01-06 07:51:57,746 ERROR: org.apache.tajo.worker.ExecutionBlockContext (run(471)) - 
      java.lang.NullPointerException
      	at org.apache.tajo.storage.text.DelimitedTextFile$DelimitedTextFileScanner.getProgress(DelimitedTextFile.java:358)
      	at org.apache.tajo.engine.planner.physical.SeqScanExec.getProgress(SeqScanExec.java:345)
      	at org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.getProgress(UnaryPhysicalExec.java:87)
      	at org.apache.tajo.worker.TaskImpl.updateProgress(TaskImpl.java:319)
      	at org.apache.tajo.worker.ExecutionBlockContext$Reporter$1.run(ExecutionBlockContext.java:467)
      	at java.lang.Thread.run(Thread.java:745)
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/930

        TAJO-2038: NPE in DelimitedTextFileScanner#getProgress.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-2038

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/930.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #930


        commit 9a87a281bef3df42fdfc5b036c90c4394b4ced8d
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2016-01-07T03:17:43Z

        TAJO-2038: NPE in DelimitedTextFileScanner#getProgress.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/930 TAJO-2038 : NPE in DelimitedTextFileScanner#getProgress. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2038 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/930.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #930 commit 9a87a281bef3df42fdfc5b036c90c4394b4ced8d Author: Jinho Kim <jhkim@apache.org> Date: 2016-01-07T03:17:43Z TAJO-2038 : NPE in DelimitedTextFileScanner#getProgress.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/930#discussion_r49407294

        — Diff: CHANGES —
        @@ -1,5 +1,6 @@
        Tajo Change Log

        +
        — End diff –

        It seems to be an unnecessary modification.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on a diff in the pull request: https://github.com/apache/tajo/pull/930#discussion_r49407294 — Diff: CHANGES — @@ -1,5 +1,6 @@ Tajo Change Log + — End diff – It seems to be an unnecessary modification.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/930#issuecomment-170757410

        +1

        LGTM! I just leaved a trivial comment. Before committing this PR, check it again.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/930#issuecomment-170757410 +1 LGTM! I just leaved a trivial comment. Before committing this PR, check it again.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/930

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/930
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks for your review!

        Show
        jhkim Jinho Kim added a comment - committed it Thanks for your review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #650 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/650/)
        TAJO-2038: NPE in DelimitedTextFileScanner#getProgress. (jhkim: rev f62d34beab7fba2da6a54ad88eb37fed093c37b5)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #650 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/650/ ) TAJO-2038 : NPE in DelimitedTextFileScanner#getProgress. (jhkim: rev f62d34beab7fba2da6a54ad88eb37fed093c37b5) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #1046 (See https://builds.apache.org/job/Tajo-master-build/1046/)
        TAJO-2038: NPE in DelimitedTextFileScanner#getProgress. (jhkim: rev f62d34beab7fba2da6a54ad88eb37fed093c37b5)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #1046 (See https://builds.apache.org/job/Tajo-master-build/1046/ ) TAJO-2038 : NPE in DelimitedTextFileScanner#getProgress. (jhkim: rev f62d34beab7fba2da6a54ad88eb37fed093c37b5) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.1-build #147 (See https://builds.apache.org/job/Tajo-0.11.1-build/147/)
        TAJO-2038: NPE in FileScanner#getProgress. (jhkim: rev d533ea8387706209bab84c79db255e7ab3a7bd62)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.1-build #147 (See https://builds.apache.org/job/Tajo-0.11.1-build/147/ ) TAJO-2038 : NPE in FileScanner#getProgress. (jhkim: rev d533ea8387706209bab84c79db255e7ab3a7bd62) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/avro/AvroScanner.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development