GitHub user combineads opened a pull request:

https://github.com/apache/tajo/pull/922

TAJO-2032: Change tajo.rest.service.port to be the general style in TAJO.

Change the variable name to tajo.rest.service-http.address from tajo.rest.service.port with the default value 0.0.0.0:26880. And then it was modified to refer to several classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/combineads/tajo TAJO-2032

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tajo/pull/922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #922

commit d3ffcabb44539427532da20678c788e867098800
Author: Byunghwa Yun <combine@combineads.co.kr>
Date: 2015-12-16T05:26:27Z

Remove unused import class

commit 31637c41cdcebbccc5854de8a131e5cd86f1c4a3
Author: combineads <combine@combineads.co.kr>
Date: 2015-12-16T05:57:01Z

Merge remote-tracking branch 'upstream/master'

commit 463dd93c0dcc0b5f022308ad2adc3da7068c4441
Author: combineads <combine@combineads.co.kr>
Date: 2015-12-18T02:35:32Z

Merge remote-tracking branch 'upstream/master'

commit f75836171c20751b91efa6a9854f669c1d0247d3
Author: Jongyoung Park <eminency@gmail.com>
Date: 2015-12-21T10:15:56Z

TAJO-1997: Registering UDF, it needs to check duplication.

Closes #883

Signed-off-by: Jihoon Son <jihoonson@apache.org>

commit b151f5d29c60182a178645eb4fdb4dcd498dc318
Author: Byunghwa Yun <combine@combineads.co.kr>
Date: 2015-12-24T01:02:23Z

TAJO-1858: Aligning error message in execute query page of web UI is
needed.

commit c0559d7ebe3832a3090cbd9e14dfeacea0bd8eb9
Author: Byunghwa Yun <combine@combineads.co.kr>
Date: 2015-12-24T06:26:31Z

TAJO-1858: Aligning error message in execute query page of web UI is needed.

Closes #921

Signed-off-by: Jihoon Son <jihoonson@apache.org>

commit 70c5e6460f8a17d457245c06cfdd84d243a9fd7c
Author: Jihoon Son <jihoonson@apache.org>
Date: 2015-12-24T09:17:56Z

TAJO-1950: Query master uses too much memory during range shuffle.

Closes #884

commit 179497845b746d66b64fc1c89397b04c26fa52a7
Author: charsyam <charsyam@apache.org>
Date: 2015-12-25T15:27:29Z

TAJO-1944: Support text resultset for REST

Closes #876

commit f5a577e32ceda86ebc6529c66e9816681c3dfdbb
Author: Byunghwa Yun <combine@combineads.co.kr>
Date: 2015-12-29T13:04:44Z

Merge remote-tracking branch 'upstream/master'

commit 200bdd55f15d438e37f2d68a830cc823ebefc312
Author: Byunghwa Yun <combine@combineads.co.kr>
Date: 2015-12-29T14:43:54Z

TAJO-2032: Change tajo.rest.service.port to be the general style in
TAJO.

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/922#discussion_r48939447

— Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java —
@@ -140,7 +140,7 @@ public static int setDateOrder(int dateOrder) {
TAJO_MASTER_INFO_ADDRESS("tajo.master.info-http.address", "0.0.0.0:26080", Validators.networkAddr()),

// Tajo Rest Service

• REST_SERVICE_PORT("tajo.rest.service.port", 26880),
  + REST_SERVICE_ADDRESS("tajo.rest.service-http.address", "0.0.0.0:26880", Validators.networkAddr()),
  • • End diff –

IMO, ```tajo.rest.service-http.address``` seems to have a duplicate meaning because rest service is mostly based on http. How about ```tajo.rest.service.address```?

Github user combineads commented on the pull request:

https://github.com/apache/tajo/pull/922#issuecomment-169282139

Hi @jihoonson .
I was to change a property name to tajo.rest.service.address from tajo.rest.service-http.address.
Thank you.

Github user combineads commented on the pull request:

https://github.com/apache/tajo/pull/922#issuecomment-171589015

@jihoonson Anything else to commit this PR?

Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/922#issuecomment-171886891

Sorry for late response.
+1, This patch looks good to me.

Github user asfgit closed the pull request at:

https://github.com/apache/tajo/pull/922

FAILURE: Integrated in Tajo-master-CODEGEN-build #653 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/653/)
TAJO-2032: Change tajo.rest.service.port to be the general style in (jihoonson: rev 845e7c35a5eb96b6c70375ee288324c0cb052226)

• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java
• CHANGES
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
• tajo-rpc/tajo-ws-rs/src/main/java/org/apache/tajo/ws/rs/netty/NettyRestServerFactory.java
• tajo-core-tests/src/test/java/org/apache/tajo/ha/TestHAServiceHDFSImpl.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestSessionsResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestClusterResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestDatabasesResource.java
• tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
• tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
• tajo-core/src/main/java/org/apache/tajo/ws/rs/TajoRestService.java

SUCCESS: Integrated in Tajo-0.11.1-build #150 (See https://builds.apache.org/job/Tajo-0.11.1-build/150/)
TAJO-2032: Change tajo.rest.service.port to be the general style in (jihoonson: rev fcf1ae1a18ac5ca7df6795d99cb80d6f78569107)

• tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestSessionsResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestDatabasesResource.java
• CHANGES
• tajo-core-tests/src/test/java/org/apache/tajo/ha/TestHAServiceHDFSImpl.java
• tajo-rpc/tajo-ws-rs/src/main/java/org/apache/tajo/ws/rs/netty/NettyRestServerFactory.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
• tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestClusterResource.java
• tajo-core/src/main/java/org/apache/tajo/ws/rs/TajoRestService.java

SUCCESS: Integrated in Tajo-master-build #1051 (See https://builds.apache.org/job/Tajo-master-build/1051/)
TAJO-2032: Change tajo.rest.service.port to be the general style in (jihoonson: rev 845e7c35a5eb96b6c70375ee288324c0cb052226)

• tajo-core/src/main/java/org/apache/tajo/ws/rs/TajoRestService.java
• tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
• tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestClusterResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestSessionsResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java
• tajo-rpc/tajo-ws-rs/src/main/java/org/apache/tajo/ws/rs/netty/NettyRestServerFactory.java
• CHANGES
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestDatabasesResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java
• tajo-core-tests/src/test/java/org/apache/tajo/ha/TestHAServiceHDFSImpl.java