Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2018

Remove redundant 'String.toString()'

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Build
    • Labels:

      Description

      Remove any to call toString() on a String object.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dkhwangbo opened a pull request:

        https://github.com/apache/tajo/pull/908

        TAJO-2018: Remove redundant 'String.toString()'

        Remove any to call toString() on a String object.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dkhwangbo/tajo TAJO-2018

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/908.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #908


        commit 9f8808ddcae49f665904991563f70daa156081fe
        Author: Dongkyu Hwangbo <hwangbodk@gmail.com>
        Date: 2015-12-11T08:56:10Z

        initial commit


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dkhwangbo opened a pull request: https://github.com/apache/tajo/pull/908 TAJO-2018 : Remove redundant 'String.toString()' Remove any to call toString() on a String object. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dkhwangbo/tajo TAJO-2018 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/908.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #908 commit 9f8808ddcae49f665904991563f70daa156081fe Author: Dongkyu Hwangbo <hwangbodk@gmail.com> Date: 2015-12-11T08:56:10Z initial commit
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/908#issuecomment-169560167

        +1 LGTM!
        Thanks for your contribution!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/908#issuecomment-169560167 +1 LGTM! Thanks for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/908

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/908
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #647 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/647/)
        TAJO-2018: Remove redundant 'String.toString()'. (jhkim: rev 5853b47b4211bfd5437653eab345c1fcde6259cb)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java
        • tajo-core/src/main/resources/webapps/admin/task.jsp
        • tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-core/src/main/resources/webapps/admin/querytasks.jsp
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #647 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/647/ ) TAJO-2018 : Remove redundant 'String.toString()'. (jhkim: rev 5853b47b4211bfd5437653eab345c1fcde6259cb) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java tajo-core/src/main/resources/webapps/admin/task.jsp tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/src/main/resources/webapps/admin/querytasks.jsp
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1043 (See https://builds.apache.org/job/Tajo-master-build/1043/)
        TAJO-2018: Remove redundant 'String.toString()'. (jhkim: rev 5853b47b4211bfd5437653eab345c1fcde6259cb)

        • tajo-core/src/main/resources/webapps/admin/task.jsp
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java
        • tajo-core/src/main/resources/webapps/admin/querytasks.jsp
        • tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1043 (See https://builds.apache.org/job/Tajo-master-build/1043/ ) TAJO-2018 : Remove redundant 'String.toString()'. (jhkim: rev 5853b47b4211bfd5437653eab345c1fcde6259cb) tajo-core/src/main/resources/webapps/admin/task.jsp tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java tajo-core/src/main/resources/webapps/admin/querytasks.jsp tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.1-build #145 (See https://builds.apache.org/job/Tajo-0.11.1-build/145/)
        TAJO-2018: Remove redundant 'String.toString()'. (jhkim: rev 745cf091331d0960dbd1b56672449a507d95e1b8)

        • CHANGES
        • tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java
        • tajo-core/src/main/resources/webapps/admin/task.jsp
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-core/src/main/resources/webapps/admin/querytasks.jsp
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.1-build #145 (See https://builds.apache.org/job/Tajo-0.11.1-build/145/ ) TAJO-2018 : Remove redundant 'String.toString()'. (jhkim: rev 745cf091331d0960dbd1b56672449a507d95e1b8) CHANGES tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckClassAdapter.java tajo-core/src/main/resources/webapps/admin/task.jsp tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/MiniCatalogServer.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/src/main/resources/webapps/admin/querytasks.jsp tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/main/java/org/apache/tajo/plan/function/python/PythonScriptEngine.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java

          People

          • Assignee:
            dkhwangbo Dongkyu Hwangbo
            Reporter:
            dkhwangbo Dongkyu Hwangbo
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development