Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2017

Replace manual array copy with Collection

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: None
    • Labels:

      Description

      Copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll().

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1084 (See https://builds.apache.org/job/Tajo-master-build/1084/)
        TAJO-2017: Replace manual array copy with Collection. (jhkim: rev 4743c6ea3e2dfef8f27ee172bdcff9004bc7640b)

        • tajo-core-tests/src/test/java/org/apache/tajo/storage/TestFileFragment.java
        • tajo-core-tests/src/test/java/org/apache/tajo/master/TestRepartitioner.java
        • tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckMethodAdapter.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyThirdAggregationExec.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HFileAppender.java
        • CHANGES
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1084 (See https://builds.apache.org/job/Tajo-master-build/1084/ ) TAJO-2017 : Replace manual array copy with Collection. (jhkim: rev 4743c6ea3e2dfef8f27ee172bdcff9004bc7640b) tajo-core-tests/src/test/java/org/apache/tajo/storage/TestFileFragment.java tajo-core-tests/src/test/java/org/apache/tajo/master/TestRepartitioner.java tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckMethodAdapter.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyThirdAggregationExec.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HFileAppender.java CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks for your contribution!

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #678 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/678/)
        TAJO-2017: Replace manual array copy with Collection. (jhkim: rev 4743c6ea3e2dfef8f27ee172bdcff9004bc7640b)

        • tajo-core-tests/src/test/java/org/apache/tajo/storage/TestFileFragment.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HFileAppender.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckMethodAdapter.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyThirdAggregationExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        • tajo-core-tests/src/test/java/org/apache/tajo/master/TestRepartitioner.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #678 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/678/ ) TAJO-2017 : Replace manual array copy with Collection. (jhkim: rev 4743c6ea3e2dfef8f27ee172bdcff9004bc7640b) tajo-core-tests/src/test/java/org/apache/tajo/storage/TestFileFragment.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HFileAppender.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/util/CheckMethodAdapter.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyThirdAggregationExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java tajo-core-tests/src/test/java/org/apache/tajo/master/TestRepartitioner.java CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/907

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/907
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/907#issuecomment-184073041

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/907#issuecomment-184073041 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkhwangbo commented on the pull request:

        https://github.com/apache/tajo/pull/907#issuecomment-184068043

        @jinossy Hi! I rebase this patch. Thanks for your notice.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkhwangbo commented on the pull request: https://github.com/apache/tajo/pull/907#issuecomment-184068043 @jinossy Hi! I rebase this patch. Thanks for your notice.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/907#issuecomment-184065035

        Would you rebase your patch?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/907#issuecomment-184065035 Would you rebase your patch?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dkhwangbo opened a pull request:

        https://github.com/apache/tajo/pull/907

        TAJO-2017: Replace manual array copy with Collection

        Copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll().

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dkhwangbo/tajo TAJO-2017

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/907.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #907


        commit 1df496222939e4e9ab4cce7c5acd9d221ccc3963
        Author: Dongkyu Hwangbo <hwangbodk@gmail.com>
        Date: 2015-12-11T08:05:03Z

        initial commit

        commit 53b40e9265215b3980ebb8ab074b8fe15a58c63e
        Author: Dongkyu Hwangbo <hwangbodk@gmail.com>
        Date: 2015-12-11T08:08:01Z

        rollback unnecessarily changed


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dkhwangbo opened a pull request: https://github.com/apache/tajo/pull/907 TAJO-2017 : Replace manual array copy with Collection Copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). You can merge this pull request into a Git repository by running: $ git pull https://github.com/dkhwangbo/tajo TAJO-2017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/907.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #907 commit 1df496222939e4e9ab4cce7c5acd9d221ccc3963 Author: Dongkyu Hwangbo <hwangbodk@gmail.com> Date: 2015-12-11T08:05:03Z initial commit commit 53b40e9265215b3980ebb8ab074b8fe15a58c63e Author: Dongkyu Hwangbo <hwangbodk@gmail.com> Date: 2015-12-11T08:08:01Z rollback unnecessarily changed

          People

          • Assignee:
            dkhwangbo Dongkyu Hwangbo
            Reporter:
            dkhwangbo Dongkyu Hwangbo
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development