Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2014

TestRpcClientManager fails occasionally

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: RPC, Unit Test
    • Labels:
      None

      Description

      CloseListener can be registered to closed channel when reconnecting

      Here is the log

      java.lang.AssertionError
      	at org.junit.Assert.fail(Assert.java:86)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.junit.Assert.assertTrue(Assert.java:52)
      	at org.apache.tajo.rpc.TestRpcClientManager.testClientCloseEventWithReconnect(TestRpcClientManager.java:133)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/905

        TAJO-2014: TestRpcClientManager fails occasionally.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-2014

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/905.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #905


        commit 5177fde4176b8f86fd8faf27d304f862520aa4c4
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-12-09T08:07:02Z

        TAJO-2014: TestRpcClientManager fails occasionally.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/905 TAJO-2014 : TestRpcClientManager fails occasionally. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2014 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/905.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #905 commit 5177fde4176b8f86fd8faf27d304f862520aa4c4 Author: Jinho Kim <jhkim@apache.org> Date: 2015-12-09T08:07:02Z TAJO-2014 : TestRpcClientManager fails occasionally.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/905#issuecomment-163157866

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/905#issuecomment-163157866 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/905

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/905
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks for your quick review!

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks for your quick review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #625 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/625/)
        TAJO-2014: TestRpcClientManager fails occasionally. (jhkim: rev b1959116a7c129bc7de4156c366c81cebc14958a)

        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #625 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/625/ ) TAJO-2014 : TestRpcClientManager fails occasionally. (jhkim: rev b1959116a7c129bc7de4156c366c81cebc14958a) tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1020 (See https://builds.apache.org/job/Tajo-master-build/1020/)
        TAJO-2014: TestRpcClientManager fails occasionally. (jhkim: rev b1959116a7c129bc7de4156c366c81cebc14958a)

        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1020 (See https://builds.apache.org/job/Tajo-master-build/1020/ ) TAJO-2014 : TestRpcClientManager fails occasionally. (jhkim: rev b1959116a7c129bc7de4156c366c81cebc14958a) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java CHANGES tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.1-build #134 (See https://builds.apache.org/job/Tajo-0.11.1-build/134/)
        TAJO-2014: TestRpcClientManager fails occasionally. (jhkim: rev 94d02005daf93443bd343a60fca358db87d51c11)

        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java
        • CHANGES
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.1-build #134 (See https://builds.apache.org/job/Tajo-0.11.1-build/134/ ) TAJO-2014 : TestRpcClientManager fails occasionally. (jhkim: rev 94d02005daf93443bd343a60fca358db87d51c11) tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileTablespace.java CHANGES tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/raw/TestDirectRawFile.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development