Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      Currently, we set table volumes into TableDesc in LogicalPlanner. In this case, we cannot employ the push-downed filters for getting table volumes. For it, we should postpone getting table volumes as late as possible before join ordering optimization.

      This patch move the table stat update code into the last rewrite rune in pre rewriters.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/899

          TAJO-2005: Add TableStatUpdateRewriter.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-2005

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/899.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #899


          commit d967eeb38039fce1f100adb361c58ef9dd7743da
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-12-03T06:15:44Z

          TAJO-2005: Add TableStatUpdateRewriter.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/899 TAJO-2005 : Add TableStatUpdateRewriter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-2005 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #899 commit d967eeb38039fce1f100adb361c58ef9dd7743da Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-12-03T06:15:44Z TAJO-2005 : Add TableStatUpdateRewriter.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/899#issuecomment-161850474

          +1 LGTM!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/899#issuecomment-161850474 +1 LGTM!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/899

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/899
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #619 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/619/)
          TAJO-2005: Add TableStatUpdateRewriter. (hyunsik: rev 158bf1df931d92fc937e53af96ea382055424643)

          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/TableStatUpdateRewriter.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestJoinOrderAlgorithm.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/LogicalPlanRewriteRuleContext.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java
          • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalOptimizer.java
          • tajo-core-tests/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteRuleProvider.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortIntersectExec.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java
          • CHANGES
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestEvalNodeToExprConverter.java
          • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #619 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/619/ ) TAJO-2005 : Add TableStatUpdateRewriter. (hyunsik: rev 158bf1df931d92fc937e53af96ea382055424643) tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/TableStatUpdateRewriter.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestJoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/LogicalPlanRewriteRuleContext.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalOptimizer.java tajo-core-tests/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteRuleProvider.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortIntersectExec.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestEvalNodeToExprConverter.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #1012 (See https://builds.apache.org/job/Tajo-master-build/1012/)
          TAJO-2005: Add TableStatUpdateRewriter. (hyunsik: rev 158bf1df931d92fc937e53af96ea382055424643)

          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
          • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestEvalNodeToExprConverter.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalOptimizer.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortIntersectExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/TableStatUpdateRewriter.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
          • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/LogicalPlanRewriteRuleContext.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestJoinOrderAlgorithm.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteRuleProvider.java
          • CHANGES
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java
          • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
          • tajo-core-tests/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1012 (See https://builds.apache.org/job/Tajo-master-build/1012/ ) TAJO-2005 : Add TableStatUpdateRewriter. (hyunsik: rev 158bf1df931d92fc937e53af96ea382055424643) tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestEvalNodeToExprConverter.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalOptimizer.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortIntersectExec.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/TableStatUpdateRewriter.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteEngine.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/LogicalPlanRewriteRuleContext.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestJoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/BaseLogicalPlanRewriteRuleProvider.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-core-tests/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development