Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2001

DirectRawFileScanner.getProgress occasionally fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.1
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Storage
    • Labels:
      None

      Description

      if getProgress is called after scanner is closed, ClosedChannelException can cause

      Here is the log

      2015-11-30 17:15:09,131 ERROR org.apache.tajo.storage.rawfile.DirectRawFileScanner:
      java.nio.channels.ClosedChannelException
              at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:109)
              at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:252)
              at org.apache.tajo.storage.LocalFileInputChannel.position(LocalFileInputChannel.java:54)
              at org.apache.tajo.storage.rawfile.DirectRawFileScanner.getProgress(DirectRawFileScanner.java:221)
              at org.apache.tajo.engine.planner.physical.ExternalSortExec$PairWiseMerger.getProgress(ExternalSortExec.java:768)
              at org.apache.tajo.engine.planner.physical.ExternalSortExec$PairWiseMerger.getProgress(ExternalSortExec.java:768)
              at org.apache.tajo.engine.planner.physical.ExternalSortExec$PairWiseMerger.getProgress(ExternalSortExec.java:768)
              at org.apache.tajo.engine.planner.physical.ExternalSortExec.getProgress(ExternalSortExec.java:849)
              at org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.getProgress(UnaryPhysicalExec.java:87)
              at org.apache.tajo.worker.TaskImpl.updateProgress(TaskImpl.java:315)
              at org.apache.tajo.worker.ExecutionBlockContext$Reporter$1.run(ExecutionBlockContext.java:407)
              at java.lang.Thread.run(Thread.java:745)
      2015-11-30 17:15:09,131 ERROR org.apache.tajo.storage.rawfile.DirectRawFileScanner:
      java.nio.channels.ClosedChannelException
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/894

        TAJO-2001: DirectRawFileScanner.getProgress occasionally fails.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-2001

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/894.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #894


        commit ecab5c25d027944c445f1a1886ca33ec9294ec56
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-12-02T08:56:10Z

        TAJO-2001: DirectRawFileScanner.getProgress occasionally fails.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/894 TAJO-2001 : DirectRawFileScanner.getProgress occasionally fails. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/894.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #894 commit ecab5c25d027944c445f1a1886ca33ec9294ec56 Author: Jinho Kim <jhkim@apache.org> Date: 2015-12-02T08:56:10Z TAJO-2001 : DirectRawFileScanner.getProgress occasionally fails.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/894#issuecomment-161504826

        +1

        LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/894#issuecomment-161504826 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/894

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/894
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #613 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/613/)
        TAJO-2001: DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 8d513a5e8c8c8d5b69ba9630329736bb2bb7b86e)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #613 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/613/ ) TAJO-2001 : DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 8d513a5e8c8c8d5b69ba9630329736bb2bb7b86e) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks for your review!

        Show
        jhkim Jinho Kim added a comment - committed it Thanks for your review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1005 (See https://builds.apache.org/job/Tajo-master-build/1005/)
        TAJO-2001: DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 8d513a5e8c8c8d5b69ba9630329736bb2bb7b86e)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1005 (See https://builds.apache.org/job/Tajo-master-build/1005/ ) TAJO-2001 : DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 8d513a5e8c8c8d5b69ba9630329736bb2bb7b86e) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.1-build #124 (See https://builds.apache.org/job/Tajo-0.11.1-build/124/)
        TAJO-2001: DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 47e57a40ced41e30606176de1d1ed5ab075dd180)

        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.1-build #124 (See https://builds.apache.org/job/Tajo-0.11.1-build/124/ ) TAJO-2001 : DirectRawFileScanner.getProgress occasionally fails. (jhkim: rev 47e57a40ced41e30606176de1d1ed5ab075dd180) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/RawFile.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rawfile/DirectRawFileScanner.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development