Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1998

Waiting for gracefully stopping in tajo-deamon.sh is too short

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      Currently, default value of TAJO_STOP_TIMEOUT is 2 sec. In most cases, it kill process with '-9'
      TAJO_STOP_TIMEOUT should be increased

      localhost: stopping worker
      localhost: worker did not stop gracefully after 2 seconds: killing with kill -9
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/885

        TAJO-1998: Waiting for gracefully stopping in tajo-deamon.sh is too short

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1998

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/885.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #885


        commit 2e64a730535197646ce71a38349569557b3ad9de
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-11-27T08:19:56Z

        TAJO-1998: Waiting for gracefully stopping in tajo-deamon.sh is too short.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/885 TAJO-1998 : Waiting for gracefully stopping in tajo-deamon.sh is too short You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1998 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/885.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #885 commit 2e64a730535197646ce71a38349569557b3ad9de Author: Jinho Kim <jhkim@apache.org> Date: 2015-11-27T08:19:56Z TAJO-1998 : Waiting for gracefully stopping in tajo-deamon.sh is too short.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/885#issuecomment-161522992

        +1

        I found that the patch ran as expected on testing cluster as following:

            1. Before TAJO-1998
              ```
              $ ./bin/stop-tajo.sh
              Stopping single TajoMaster
              stopping master
              worker04: stopping worker
              worker02: stopping worker
              worker05: stopping worker
              worker03: stopping worker
              worker04: worker did not stop gracefully after 2 seconds: killing with kill -9
              worker02: worker did not stop gracefully after 2 seconds: killing with kill -9
              worker05: worker did not stop gracefully after 2 seconds: killing with kill -9
              worker03: worker did not stop gracefully after 2 seconds: killing with kill -9
              ```
            1. After TAJO-1998
              ```
              $ ./bin/stop-tajo.sh
              worker03: stopping worker
              worker04: stopping worker
              worker05: stopping worker
              worker02: stopping worker
              stopping master
              ```
        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/885#issuecomment-161522992 +1 I found that the patch ran as expected on testing cluster as following: Before TAJO-1998 ``` $ ./bin/stop-tajo.sh Stopping single TajoMaster stopping master worker04: stopping worker worker02: stopping worker worker05: stopping worker worker03: stopping worker worker04: worker did not stop gracefully after 2 seconds: killing with kill -9 worker02: worker did not stop gracefully after 2 seconds: killing with kill -9 worker05: worker did not stop gracefully after 2 seconds: killing with kill -9 worker03: worker did not stop gracefully after 2 seconds: killing with kill -9 ``` After TAJO-1998 ``` $ ./bin/stop-tajo.sh worker03: stopping worker worker04: stopping worker worker05: stopping worker worker02: stopping worker stopping master ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/885

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/885
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #615 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/615/)
        TAJO-1998: Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev e8dc34375d4fac329d5e79d17a221af007de814e)

        • tajo-dist/src/main/bin/tajo-daemon.sh
        • tajo-dist/src/main/bin/stop-tajo.sh
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #615 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/615/ ) TAJO-1998 : Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev e8dc34375d4fac329d5e79d17a221af007de814e) tajo-dist/src/main/bin/tajo-daemon.sh tajo-dist/src/main/bin/stop-tajo.sh CHANGES
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks for your review!

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks for your review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.1-build #125 (See https://builds.apache.org/job/Tajo-0.11.1-build/125/)
        TAJO-1998: Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev c2b3620a9543443ba2363cef8a81f99374b060f3)

        • tajo-dist/src/main/bin/tajo-daemon.sh
        • tajo-dist/src/main/bin/stop-tajo.sh
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.1-build #125 (See https://builds.apache.org/job/Tajo-0.11.1-build/125/ ) TAJO-1998 : Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev c2b3620a9543443ba2363cef8a81f99374b060f3) tajo-dist/src/main/bin/tajo-daemon.sh tajo-dist/src/main/bin/stop-tajo.sh CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1007 (See https://builds.apache.org/job/Tajo-master-build/1007/)
        TAJO-1998: Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev e8dc34375d4fac329d5e79d17a221af007de814e)

        • tajo-dist/src/main/bin/stop-tajo.sh
        • tajo-dist/src/main/bin/tajo-daemon.sh
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1007 (See https://builds.apache.org/job/Tajo-master-build/1007/ ) TAJO-1998 : Waiting for gracefully stopping in tajo-deamon.sh is too (jhkim: rev e8dc34375d4fac329d5e79d17a221af007de814e) tajo-dist/src/main/bin/stop-tajo.sh tajo-dist/src/main/bin/tajo-daemon.sh CHANGES

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development