Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Client
    • Labels:
      None

      Description

      \set timezone doesn't work.
      default> \set timezone GMT-3

      but TIMEZONE works.
      default> \set TIMEZONE GMT-3

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/886

        TAJO-1992 \set timezone in cli doesn't work because of casesensitive

        \set timezone doesn't work.
        default> \set timezone GMT-3

        but TIMEZONE works.
        default> \set TIMEZONE GMT-3

        so, this patch change timeZone -> TIMEZONE.name();

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/cli-timezone

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/886.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #886


        commit 1d1a353238be969eae59974d3f66c72178ced390
        Author: charsyam <charsyam@charsyamui-macbook-pro.local>
        Date: 2015-11-27T13:56:59Z

        TAJO-1992 \set timezone in cli doesn't work because of casesensitive


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/886 TAJO-1992 \set timezone in cli doesn't work because of casesensitive \set timezone doesn't work. default> \set timezone GMT-3 but TIMEZONE works. default> \set TIMEZONE GMT-3 so, this patch change timeZone -> TIMEZONE.name(); You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/cli-timezone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/886.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #886 commit 1d1a353238be969eae59974d3f66c72178ced390 Author: charsyam <charsyam@charsyamui-macbook-pro.local> Date: 2015-11-27T13:56:59Z TAJO-1992 \set timezone in cli doesn't work because of casesensitive
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/886#issuecomment-161534270

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/886#issuecomment-161534270 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/886

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/886
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #621 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/621/)
        TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev c770fe75caa44887ffb2bd17ad1d6b627f8e643e)

        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #621 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/621/ ) TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev c770fe75caa44887ffb2bd17ad1d6b627f8e643e) tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1015 (See https://builds.apache.org/job/Tajo-master-build/1015/)
        TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev c770fe75caa44887ffb2bd17ad1d6b627f8e643e)

        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1015 (See https://builds.apache.org/job/Tajo-master-build/1015/ ) TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev c770fe75caa44887ffb2bd17ad1d6b627f8e643e) CHANGES tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.1-build #132 (See https://builds.apache.org/job/Tajo-0.11.1-build/132/)
        TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev 2a1d9a04ad126122fad97c05aba1cef897092f8c)

        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.1-build #132 (See https://builds.apache.org/job/Tajo-0.11.1-build/132/ ) TAJO-1992 \set timezone in cli doesn't work because of casesensitive (charsyam: rev 2a1d9a04ad126122fad97c05aba1cef897092f8c) tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/SetCommand.java CHANGES

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development