Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Tools
    • Labels:
      None

      Description

      Currently, Tajo can reports metrics to Ganglia, file and console.
      I think it would be nice to report metrics via JMX.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user keybod opened a pull request:

        https://github.com/apache/tajo/pull/879

        TAJO-1985: Supporting Metric report via JMX.

        I added a JMX metric reporter.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/keybod/tajo TAJO-1985

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/879.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #879


        commit e07a9639f5cdd9483765b49c350e6602c4c87d8c
        Author: Yongjun Park <thehp.keybod@gmail.com>
        Date: 2015-11-25T08:23:59Z

        TAJO-1985: Add reporting metrics via JMX.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user keybod opened a pull request: https://github.com/apache/tajo/pull/879 TAJO-1985 : Supporting Metric report via JMX. I added a JMX metric reporter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/keybod/tajo TAJO-1985 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/879.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #879 commit e07a9639f5cdd9483765b49c350e6602c4c87d8c Author: Yongjun Park <thehp.keybod@gmail.com> Date: 2015-11-25T08:23:59Z TAJO-1985 : Add reporting metrics via JMX.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/879#issuecomment-159547563

        Travis failure is not related this PR
        Could you trigger the travis CI?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/879#issuecomment-159547563 Travis failure is not related this PR Could you trigger the travis CI?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/879#discussion_r46014251

        — Diff: tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java —
        @@ -113,6 +117,9 @@ public void start() {

        final String jvmMetricsName = metricsGroupName + "-JVM";
        setMetricsReporter(jvmMetricsName);
        + jmxReporter = JmxReporter.forRegistry(metricRegistry).inDomain("Tajo")
        — End diff –

        This line should move into the ’if(!inited) {}’

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/879#discussion_r46014251 — Diff: tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java — @@ -113,6 +117,9 @@ public void start() { final String jvmMetricsName = metricsGroupName + "-JVM"; setMetricsReporter(jvmMetricsName); + jmxReporter = JmxReporter.forRegistry(metricRegistry).inDomain("Tajo") — End diff – This line should move into the ’if(!inited) {}’
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user keybod commented on the pull request:

        https://github.com/apache/tajo/pull/879#issuecomment-160032738

        Thank you for reviewing!
        I have applied it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user keybod commented on the pull request: https://github.com/apache/tajo/pull/879#issuecomment-160032738 Thank you for reviewing! I have applied it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/879#issuecomment-160032933

        +1 LGTM!
        Thanks for your contribution!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/879#issuecomment-160032933 +1 LGTM! Thanks for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/879

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/879
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #607 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/607/)
        TAJO-1985: Add reporting metrics via JMX. (jhkim: rev 821fc172b93125170aed85aa6f9ff19a727999d4)

        • tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #607 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/607/ ) TAJO-1985 : Add reporting metrics via JMX. (jhkim: rev 821fc172b93125170aed85aa6f9ff19a727999d4) tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java CHANGES
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #996 (See https://builds.apache.org/job/Tajo-master-build/996/)
        TAJO-1985: Add reporting metrics via JMX. (jhkim: rev 821fc172b93125170aed85aa6f9ff19a727999d4)

        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #996 (See https://builds.apache.org/job/Tajo-master-build/996/ ) TAJO-1985 : Add reporting metrics via JMX. (jhkim: rev 821fc172b93125170aed85aa6f9ff19a727999d4) tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.1-build #117 (See https://builds.apache.org/job/Tajo-0.11.1-build/117/)
        TAJO-1985: Supporting Metric report via JMX. (jhkim: rev 92fd55858f0dcb76dba3151f3a46076254493349)

        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java
        • tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.1-build #117 (See https://builds.apache.org/job/Tajo-0.11.1-build/117/ ) TAJO-1985 : Supporting Metric report via JMX. (jhkim: rev 92fd55858f0dcb76dba3151f3a46076254493349) tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoJMXObjectNameFactory.java tajo-core-tests/src/test/java/org/apache/tajo/util/metrics/TestJMXTajoObjectNameFactory.java CHANGES

          People

          • Assignee:
            yongjun Yongjun Park
            Reporter:
            yongjun Yongjun Park
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development