Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      Our nulls first syntax does not follow the sql standard. We need to change it.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/856

        TAJO-1970: Change the null first syntax

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1970

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/856.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #856


        commit 2529d0d96a8adda04609c5a39ea5a728f4485bbd
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-11-09T04:49:42Z

        Change syntax


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/856 TAJO-1970 : Change the null first syntax You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/856.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #856 commit 2529d0d96a8adda04609c5a39ea5a728f4485bbd Author: Jihoon Son <jihoonson@apache.org> Date: 2015-11-09T04:49:42Z Change syntax
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/856#issuecomment-155005993

        +1

        LGTM! I found that the patch ran successfully on my local cluster.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/856#issuecomment-155005993 +1 LGTM! I found that the patch ran successfully on my local cluster.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/856#issuecomment-155017176

        @blrunner, thank you for quick review!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/856#issuecomment-155017176 @blrunner, thank you for quick review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/856

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/856
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #586 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/586/)
        TAJO-1970: Change the null first syntax. (jihoonson: rev e84df9ccb1d5e30a08de136efd6f5842b2555a16)

        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window6.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiAttrs.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window8.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnExpression.sql
        • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
        • tajo-docs/src/main/sphinx/sql_language/queries.rst
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateIndex.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestIndexScan.java
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window9.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnLocation.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiExprs.sql
        • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndex.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window7.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window5.sql
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #586 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/586/ ) TAJO-1970 : Change the null first syntax. (jihoonson: rev e84df9ccb1d5e30a08de136efd6f5842b2555a16) tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window6.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiAttrs.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window8.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnExpression.sql tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 tajo-core-tests/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java tajo-docs/src/main/sphinx/sql_language/queries.rst tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateIndex.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestIndexScan.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window9.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnLocation.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiExprs.sql tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4 CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndex.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window7.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window5.sql tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.11.1.

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.11.1.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #968 (See https://builds.apache.org/job/Tajo-master-build/968/)
        TAJO-1970: Change the null first syntax. (jihoonson: rev e84df9ccb1d5e30a08de136efd6f5842b2555a16)

        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiAttrs.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window8.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window5.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnExpression.sql
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiExprs.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window6.sql
        • CHANGES
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window9.sql
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window7.sql
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndex.sql
        • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestIndexScan.java
        • tajo-docs/src/main/sphinx/sql_language/queries.rst
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java
        • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateIndex.java
        • tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnLocation.sql
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #968 (See https://builds.apache.org/job/Tajo-master-build/968/ ) TAJO-1970 : Change the null first syntax. (jihoonson: rev e84df9ccb1d5e30a08de136efd6f5842b2555a16) tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiAttrs.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window8.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window5.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnExpression.sql tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnMultiExprs.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window6.sql CHANGES tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window9.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/window7.sql tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndex.sql tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestIndexScan.java tajo-docs/src/main/sphinx/sql_language/queries.rst tajo-core-tests/src/test/java/org/apache/tajo/cli/tools/TestTajoDump.java tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4 tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateIndex.java tajo-core-tests/src/test/resources/queries/TestCreateIndex/testCreateIndexOnLocation.sql tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development