Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1939

Implement PgSQLTablespace::getTableVolume() method

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: JDBC Storage
    • Labels:
      None

      Description

      Table volume has an important role in query planning. Tajo's query optimizer makes many decisions based on table volume, because it is currently the only available statistics.

      However, PgSQLTablespace doesn't support getTableVolume() method, so our plan is not good when the query involves any pgsql tables.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1085 (See https://builds.apache.org/job/Tajo-master-build/1085/)
        TAJO-1939: Implement PgSQLTablespace::getTableVolume() method. (jihoonson: rev d73f129b4b2de5d753697f697c927b743db695fa)

        • tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLJdbcTableSpace.java
        • tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLQueryTests.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • tajo-storage/tajo-storage-pgsql/src/main/java/org/apache/tajo/storage/pgsql/PgSQLTablespace.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1085 (See https://builds.apache.org/job/Tajo-master-build/1085/ ) TAJO-1939 : Implement PgSQLTablespace::getTableVolume() method. (jihoonson: rev d73f129b4b2de5d753697f697c927b743db695fa) tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLJdbcTableSpace.java tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLQueryTests.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java tajo-storage/tajo-storage-pgsql/src/main/java/org/apache/tajo/storage/pgsql/PgSQLTablespace.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #679 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/679/)
        TAJO-1939: Implement PgSQLTablespace::getTableVolume() method. (jihoonson: rev d73f129b4b2de5d753697f697c927b743db695fa)

        • tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLQueryTests.java
        • tajo-storage/tajo-storage-pgsql/src/main/java/org/apache/tajo/storage/pgsql/PgSQLTablespace.java
        • tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLJdbcTableSpace.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #679 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/679/ ) TAJO-1939 : Implement PgSQLTablespace::getTableVolume() method. (jihoonson: rev d73f129b4b2de5d753697f697c927b743db695fa) tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLQueryTests.java tajo-storage/tajo-storage-pgsql/src/main/java/org/apache/tajo/storage/pgsql/PgSQLTablespace.java tajo-storage/tajo-storage-pgsql/src/test/java/org/apache/tajo/storage/pgsql/TestPgSQLJdbcTableSpace.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/960

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/960
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/960#issuecomment-184082970

        +1 LGTM
        test failure is not related this

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/960#issuecomment-184082970 +1 LGTM test failure is not related this
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/960

        TAJO-1939: Implement PgSQLTablespace::getTableVolume() method

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1939

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/960.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #960


        commit a6a6ee37c19e232ccae34821a600fd2c77aee95e
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2016-02-12T03:01:43Z

        Implement getTableVolumn() method


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/960 TAJO-1939 : Implement PgSQLTablespace::getTableVolume() method You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1939 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/960.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #960 commit a6a6ee37c19e232ccae34821a600fd2c77aee95e Author: Jihoon Son <jihoonson@apache.org> Date: 2016-02-12T03:01:43Z Implement getTableVolumn() method

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development