Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1858

Aligning error message in execute query page of web UI is needed.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: Web UI
    • Labels:
      None

      Description

      See this pic.

      Understanding of not only error syntax but also other error message is hard because of not aligned error message printed in web UI.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user combineads opened a pull request:

        https://github.com/apache/tajo/pull/919

        TAJO-1858: Aligning error message in execute query page of web UI is needed.

        Fixed using <pre> tag.
        ![screenshot from 2015-12-22 13 18 03](https://cloud.githubusercontent.com/assets/3220939/11947825/ac20ae90-a8af-11e5-8deb-9a5ca8429aac.png)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/combineads/tajo TAJO-1858

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/919.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #919


        commit d3ffcabb44539427532da20678c788e867098800
        Author: Byunghwa Yun <combine@combineads.co.kr>
        Date: 2015-12-16T05:26:27Z

        Remove unused import class

        commit 31637c41cdcebbccc5854de8a131e5cd86f1c4a3
        Author: combineads <combine@combineads.co.kr>
        Date: 2015-12-16T05:57:01Z

        Merge remote-tracking branch 'upstream/master'

        commit 463dd93c0dcc0b5f022308ad2adc3da7068c4441
        Author: combineads <combine@combineads.co.kr>
        Date: 2015-12-18T02:35:32Z

        Merge remote-tracking branch 'upstream/master'

        commit f51da8eb507c3ca5745f3afd73c496a28dd7b107
        Author: Byunghwa Yun <combine@combineads.co.kr>
        Date: 2015-12-22T03:49:09Z

        TAJO-1921: Hbase Storage can cause NPE when the hbase cluster is
        restarted

        commit 9581eccbba7017e545a6f9abfa10698463f9d484
        Author: Byunghwa Yun <combine@combineads.co.kr>
        Date: 2015-12-22T04:25:55Z

        TAJO-1858: Aligning error message in execute query page of web UI is
        needed.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user combineads opened a pull request: https://github.com/apache/tajo/pull/919 TAJO-1858 : Aligning error message in execute query page of web UI is needed. Fixed using <pre> tag. ! [screenshot from 2015-12-22 13 18 03] ( https://cloud.githubusercontent.com/assets/3220939/11947825/ac20ae90-a8af-11e5-8deb-9a5ca8429aac.png ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/combineads/tajo TAJO-1858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/919.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #919 commit d3ffcabb44539427532da20678c788e867098800 Author: Byunghwa Yun <combine@combineads.co.kr> Date: 2015-12-16T05:26:27Z Remove unused import class commit 31637c41cdcebbccc5854de8a131e5cd86f1c4a3 Author: combineads <combine@combineads.co.kr> Date: 2015-12-16T05:57:01Z Merge remote-tracking branch 'upstream/master' commit 463dd93c0dcc0b5f022308ad2adc3da7068c4441 Author: combineads <combine@combineads.co.kr> Date: 2015-12-18T02:35:32Z Merge remote-tracking branch 'upstream/master' commit f51da8eb507c3ca5745f3afd73c496a28dd7b107 Author: Byunghwa Yun <combine@combineads.co.kr> Date: 2015-12-22T03:49:09Z TAJO-1921 : Hbase Storage can cause NPE when the hbase cluster is restarted commit 9581eccbba7017e545a6f9abfa10698463f9d484 Author: Byunghwa Yun <combine@combineads.co.kr> Date: 2015-12-22T04:25:55Z TAJO-1858 : Aligning error message in execute query page of web UI is needed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/919#issuecomment-166876440

        Hi @combineads, thanks for your patch. This patch contains the changes of other issue. Would you remove it?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/919#issuecomment-166876440 Hi @combineads, thanks for your patch. This patch contains the changes of other issue. Would you remove it?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user combineads commented on the pull request:

        https://github.com/apache/tajo/pull/919#issuecomment-166916248

        Thank you for response.

        Show
        githubbot ASF GitHub Bot added a comment - Github user combineads commented on the pull request: https://github.com/apache/tajo/pull/919#issuecomment-166916248 Thank you for response.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user combineads closed the pull request at:

        https://github.com/apache/tajo/pull/919

        Show
        githubbot ASF GitHub Bot added a comment - Github user combineads closed the pull request at: https://github.com/apache/tajo/pull/919
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/919#issuecomment-166934810

        @combineads, it seems that there are some misunderstanding between us. I mean, this patch includes some changes of TAJO-1858, so you need to remove those changes.
        This issue makes sense, so I'd like to help you to finish your work. If you still want to contribute this patch to Tajo, would you open this PR again or make a new one?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/919#issuecomment-166934810 @combineads, it seems that there are some misunderstanding between us. I mean, this patch includes some changes of TAJO-1858 , so you need to remove those changes. This issue makes sense, so I'd like to help you to finish your work. If you still want to contribute this patch to Tajo, would you open this PR again or make a new one?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user combineads opened a pull request:

        https://github.com/apache/tajo/pull/921

        TAJO-1858: Aligning error message in execute query page of web UI is needed.

        Fixed using pre tag.
        ![screenshot from 2015-12-22 13 18 03](https://cloud.githubusercontent.com/assets/3220939/11947825/ac20ae90-a8af-11e5-8deb-9a5ca8429aac.png)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/combineads/tajo TAJO-1858

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/921.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #921


        commit 0a850cd4122ebe10a01ecb52c108d8681155c119
        Author: Byunghwa Yun <combine@combineads.co.kr>
        Date: 2015-12-24T01:17:13Z

        TAJO-1858: Aligning error message in execute query page of web UI is
        needed.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user combineads opened a pull request: https://github.com/apache/tajo/pull/921 TAJO-1858 : Aligning error message in execute query page of web UI is needed. Fixed using pre tag. ! [screenshot from 2015-12-22 13 18 03] ( https://cloud.githubusercontent.com/assets/3220939/11947825/ac20ae90-a8af-11e5-8deb-9a5ca8429aac.png ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/combineads/tajo TAJO-1858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/921.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #921 commit 0a850cd4122ebe10a01ecb52c108d8681155c119 Author: Byunghwa Yun <combine@combineads.co.kr> Date: 2015-12-24T01:17:13Z TAJO-1858 : Aligning error message in execute query page of web UI is needed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user combineads commented on the pull request:

        https://github.com/apache/tajo/pull/921#issuecomment-167019630

        Hi @jihoonson , sorry for my misunderstanding.
        I've clean up the files.

        Show
        githubbot ASF GitHub Bot added a comment - Github user combineads commented on the pull request: https://github.com/apache/tajo/pull/921#issuecomment-167019630 Hi @jihoonson , sorry for my misunderstanding. I've clean up the files.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/921#issuecomment-167050945

        +1. Even though test is failed, but it is not related to this patch.
        I'll commit shortly.
        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/921#issuecomment-167050945 +1. Even though test is failed, but it is not related to this patch. I'll commit shortly. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/921

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/921
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #639 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/639/)
        TAJO-1858: Aligning error message in execute query page of web UI is (jihoonson: rev e8ee7f2bf4d7cd3145626ab1383c9c53c566222b)

        • CHANGES
        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #639 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/639/ ) TAJO-1858 : Aligning error message in execute query page of web UI is (jihoonson: rev e8ee7f2bf4d7cd3145626ab1383c9c53c566222b) CHANGES tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.11.1 branches.
        Thanks!

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.11.1 branches. Thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1036 (See https://builds.apache.org/job/Tajo-master-build/1036/)
        TAJO-1858: Aligning error message in execute query page of web UI is (jihoonson: rev e8ee7f2bf4d7cd3145626ab1383c9c53c566222b)

        • CHANGES
        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1036 (See https://builds.apache.org/job/Tajo-master-build/1036/ ) TAJO-1858 : Aligning error message in execute query page of web UI is (jihoonson: rev e8ee7f2bf4d7cd3145626ab1383c9c53c566222b) CHANGES tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.1-build #139 (See https://builds.apache.org/job/Tajo-0.11.1-build/139/)
        TAJO-1858: Aligning error message in execute query page of web UI is (jihoonson: rev 8ddefef858746501c4c2bf3dfc61484a2f38b658)

        • tajo-core/src/main/resources/webapps/admin/query_executor.jsp
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.1-build #139 (See https://builds.apache.org/job/Tajo-0.11.1-build/139/ ) TAJO-1858 : Aligning error message in execute query page of web UI is (jihoonson: rev 8ddefef858746501c4c2bf3dfc61484a2f38b658) tajo-core/src/main/resources/webapps/admin/query_executor.jsp CHANGES

          People

          • Assignee:
            combine Byunghwa Yun
            Reporter:
            dkhwangbo Dongkyu Hwangbo
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development