Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      See the title. We need to add tablespace syntax to CREATE TABLE description.

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #50 (See https://builds.apache.org/job/Tajo-0.11.0-build/50/)
        TAJO-1853: Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev a39355a65143eb518c7ebad76e2b8d3a1405d17f)

        • tajo-docs/src/main/sphinx/table_management/table_overview.rst
        • CHANGES
        • tajo-docs/src/main/sphinx/sql_language/ddl.rst
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #50 (See https://builds.apache.org/job/Tajo-0.11.0-build/50/ ) TAJO-1853 : Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev a39355a65143eb518c7ebad76e2b8d3a1405d17f) tajo-docs/src/main/sphinx/table_management/table_overview.rst CHANGES tajo-docs/src/main/sphinx/sql_language/ddl.rst
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #873 (See https://builds.apache.org/job/Tajo-master-build/873/)
        TAJO-1853: Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev 78fee98db2c989135a75d88e138f17228aa2fb14)

        • CHANGES
        • tajo-docs/src/main/sphinx/table_management/table_overview.rst
        • tajo-docs/src/main/sphinx/sql_language/ddl.rst
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #873 (See https://builds.apache.org/job/Tajo-master-build/873/ ) TAJO-1853 : Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev 78fee98db2c989135a75d88e138f17228aa2fb14) CHANGES tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-docs/src/main/sphinx/sql_language/ddl.rst
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #515 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/515/)
        TAJO-1853: Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev 78fee98db2c989135a75d88e138f17228aa2fb14)

        • tajo-docs/src/main/sphinx/sql_language/ddl.rst
        • CHANGES
        • tajo-docs/src/main/sphinx/table_management/table_overview.rst
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #515 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/515/ ) TAJO-1853 : Add tablespace syntax to the CREATE TABLE section of DDL page. (jihoonson: rev 78fee98db2c989135a75d88e138f17228aa2fb14) tajo-docs/src/main/sphinx/sql_language/ddl.rst CHANGES tajo-docs/src/main/sphinx/table_management/table_overview.rst
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.11.

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.11.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/762

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/762
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/762#issuecomment-140959318

        Thank you for the comment.
        I'll reflect it and commit soon.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/762#issuecomment-140959318 Thank you for the comment. I'll reflect it and commit soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/762#issuecomment-140766923

        +1 Ship it. I leaved one trivial comment.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/762#issuecomment-140766923 +1 Ship it. I leaved one trivial comment.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/762#discussion_r39640120

        — Diff: tajo-docs/src/main/sphinx/sql_language/ddl.rst —
        @@ -34,12 +37,18 @@ CREATE TABLE

        .. code-block:: sql

        • CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )]
          + CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )] [TABLESPACE tablespace_name]
          [using <storage_type> [with (<key> = <value>, ...)]] [AS <select_statement>]

        CREATE EXTERNAL TABLE [IF NOT EXISTS] <table_name> (<column_name> <data_type>, ... )
        using <storage_type> [with (<key> = <value>, ...)] LOCATION '<path>'

        +Description
        +
        +In Tajo, there are two types of tables, `managed table` and `external table` (For more information, please refer to :doc:`/table_management/table_overview`.)
        +
        +Managed tables are placed on some predefined tablespaces. The ``TABLESPACE`` clause is to specify a tablespace for this table. For more information about tablespace, please refer to :doc:`/table_management/tablespaces`. For external tables, Tajo allows arbitrary table location with the ``LOCATION`` clause.
        — End diff –

        ``arbitrary table`` should be ``an arbitrary``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/762#discussion_r39640120 — Diff: tajo-docs/src/main/sphinx/sql_language/ddl.rst — @@ -34,12 +37,18 @@ CREATE TABLE .. code-block:: sql CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )] + CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )] [TABLESPACE tablespace_name] [using <storage_type> [with (<key> = <value>, ...)] ] [AS <select_statement>] CREATE EXTERNAL TABLE [IF NOT EXISTS] <table_name> (<column_name> <data_type>, ... ) using <storage_type> [with (<key> = <value>, ...)] LOCATION '<path>' + Description + +In Tajo, there are two types of tables, `managed table` and `external table` (For more information, please refer to :doc:`/table_management/table_overview`.) + +Managed tables are placed on some predefined tablespaces. The ``TABLESPACE`` clause is to specify a tablespace for this table. For more information about tablespace, please refer to :doc:`/table_management/tablespaces`. For external tables, Tajo allows arbitrary table location with the ``LOCATION`` clause. — End diff – ``arbitrary table`` should be ``an arbitrary``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/762

        TAJO-1853: Add tablespace syntax to the CREATE TABLE section of DDL page

        I've also added some descriptions to other sections.
        You can see at http://people.apache.org/~jihoonson/tajo-doc/sql_language/ddl.html.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1853

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/762.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #762


        commit 34c7948e8eb470fb557c40ff470142571160d1c8
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-09-16T07:12:04Z

        TAJO-1853


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/762 TAJO-1853 : Add tablespace syntax to the CREATE TABLE section of DDL page I've also added some descriptions to other sections. You can see at http://people.apache.org/~jihoonson/tajo-doc/sql_language/ddl.html . You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1853 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/762.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #762 commit 34c7948e8eb470fb557c40ff470142571160d1c8 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-09-16T07:12:04Z TAJO-1853

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development