Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1848

ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      If serviceInit() is failed, ShutdownHook in TajoMaster can throw NPE.

      // If embedded derby is used as catalog, shutdown it.
              if (catalogServer.getStoreClassName().equals("org.apache.tajo.catalog.store.DerbyStore")
                  && AbstractDBStore.needShutdown(catalogServer.getStoreUri())) {
                DerbyStore.shutdown();
              }
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/759

        TAJO-1848: ShutdownHook in TajoMaster can throw NPE if serviceInit() …

        …is failed.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1848

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/759.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #759


        commit 59fe6784187a5940622c52f537844f235d1c5b61
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-14T21:12:32Z

        TAJO-1848: ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/759 TAJO-1848 : ShutdownHook in TajoMaster can throw NPE if serviceInit() … …is failed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/759.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #759 commit 59fe6784187a5940622c52f537844f235d1c5b61 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-14T21:12:32Z TAJO-1848 : ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/759#issuecomment-140244271

        +1

        Ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/759#issuecomment-140244271 +1 Ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/759

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/759
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #508 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/508/)
        TAJO-1848: ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 59fe6784187a5940622c52f537844f235d1c5b61)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #508 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/508/ ) TAJO-1848 : ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 59fe6784187a5940622c52f537844f235d1c5b61) tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #867 (See https://builds.apache.org/job/Tajo-master-build/867/)
        TAJO-1848: ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 59fe6784187a5940622c52f537844f235d1c5b61)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #867 (See https://builds.apache.org/job/Tajo-master-build/867/ ) TAJO-1848 : ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 59fe6784187a5940622c52f537844f235d1c5b61) tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #44 (See https://builds.apache.org/job/Tajo-0.11.0-build/44/)
        TAJO-1848: ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 9db963d121225611da03300a42ee49a6a427e5c0)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #44 (See https://builds.apache.org/job/Tajo-0.11.0-build/44/ ) TAJO-1848 : ShutdownHook in TajoMaster can throw NPE if serviceInit() is failed. (hyunsik: rev 9db963d121225611da03300a42ee49a6a427e5c0) tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        I already committed this patch.

        Show
        hyunsik Hyunsik Choi added a comment - I already committed this patch.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development