Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1829

Fix DelimitedTextFileAppender NPE in negative tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0, 0.12.0
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: Storage
    • Labels:
      None

      Description

      If initialization is failed, DelimitedTextFileAppender should check null condition

      org.apache.tajo.storage.exception.AlreadyExistsStorageException: Error: hdfs://localhost:46021/tmp/tajo-travis/staging/q_1441719763556_0020/RESULT/part-01-000000-000 alreay exists
      	at org.apache.tajo.storage.text.DelimitedTextFile$DelimitedTextFileAppender.init(DelimitedTextFile.java:160)
      	at org.apache.tajo.engine.planner.physical.StoreTableExec.openNewFile(StoreTableExec.java:119)
      	at org.apache.tajo.engine.planner.physical.StoreTableExec.init(StoreTableExec.java:79)
      	at org.apache.tajo.worker.TaskImpl.run(TaskImpl.java:401)
      	at org.apache.tajo.worker.TaskContainer.run(TaskContainer.java:65)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:745)
      2015-09-08 13:43:27,432 ERROR: org.apache.tajo.worker.TaskContainer (run(70)) - 
      java.lang.NullPointerException
      	at org.apache.tajo.storage.text.DelimitedTextFile$DelimitedTextFileAppender.flushBuffer(DelimitedTextFile.java:208)
      	at org.apache.tajo.storage.text.DelimitedTextFile$DelimitedTextFileAppender.flush(DelimitedTextFile.java:222)
      	at org.apache.tajo.engine.planner.physical.StoreTableExec.close(StoreTableExec.java:152)
      	at org.apache.tajo.worker.TaskImpl.run(TaskImpl.java:414)
      	at org.apache.tajo.worker.TaskContainer.run(TaskContainer.java:65)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:745)
      2015-09-08 13:43:27,433 ERROR: org.apache.tajo.querymaster.TaskAttempt (transition(438)) - ta_1441719763556_0020_000001_000000_02 FROM localhost >> No error message
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/747

        TAJO-1829: Fix DelimitedTextFileAppender NPE in negative tests.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1829

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/747.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #747


        commit 017c5c842747f1bb5ebc21635e44c343de06bd56
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-09-08T14:23:29Z

        TAJO-1829: Fix DelimitedTextFileAppender NPE in negative tests.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/747 TAJO-1829 : Fix DelimitedTextFileAppender NPE in negative tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1829 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/747.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #747 commit 017c5c842747f1bb5ebc21635e44c343de06bd56 Author: Jinho Kim <jhkim@apache.org> Date: 2015-09-08T14:23:29Z TAJO-1829 : Fix DelimitedTextFileAppender NPE in negative tests.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/747#issuecomment-138768625

        +1 The patch looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/747#issuecomment-138768625 +1 The patch looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/747

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/747
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #492 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/492/)
        TAJO-1829: Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 1cdd018d92f0400ffbfc09d07a1dfd18d9b13d87)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #492 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/492/ ) TAJO-1829 : Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 1cdd018d92f0400ffbfc09d07a1dfd18d9b13d87) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #850 (See https://builds.apache.org/job/Tajo-master-build/850/)
        TAJO-1829: Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 1cdd018d92f0400ffbfc09d07a1dfd18d9b13d87)

        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #850 (See https://builds.apache.org/job/Tajo-master-build/850/ ) TAJO-1829 : Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 1cdd018d92f0400ffbfc09d07a1dfd18d9b13d87) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #26 (See https://builds.apache.org/job/Tajo-0.11.0-build/26/)
        TAJO-1829: Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 5db0f7b0f1e65c0620472b27f0c91cf446334a0f)

        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #26 (See https://builds.apache.org/job/Tajo-0.11.0-build/26/ ) TAJO-1829 : Fix DelimitedTextFileAppender NPE in negative tests. (jhkim: rev 5db0f7b0f1e65c0620472b27f0c91cf446334a0f) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development