Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.1
    • Fix Version/s: 0.11.0
    • Component/s: Storage
    • Labels:
      None
    1. TAJO-1826.patch
      74 kB
      Jongyoung Park

      Activity

      Hide
      githubbot ASF GitHub Bot added a comment -

      GitHub user eminency opened a pull request:

      https://github.com/apache/tajo/pull/745

      TAJO-1826: Revert 'refining code for Parquet 1.8.1'

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/eminency/tajo TAJO-1826

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/tajo/pull/745.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #745


      commit c5d19ddd47cd88beb6f50750579979ff99129c3d
      Author: Jongyoung Park <eminency@gmail.com>
      Date: 2015-09-08T06:08:42Z

      Revert "TAJO-1718: Refine code for Parquet 1.8.1."

      This reverts commit 18b898ffbab0462ae26c0cf374b119dcee5f1c6f.

      commit 7049d7a62e89238c0839d884667d81d9ed930c10
      Author: Jongyoung Park <eminency@gmail.com>
      Date: 2015-09-08T06:54:32Z

      Merge branch 'master' into TAJO-1796

      • master:
        TAJO-1819: Cannot find existing tables when pgsql catalog starts up.

      Show
      githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/745 TAJO-1826 : Revert 'refining code for Parquet 1.8.1' You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1826 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/745.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #745 commit c5d19ddd47cd88beb6f50750579979ff99129c3d Author: Jongyoung Park <eminency@gmail.com> Date: 2015-09-08T06:08:42Z Revert " TAJO-1718 : Refine code for Parquet 1.8.1." This reverts commit 18b898ffbab0462ae26c0cf374b119dcee5f1c6f. commit 7049d7a62e89238c0839d884667d81d9ed930c10 Author: Jongyoung Park <eminency@gmail.com> Date: 2015-09-08T06:54:32Z Merge branch 'master' into TAJO-1796 master: TAJO-1819 : Cannot find existing tables when pgsql catalog starts up.
      Hide
      tajoqa Tajo QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12754586/TAJO-1826.patch
      against master revision release-0.9.0-rc0-455-gb3a65b5.

      -1 @author. The patch appears to contain 3 @author tags which the Tajo community has agreed to not allow in code contributions.

      +1 tests included. The patch appears to include 1 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

      +1 checkstyle. The patch generated 0 code style errors.

      -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-hdfs.

      Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/863//testReport/
      Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/863//findbugsResult
      Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/863//console

      This message is automatically generated.

      Show
      tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12754586/TAJO-1826.patch against master revision release-0.9.0-rc0-455-gb3a65b5. -1 @author. The patch appears to contain 3 @author tags which the Tajo community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/863//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/863//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/863//console This message is automatically generated.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user hyunsik commented on the pull request:

      https://github.com/apache/tajo/pull/745#issuecomment-138856678

      +1

      Show
      githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/745#issuecomment-138856678 +1
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Tajo-master-CODEGEN-build #495 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/495/)
      TAJO-1826: Revert "refine code for Parquet 1.8.1." (hyunsik: rev bd90521eff872355b20cc8e2da7bd23d459a2623)

      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java
      • tajo-storage/tajo-storage-hdfs/pom.xml
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java
      • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
      • CHANGES
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #495 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/495/ ) TAJO-1826 : Revert "refine code for Parquet 1.8.1." (hyunsik: rev bd90521eff872355b20cc8e2da7bd23d459a2623) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java tajo-storage/tajo-storage-hdfs/pom.xml tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java
      Hide
      hyunsik Hyunsik Choi added a comment -

      I just committed the patch to master and branch-0.11.0. Thank you for your contribution.

      Show
      hyunsik Hyunsik Choi added a comment - I just committed the patch to master and branch-0.11.0. Thank you for your contribution.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Tajo-master-build #852 (See https://builds.apache.org/job/Tajo-master-build/852/)
      TAJO-1826: Revert "refine code for Parquet 1.8.1." (hyunsik: rev bd90521eff872355b20cc8e2da7bd23d459a2623)

      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java
      • tajo-storage/tajo-storage-hdfs/pom.xml
      • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java
      • CHANGES
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #852 (See https://builds.apache.org/job/Tajo-master-build/852/ ) TAJO-1826 : Revert "refine code for Parquet 1.8.1." (hyunsik: rev bd90521eff872355b20cc8e2da7bd23d459a2623) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java tajo-storage/tajo-storage-hdfs/pom.xml tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Tajo-0.11.0-build #29 (See https://builds.apache.org/job/Tajo-0.11.0-build/29/)
      TAJO-1826: Revert "refine code for Parquet 1.8.1." (hyunsik: rev 5e5c1af080090bc65d937d3608546fe2b991a1b7)

      • CHANGES
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java
      • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java
      • tajo-storage/tajo-storage-hdfs/pom.xml
      • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #29 (See https://builds.apache.org/job/Tajo-0.11.0-build/29/ ) TAJO-1826 : Revert "refine code for Parquet 1.8.1." (hyunsik: rev 5e5c1af080090bc65d937d3608546fe2b991a1b7) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/CodecFactory.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoWriteSupport.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/parquet/TestSchemaConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoParquetWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoSchemaConverter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetReader.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ColumnChunkPageWriteStore.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetFileWriter.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java tajo-storage/tajo-storage-hdfs/pom.xml tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoReadSupport.java
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user hyunsik commented on the pull request:

      https://github.com/apache/tajo/pull/745#issuecomment-138916011

      @eminency Could you close this ticket? It was already committed at https://github.com/apache/tajo/commit/bd90521eff872355b20cc8e2da7bd23d459a2623. But, I missed the command to close this ticket.

      Show
      githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/745#issuecomment-138916011 @eminency Could you close this ticket? It was already committed at https://github.com/apache/tajo/commit/bd90521eff872355b20cc8e2da7bd23d459a2623 . But, I missed the command to close this ticket.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user eminency commented on the pull request:

      https://github.com/apache/tajo/pull/745#issuecomment-139089026

      Sure, thanks

      Show
      githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/745#issuecomment-139089026 Sure, thanks
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user eminency closed the pull request at:

      https://github.com/apache/tajo/pull/745

      Show
      githubbot ASF GitHub Bot added a comment - Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/745

        People

        • Assignee:
          eminency Jongyoung Park
          Reporter:
          eminency Jongyoung Park
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development