Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1820

Fix wrong case sensitivity rules of non-reserved keywords

    Details

      Description

      For example, in the following DDL statements, default database name is recognized as DEFAULT instead of default.

      CREATE TABLE DEFAULT.TABLE1 (xxx INT, ...
      

      The main reason is default is non-reserved keywords. So, it is not passed through the same case sensitive handling code. So, we should fix it.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #840 (See https://builds.apache.org/job/Tajo-master-build/840/)
        TAJO-1820: Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev c0e193d71ba3bf478d352b0a341d12ac6c8ac1d2)

        • CHANGES
        • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql
        • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #840 (See https://builds.apache.org/job/Tajo-master-build/840/ ) TAJO-1820 : Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev c0e193d71ba3bf478d352b0a341d12ac6c8ac1d2) CHANGES tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.0-build #18 (See https://builds.apache.org/job/Tajo-0.11.0-build/18/)
        TAJO-1820: Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev fa45333459099792586597643773dbd386c76d48)

        • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql
        • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.0-build #18 (See https://builds.apache.org/job/Tajo-0.11.0-build/18/ ) TAJO-1820 : Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev fa45333459099792586597643773dbd386c76d48) tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #483 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/483/)
        TAJO-1820: Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev c0e193d71ba3bf478d352b0a341d12ac6c8ac1d2)

        • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
        • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #483 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/483/ ) TAJO-1820 : Fix wrong case sensitivity rules of non-reserved keywords. (hyunsik: rev c0e193d71ba3bf478d352b0a341d12ac6c8ac1d2) tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/case_sensitivity1.sql CHANGES tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/case_sensitivity1.result
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/741

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/741
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/741#issuecomment-138273836

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/741#issuecomment-138273836 +1 ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/741

        TAJO-1820: Fix wrong case sensitivity rules of non-reserved keywords.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1820

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/741.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #741


        commit c092bec961048a1884782772c323d8440382c8df
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-07T10:16:59Z

        TAJO-1820: Fix wrong case sensitivity rules of non-reserved keywords.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/741 TAJO-1820 : Fix wrong case sensitivity rules of non-reserved keywords. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1820 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/741.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #741 commit c092bec961048a1884782772c323d8440382c8df Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-07T10:16:59Z TAJO-1820 : Fix wrong case sensitivity rules of non-reserved keywords.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development