Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, SQL parser does not show meaningful error messages to help users find SQL syntax problem. The main object of issue is to improve the error message. For example, tsql will show the exact line and column and the error part of SQL statements. Also, it will give some hints about how to fix them.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.11.0-build #37 (See https://builds.apache.org/job/Tajo-0.11.0-build/37/)
          TAJO-1817: Improve SQL parser error message. (hyunsik: rev 24159a270427ee03e2571c952be0b609b7b7d81d)

          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java
          • tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java
          • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
          • tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
          • CHANGES
          • tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java
          • tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #37 (See https://builds.apache.org/job/Tajo-0.11.0-build/37/ ) TAJO-1817 : Improve SQL parser error message. (hyunsik: rev 24159a270427ee03e2571c952be0b609b7b7d81d) tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #860 (See https://builds.apache.org/job/Tajo-master-build/860/)
          TAJO-1817: Improve SQL parser error message. (hyunsik: rev cc6917804a090c277ffe3ad876c59f3f489d9df1)

          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java
          • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql
          • tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java
          • tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result
          • tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java
          • tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #860 (See https://builds.apache.org/job/Tajo-master-build/860/ ) TAJO-1817 : Improve SQL parser error message. (hyunsik: rev cc6917804a090c277ffe3ad876c59f3f489d9df1) tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 CHANGES tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #501 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/501/)
          TAJO-1817: Improve SQL parser error message. (hyunsik: rev cc6917804a090c277ffe3ad876c59f3f489d9df1)

          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result
          • CHANGES
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result
          • tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java
          • tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql
          • tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
          • tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql
          • tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result
          • tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java
          • tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
          • tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #501 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/501/ ) TAJO-1817 : Improve SQL parser error message. (hyunsik: rev cc6917804a090c277ffe3ad876c59f3f489d9df1) tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/identifier1.sql tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLParseError.java tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/join_1.result CHANGES tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/identifier1.result tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorStrategy.java tajo-jdbc/src/test/java/org/apache/tajo/jdbc/TestTajoJdbcNegative.java tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLErrorListener.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/in_subquery_1.sql tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java tajo-core-tests/src/test/resources/queries/TestSQLAnalyzer/errors/join_1.sql tajo-core-tests/src/test/resources/results/TestSQLAnalyzer/errors/in_subquery_1.result tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java tajo-core-tests/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result tajo-core-tests/src/test/java/org/apache/tajo/parser/sql/TestSQLAnalyzer.java
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed

          Show
          hyunsik Hyunsik Choi added a comment - committed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/753

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/753
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/753#issuecomment-139449103

          +1 LGTM!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/753#issuecomment-139449103 +1 LGTM!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/753#issuecomment-139216352

          It is ready to review.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/753#issuecomment-139216352 It is ready to review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/753

          TAJO-1817: Improve SQL parser error message.

          This is still on-going work. I'll let you guys know when this patch becomes ready to be reviewed.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1817

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/753.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #753


          commit 2f7fce3733996738d88dc499027aaaf78781bd71
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-09-10T09:11:22Z

          TAJO-1817: Improve SQL parser error message.

          commit 3cde17a6e59614db468e444c54c3b8a4287899f5
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-09-10T09:12:32Z

          Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1817


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/753 TAJO-1817 : Improve SQL parser error message. This is still on-going work. I'll let you guys know when this patch becomes ready to be reviewed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1817 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/753.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #753 commit 2f7fce3733996738d88dc499027aaaf78781bd71 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-10T09:11:22Z TAJO-1817 : Improve SQL parser error message. commit 3cde17a6e59614db468e444c54c3b8a4287899f5 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-10T09:12:32Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1817

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development