Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1812

Timezone support in JSON file format

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: Storage
    • Labels:
      None

      Description

      Currently, Json file format does not support timezone. We need to support it.

      1. TAJO-1812.patch
        20 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #9 (See https://builds.apache.org/job/Tajo-0.11.0-build/9/)
        TAJO-1812: Timezone support in JSON file format. (hyunsik: rev ad7ce1e90eea62c85d9ad546e2ebf1a1c6964f35)

        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result
        • CHANGES
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java
        • tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql
        • tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #9 (See https://builds.apache.org/job/Tajo-0.11.0-build/9/ ) TAJO-1812 : Timezone support in JSON file format. (hyunsik: rev ad7ce1e90eea62c85d9ad546e2ebf1a1c6964f35) tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result CHANGES tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #829 (See https://builds.apache.org/job/Tajo-master-build/829/)
        TAJO-1812: Timezone support in JSON file format. (hyunsik: rev 3e8f4a0307cb857434e8a0c6415e39453f97cabe)

        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result
        • tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result
        • CHANGES
        • tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #829 (See https://builds.apache.org/job/Tajo-master-build/829/ ) TAJO-1812 : Timezone support in JSON file format. (hyunsik: rev 3e8f4a0307cb857434e8a0c6415e39453f97cabe) tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result CHANGES tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #473 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/473/)
        TAJO-1812: Timezone support in JSON file format. (hyunsik: rev 3e8f4a0307cb857434e8a0c6415e39453f97cabe)

        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result
        • CHANGES
        • tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql
        • tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java
        • tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql
        • tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #473 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/473/ ) TAJO-1812 : Timezone support in JSON file format. (hyunsik: rev 3e8f4a0307cb857434e8a0c6415e39453f97cabe) tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable2.result tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl2.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable4.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable2.sql tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable1.result tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_ddl.sql tajo-core-tests/src/test/resources/results/TestJsonWithTimezone/testTimezonedTable3.result CHANGES tajo-core-tests/src/test/resources/dataset/TestJsonWithTimezone/timezoned/TestJsonWithTimezone.json tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-core-tests/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/datetime_table_timezoned_ddl.sql tajo-core-tests/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestJsonWithTimezone.java tajo-core-tests/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable1.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable3.sql tajo-core-tests/src/test/resources/queries/TestJsonWithTimezone/testTimezonedTable5.sql
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed this patch to master and 0.11.0 branch. Thank you for the quick review.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed this patch to master and 0.11.0 branch. Thank you for the quick review.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/723

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/723
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/723#issuecomment-137423678

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/723#issuecomment-137423678 +1 LGTM!
        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/723#issuecomment-137411916 Its unit test has bee passed. https://issues.apache.org/jira/browse/TAJO-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728822#comment-14728822
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12753948/TAJO-1812.patch
        against master revision release-0.9.0-rc0-437-g22ab1cf.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 19 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core-tests tajo-storage/tajo-storage-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/844//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/844//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/844//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12753948/TAJO-1812.patch against master revision release-0.9.0-rc0-437-g22ab1cf. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core-tests tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/844//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/844//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hdfs.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/844//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/723

        TAJO-1812: Timezone support in JSON file format.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1812

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/723.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #723


        commit e39d50be050a42b78865c65ef264d001a6bc6a4b
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-03T09:36:46Z

        TAJO-1812: Timezone support in JSON file format.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/723 TAJO-1812 : Timezone support in JSON file format. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1812 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #723 commit e39d50be050a42b78865c65ef264d001a6bc6a4b Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-03T09:36:46Z TAJO-1812 : Timezone support in JSON file format.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development