Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1803

Use in-memory derby as the default catalog for unit tests

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Unit Test
    • Labels:
      None

      Description

      We are currently using MemStore which is designed to provide the same interface with AbstractDBStore. This incurs two problems.

      • The major problem is that AbstractDBStore is not tested properly by unit testing. The logic to access catalog is separated into MemStore and AbstractDBStore, and only MemStore is tested.
      • We have to implement both AbstractDBStore and MemStore whenever we modify the catalog interface even though MemStore is used only in unit testing. This is an unnecessary burden to developers.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/714

        TAJO-1803: Use in-memory derby as the default catalog for unit tests

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1803

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/714.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #714


        commit 199f164101cbe1185dfcc9cae151bcfe4ab30b48
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-23T13:28:04Z

        testing

        commit a1c9a6b3761f8d834b7eda3c471cd473e977c081
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-26T01:38:06Z

        Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into mem_derby

        commit 6db115b00a01cf3cc93b54c3a4cd6a81e6a2decb
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-26T10:15:55Z

        success

        commit 7a2f4aba1c0d691d0737e897620c76109555d4a6
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-26T12:41:10Z

        Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into TAJO-1803

        commit f6d564889dcd0a79106f373945d6926ba843651d
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-26T14:46:32Z

        Replace MemStore with DerbyStore

        commit c29cd501837b28e437c1d93421e71f841b06e16c
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-27T09:46:17Z

        Enable external catalog

        commit c971249a3e5634cbd0168b61aacac208cdf697bf
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-28T10:07:01Z

        TAJO-1803

        commit 9da53d4719e32a73b60a376fcf755d15288c7628
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-28T13:27:43Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1803

        commit bd68897d98ca7c95fbcb9c3ad82a96ea88ef1357
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-08-29T02:01:59Z

        TAJO-1803


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/714 TAJO-1803 : Use in-memory derby as the default catalog for unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1803 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #714 commit 199f164101cbe1185dfcc9cae151bcfe4ab30b48 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-23T13:28:04Z testing commit a1c9a6b3761f8d834b7eda3c471cd473e977c081 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-26T01:38:06Z Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into mem_derby commit 6db115b00a01cf3cc93b54c3a4cd6a81e6a2decb Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-26T10:15:55Z success commit 7a2f4aba1c0d691d0737e897620c76109555d4a6 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-26T12:41:10Z Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into TAJO-1803 commit f6d564889dcd0a79106f373945d6926ba843651d Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-26T14:46:32Z Replace MemStore with DerbyStore commit c29cd501837b28e437c1d93421e71f841b06e16c Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-27T09:46:17Z Enable external catalog commit c971249a3e5634cbd0168b61aacac208cdf697bf Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-28T10:07:01Z TAJO-1803 commit 9da53d4719e32a73b60a376fcf755d15288c7628 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-28T13:27:43Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1803 commit bd68897d98ca7c95fbcb9c3ad82a96ea88ef1357 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-08-29T02:01:59Z TAJO-1803
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/714#issuecomment-135927842

        I've also fixed some bugs in catalog.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/714#issuecomment-135927842 I've also fixed some bugs in catalog.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/714#issuecomment-136646103

        This patch is ready for review.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/714#issuecomment-136646103 This patch is ready for review.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/714#discussion_r38401421

        — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java —
        @@ -26,9 +26,11 @@
        import org.apache.tajo.TajoConstants;
        import org.apache.tajo.TajoProtos.QueryState;
        import org.apache.tajo.TajoTestingCluster;
        +import org.apache.tajo.catalog.CatalogConstants;
        — End diff –

        unused imports

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/714#discussion_r38401421 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java — @@ -26,9 +26,11 @@ import org.apache.tajo.TajoConstants; import org.apache.tajo.TajoProtos.QueryState; import org.apache.tajo.TajoTestingCluster; +import org.apache.tajo.catalog.CatalogConstants; — End diff – unused imports
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/714#discussion_r38402086

        — Diff: tajo-common/src/main/proto/errors.proto —
        @@ -157,6 +157,9 @@ enum ResultCode {
        CAT_UPGRADE_REQUIRED = 901; // Migration
        CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server

        + // Catalog store
        + UNSUPPORTED_CATALOG_STORE = 905; // Unsupported type of catalog store
        — End diff –

        It seems to be necessary the prefix ``CAT``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/714#discussion_r38402086 — Diff: tajo-common/src/main/proto/errors.proto — @@ -157,6 +157,9 @@ enum ResultCode { CAT_UPGRADE_REQUIRED = 901; // Migration CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server + // Catalog store + UNSUPPORTED_CATALOG_STORE = 905; // Unsupported type of catalog store — End diff – It seems to be necessary the prefix ``CAT``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/714#issuecomment-136654549

        I used some trivial comments. You can commit the patch after you reflect them if you agree with my comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/714#issuecomment-136654549 I used some trivial comments. You can commit the patch after you reflect them if you agree with my comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/714#issuecomment-136656394

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/714#issuecomment-136656394 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/714#issuecomment-136656792

        Thanks for quick review!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/714#issuecomment-136656792 Thanks for quick review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #466 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/466/)
        TAJO-1803: Use in-memory derby as the default catalog for unit tests. (jihoonson: rev 77dc88c074646c2673d11b1c026b33ead2640d1b)

        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
        • tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-storage/tajo-storage-hdfs/pom.xml
        • tajo-jdbc/pom.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
        • tajo-core-tests/pom.xml
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-cluster-tests/pom.xml
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-common/src/main/proto/errors.proto
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-storage/tajo-storage-hbase/pom.xml
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java
        • tajo-catalog/tajo-catalog-server/pom.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-storage/tajo-storage-common/pom.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-core/pom.xml
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-project/pom.xml
        • tajo-metrics/src/main/proto/master_metrics.proto
        • tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #466 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/466/ ) TAJO-1803 : Use in-memory derby as the default catalog for unit tests. (jihoonson: rev 77dc88c074646c2673d11b1c026b33ead2640d1b) tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-storage/tajo-storage-hdfs/pom.xml tajo-jdbc/pom.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java tajo-core-tests/pom.xml tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-cluster-tests/pom.xml tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-common/src/main/proto/errors.proto tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-storage/tajo-storage-hbase/pom.xml tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java tajo-catalog/tajo-catalog-server/pom.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-storage/tajo-storage-common/pom.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/pom.xml tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-project/pom.xml tajo-metrics/src/main/proto/master_metrics.proto tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #820 (See https://builds.apache.org/job/Tajo-master-build/820/)
        TAJO-1803: Use in-memory derby as the default catalog for unit tests. (jihoonson: rev 77dc88c074646c2673d11b1c026b33ead2640d1b)

        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-core/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-storage/tajo-storage-common/pom.xml
        • tajo-core-tests/pom.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-metrics/src/main/proto/master_metrics.proto
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-catalog/tajo-catalog-server/pom.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java
        • tajo-jdbc/pom.xml
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-storage/tajo-storage-hbase/pom.xml
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml
        • tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java
        • tajo-project/pom.xml
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-common/src/main/proto/errors.proto
        • tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-storage/tajo-storage-hdfs/pom.xml
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-cluster-tests/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #820 (See https://builds.apache.org/job/Tajo-master-build/820/ ) TAJO-1803 : Use in-memory derby as the default catalog for unit tests. (jihoonson: rev 77dc88c074646c2673d11b1c026b33ead2640d1b) tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-core/pom.xml tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-storage/tajo-storage-common/pom.xml tajo-core-tests/pom.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-metrics/src/main/proto/master_metrics.proto tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-catalog/tajo-catalog-server/pom.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java tajo-jdbc/pom.xml tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-storage/tajo-storage-hbase/pom.xml tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java tajo-project/pom.xml tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-common/src/main/proto/errors.proto tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-storage/tajo-storage-hdfs/pom.xml CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-cluster-tests/pom.xml
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #2 (See https://builds.apache.org/job/Tajo-0.11.0-build/2/)
        TAJO-1803: Use in-memory derby as the default catalog for unit tests. (jihoonson: rev ad83927fa093bb78d83d070fb847c2bca1ceb9f3)

        • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-core-tests/pom.xml
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
        • tajo-storage/tajo-storage-hbase/pom.xml
        • tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-storage/tajo-storage-common/pom.xml
        • tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java
        • tajo-metrics/src/main/proto/master_metrics.proto
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-common/src/main/proto/errors.proto
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-storage/tajo-storage-hdfs/pom.xml
        • tajo-cluster-tests/pom.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-core/pom.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-catalog/tajo-catalog-server/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
        • tajo-project/pom.xml
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-jdbc/pom.xml
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #2 (See https://builds.apache.org/job/Tajo-0.11.0-build/2/ ) TAJO-1803 : Use in-memory derby as the default catalog for unit tests. (jihoonson: rev ad83927fa093bb78d83d070fb847c2bca1ceb9f3) tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/main/java/org/apache/tajo/benchmark/BenchmarkSet.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-catalog/tajo-catalog-drivers/tajo-hive/pom.xml tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-core-tests/pom.xml tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-storage/tajo-storage-hbase/pom.xml tajo-cluster-tests/src/test/java/org/apache/tajo/CatalogTestingUtil.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-storage/tajo-storage-common/pom.xml tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedCatalogStore.java tajo-metrics/src/main/proto/master_metrics.proto tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-common/src/main/proto/errors.proto tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-storage/tajo-storage-hdfs/pom.xml tajo-cluster-tests/pom.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-core/pom.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-catalog/tajo-catalog-server/pom.xml tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java tajo-project/pom.xml tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-jdbc/pom.xml tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestTupleSorter.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and branch-0.11.0.

        Show
        jihoonson Jihoon Son added a comment - Committed to master and branch-0.11.0.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson closed the pull request at:

        https://github.com/apache/tajo/pull/714

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson closed the pull request at: https://github.com/apache/tajo/pull/714

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development