Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1793

result row count unmatched for UNION ALL

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0, 0.11.2
    • Component/s: QueryMaster
    • Labels:
      None
    • Environment:

      single node on Macbook

      Description

      In UNION ALL, result record count is presented wrong.

      default> select * from test1;
      c1
      -------------------------------
      1
      2
      (2 rows, 0.027 sec, 4 B selected)

      default> select * from test2;
      c1
      -------------------------------
      2
      3
      4
      (3 rows, 0.011 sec, 6 B selected)

      default> select c1 from test1 union all select c1 from test2;
      Progress: 100%, response time: 0.458 sec
      c1
      -------------------------------
      1
      2
      2
      3
      4
      (2 rows, 0.458 sec, 10 B selected)

      ==> SHOULD BE "5 rows"

      BTW, it is OK in case of UNION .

      default> select c1 from test1 union select c1 from test2;
      Progress: 100%, response time: 0.241 sec
      c1
      -------------------------------
      2
      1
      3
      4
      (4 rows, 0.241 sec, 8 B selected)

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        It may take not short time. I rescheduled it to 0.11.1.

        Show
        hyunsik Hyunsik Choi added a comment - It may take not short time. I rescheduled it to 0.11.1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user blrunner opened a pull request:

        https://github.com/apache/tajo/pull/902

        TAJO-1793: result row count unmatched for UNION ALL

        When executing an union all query, there isn't TableDesc in ```Query```. As a result, the result stats of last stage will set output row number and volume.

        To resolve this issue, I summarized each result stats of all stages in union all query. But I found that the bytes number of stage changes occasionally. So, I just compare row number except bytes number in unit tests.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/blrunner/tajo TAJO-1793

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/902.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #902


        commit cb6b8583420f42ee82f9635a028d39193ecd60cc
        Author: JaeHwa Jung <blrunner@apache.org>
        Date: 2015-12-03T08:47:19Z

        TAJO-1793: result row count unmatched for UNION ALL


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/902 TAJO-1793 : result row count unmatched for UNION ALL When executing an union all query, there isn't TableDesc in ```Query```. As a result, the result stats of last stage will set output row number and volume. To resolve this issue, I summarized each result stats of all stages in union all query. But I found that the bytes number of stage changes occasionally. So, I just compare row number except bytes number in unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1793 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/902.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #902 commit cb6b8583420f42ee82f9635a028d39193ecd60cc Author: JaeHwa Jung <blrunner@apache.org> Date: 2015-12-03T08:47:19Z TAJO-1793 : result row count unmatched for UNION ALL
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner closed the pull request at:

        https://github.com/apache/tajo/pull/902

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner closed the pull request at: https://github.com/apache/tajo/pull/902
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user blrunner opened a pull request:

        https://github.com/apache/tajo/pull/965

        TAJO-1793: result row count unmatched for UNION ALL

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/blrunner/tajo TAJO-1793

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/965.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #965


        commit 48fce759d2ab4e322244d48b8cc8c56c80e78446
        Author: JaeHwa Jung <blrunner@apache.org>
        Date: 2016-02-18T09:30:31Z

        TAJO-1793: result row count unmatched for UNION ALL


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/965 TAJO-1793 : result row count unmatched for UNION ALL You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1793 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/965.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #965 commit 48fce759d2ab4e322244d48b8cc8c56c80e78446 Author: JaeHwa Jung <blrunner@apache.org> Date: 2016-02-18T09:30:31Z TAJO-1793 : result row count unmatched for UNION ALL
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-187036211

        Removed codes for checking ``LogicalRootNode`` and add a flag for separating union all query to ``ExecutionBlock``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-187036211 Removed codes for checking ``LogicalRootNode`` and add a flag for separating union all query to ``ExecutionBlock``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-187049011

        Remove unit test in ``TajoCli`` and add unit tests by ``TableStats``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-187049011 Remove unit test in ``TajoCli`` and add unit tests by ``TableStats``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-192067428

        In newly added tests, the same queries of our existing tests on union are executed, which means the queries of our union tests are executed twice for query result validation and result stat validation. I think it will be better to verify both query result and result stat together.

        It is simple if you get the query id of executed test query. You can get the query id from ResultSet which is actually the TajoResultSetBase. Once you get the query id, you can get TableDesc of the query result which includes the stat information. Here is an example.

        ```
        ResultSet res = executeQuery();
        QueryId qid = ((TajoResultSetBase)res).getQueryId();
        QueryInfo queryInfo = testingCluster.getMaster().getContext().getQueryJobManager().getFinishedQuery(qid);
        TableDesc desc = queryInfo.getResultDesc();
        System.out.println(desc.getStats().getNumRows());
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-192067428 In newly added tests, the same queries of our existing tests on union are executed, which means the queries of our union tests are executed twice for query result validation and result stat validation. I think it will be better to verify both query result and result stat together. It is simple if you get the query id of executed test query. You can get the query id from ResultSet which is actually the TajoResultSetBase. Once you get the query id, you can get TableDesc of the query result which includes the stat information. Here is an example. ``` ResultSet res = executeQuery(); QueryId qid = ((TajoResultSetBase)res).getQueryId(); QueryInfo queryInfo = testingCluster.getMaster().getContext().getQueryJobManager().getFinishedQuery(qid); TableDesc desc = queryInfo.getResultDesc(); System.out.println(desc.getStats().getNumRows()); ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-192083382

        Thanks @jihoonson ,

        That's a good point. I reflected your comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-192083382 Thanks @jihoonson , That's a good point. I reflected your comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r54987716

        — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java —
        @@ -697,4 +721,14 @@ public void testComplexUnion2() throws Exception {
        public void testUnionAndFilter() throws Exception {
        runSimpleTests();
        — End diff –

        Simple test is also possible to verify result stat. See #971.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r54987716 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java — @@ -697,4 +721,14 @@ public void testComplexUnion2() throws Exception { public void testUnionAndFilter() throws Exception { runSimpleTests(); — End diff – Simple test is also possible to verify result stat. See #971.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r54992987

        — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java —
        @@ -697,4 +721,14 @@ public void testComplexUnion2() throws Exception {
        public void testUnionAndFilter() throws Exception {
        runSimpleTests();
        — End diff –

        I applied ``QueryTestCaseBase::runSimpleTests`` with your opinion.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r54992987 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java — @@ -697,4 +721,14 @@ public void testComplexUnion2() throws Exception { public void testUnionAndFilter() throws Exception { runSimpleTests(); — End diff – I applied ``QueryTestCaseBase::runSimpleTests`` with your opinion.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-192295793

        I got to know that ``Query`` must calculates result stats of child stages. So I removed existing related codes and implemented codes for computing stats to ``Query``. And I applied verification for result stats in ``TestUnionQuery``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-192295793 I got to know that ``Query`` must calculates result stats of child stages. So I removed existing related codes and implemented codes for computing stats to ``Query``. And I applied verification for result stats in ``TestUnionQuery``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55156704

        — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java —
        @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() {
        }
        }

        + public boolean hasUnionPlan() throws Exception {
        + boolean result = false;
        +
        + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has
        + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages.
        + ExecutionBlock terminalBlock = plan.getTerminalBlock();
        + terminalBlock.setPlan(terminalBlock.getPlan());
        — End diff –

        The terminal block doesn't have any plan, so this line doesn't affect to anything. I wonder what is your intention.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55156704 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java — @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() { } } + public boolean hasUnionPlan() throws Exception { + boolean result = false; + + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages. + ExecutionBlock terminalBlock = plan.getTerminalBlock(); + terminalBlock.setPlan(terminalBlock.getPlan()); — End diff – The terminal block doesn't have any plan, so this line doesn't affect to anything. I wonder what is your intention.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55156791

        — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java —
        @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() {
        }
        }

        + public boolean hasUnionPlan() throws Exception {
        + boolean result = false;
        +
        + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has
        + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages.
        + ExecutionBlock terminalBlock = plan.getTerminalBlock();
        + terminalBlock.setPlan(terminalBlock.getPlan());
        + if (plan.getChilds(terminalBlock.getId()).size() >= 2)

        { + result = true; + }

        + return result;
        + }
        +
        + public TableStats computeChildResultStats() throws Exception {
        — End diff –

        A better implementation exists at Stage.computeStatFromUnionBlock(). It would be better to move this method to StatisticsUtil.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55156791 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java — @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() { } } + public boolean hasUnionPlan() throws Exception { + boolean result = false; + + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages. + ExecutionBlock terminalBlock = plan.getTerminalBlock(); + terminalBlock.setPlan(terminalBlock.getPlan()); + if (plan.getChilds(terminalBlock.getId()).size() >= 2) { + result = true; + } + return result; + } + + public TableStats computeChildResultStats() throws Exception { — End diff – A better implementation exists at Stage.computeStatFromUnionBlock(). It would be better to move this method to StatisticsUtil.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55159440

        — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java —
        @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() {
        }
        }

        + public boolean hasUnionPlan() throws Exception {
        + boolean result = false;
        +
        + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has
        + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages.
        + ExecutionBlock terminalBlock = plan.getTerminalBlock();
        + terminalBlock.setPlan(terminalBlock.getPlan());
        — End diff –

        I agree with you and reflected your comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55159440 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java — @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() { } } + public boolean hasUnionPlan() throws Exception { + boolean result = false; + + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages. + ExecutionBlock terminalBlock = plan.getTerminalBlock(); + terminalBlock.setPlan(terminalBlock.getPlan()); — End diff – I agree with you and reflected your comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55160104

        — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java —
        @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() {
        }
        }

        + public boolean hasUnionPlan() throws Exception {
        + boolean result = false;
        +
        + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has
        + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages.
        + ExecutionBlock terminalBlock = plan.getTerminalBlock();
        + terminalBlock.setPlan(terminalBlock.getPlan());
        + if (plan.getChilds(terminalBlock.getId()).size() >= 2)

        { + result = true; + }

        + return result;
        + }
        +
        + public TableStats computeChildResultStats() throws Exception {
        — End diff –

        Moving this method to ``StatisticsUtil`` throws compile error as following:
        ```
        [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex

        {label='org.apache.tajo:tajo-catalog-common:0.12.0-SNAPSHOT'}

        ' and 'Vertex

        {label='org.apache.tajo:tajo-core:0.12.0-SNAPSHOT'}

        ' introduces to cycle in the graph org.apache.tajo:tajo-core:0.12.0-SNAPSHOT --> org.apache.tajo:tajo-catalog-common:0.12.0-SNAPSHOT --> org.apache.tajo:tajo-core:0.12.0-SNAPSHOT -> [Help 1]
        ```

        It seems that because there is a cyclic reference between tajo-catalog-common module and tajo-core module. So I improved this method using ``StatisticsUtil.aggregateTableStat`` instead of moving to ``StatisticsUtil``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55160104 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java — @@ -402,6 +403,39 @@ public QueryState getSynchronizedState() { } } + public boolean hasUnionPlan() throws Exception { + boolean result = false; + + // During executing UNION statement or UNION ALL statement, the terminal block doesn't have join plan and has + // two more child blocks. In above case, Tajo should summarize result TableStats from all child stages. + ExecutionBlock terminalBlock = plan.getTerminalBlock(); + terminalBlock.setPlan(terminalBlock.getPlan()); + if (plan.getChilds(terminalBlock.getId()).size() >= 2) { + result = true; + } + return result; + } + + public TableStats computeChildResultStats() throws Exception { — End diff – Moving this method to ``StatisticsUtil`` throws compile error as following: ``` [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex {label='org.apache.tajo:tajo-catalog-common:0.12.0-SNAPSHOT'} ' and 'Vertex {label='org.apache.tajo:tajo-core:0.12.0-SNAPSHOT'} ' introduces to cycle in the graph org.apache.tajo:tajo-core:0.12.0-SNAPSHOT --> org.apache.tajo:tajo-catalog-common:0.12.0-SNAPSHOT --> org.apache.tajo:tajo-core:0.12.0-SNAPSHOT -> [Help 1] ``` It seems that because there is a cyclic reference between tajo-catalog-common module and tajo-core module. So I improved this method using ``StatisticsUtil.aggregateTableStat`` instead of moving to ``StatisticsUtil``.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55160199

        — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java —
        @@ -653,12 +679,19 @@ public void execute(QueryMaster.QueryMasterContext context, QueryContext queryCo
        TableDesc resultTableDesc =
        new TableDesc(
        query.getId().toString(),

        • lastStage.getOutSchema(),
          + lastStage.getOutSchema(),
          meta,
          finalOutputDir.toUri());
          resultTableDesc.setExternal(true);
        • stats.setNumBytes(getTableVolume(query.systemConf, finalOutputDir));
          + if (query.hasUnionPlan()) {
          + TableStats aggregated = query.aggregateTableStatsOfTerminalBlock();
          + stats.setNumRows(aggregated.getNumRows());
          + stats.setNumBytes(aggregated.getNumBytes());
            • End diff –

        Copying numRows and numBytes is insufficient. ```aggretated``` should be set as the stats of ```resultTableDesc```.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55160199 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java — @@ -653,12 +679,19 @@ public void execute(QueryMaster.QueryMasterContext context, QueryContext queryCo TableDesc resultTableDesc = new TableDesc( query.getId().toString(), lastStage.getOutSchema(), + lastStage.getOutSchema(), meta, finalOutputDir.toUri()); resultTableDesc.setExternal(true); stats.setNumBytes(getTableVolume(query.systemConf, finalOutputDir)); + if (query.hasUnionPlan()) { + TableStats aggregated = query.aggregateTableStatsOfTerminalBlock(); + stats.setNumRows(aggregated.getNumRows()); + stats.setNumBytes(aggregated.getNumBytes()); End diff – Copying numRows and numBytes is insufficient. ```aggretated``` should be set as the stats of ```resultTableDesc```.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55160276

        — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java —
        @@ -43,658 +49,760 @@ public TestUnionQuery()

        { super(TajoConstants.DEFAULT_DATABASE_NAME); }
        • @Test
          /**
        • S (SA U SA) O
          */
          + @Test
          + @SimpleTest
          public final void testUnionAll1() throws Exception {
        • ResultSet res = executeQuery();
        • assertResultSet(res);
        • cleanupQuery(res);
          + Optional<TajoResultSetBase[]> existing = runSimpleTests();
          + assertTrue(existing.isPresent());
          + TajoResultSetBase[] resultSet = existing.get();
          + QueryId qid = resultSet[0].getQueryId();
          + QueryInfo queryInfo = testingCluster.getMaster().getContext().getQueryJobManager().getFinishedQuery(qid);
          + TableDesc desc = queryInfo.getResultDesc();
          + TableStats stats = desc.getStats();
          + assertEquals(8L, stats.getNumRows().longValue());
          + assertEquals(96L, stats.getNumBytes().longValue());
            • End diff –

        resultSets should be closed when a test is finished. Use QueryTestCaseBase.closeResultSets().

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55160276 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java — @@ -43,658 +49,760 @@ public TestUnionQuery() { super(TajoConstants.DEFAULT_DATABASE_NAME); } @Test /** S (SA U SA) O */ + @Test + @SimpleTest public final void testUnionAll1() throws Exception { ResultSet res = executeQuery(); assertResultSet(res); cleanupQuery(res); + Optional<TajoResultSetBase[]> existing = runSimpleTests(); + assertTrue(existing.isPresent()); + TajoResultSetBase[] resultSet = existing.get(); + QueryId qid = resultSet [0] .getQueryId(); + QueryInfo queryInfo = testingCluster.getMaster().getContext().getQueryJobManager().getFinishedQuery(qid); + TableDesc desc = queryInfo.getResultDesc(); + TableStats stats = desc.getStats(); + assertEquals(8L, stats.getNumRows().longValue()); + assertEquals(96L, stats.getNumBytes().longValue()); End diff – resultSets should be closed when a test is finished. Use QueryTestCaseBase.closeResultSets().
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/965#discussion_r55160312

        — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java —
        @@ -43,658 +49,760 @@ public TestUnionQuery()

        { super(TajoConstants.DEFAULT_DATABASE_NAME); }
        • @Test
          /**
        • S (SA U SA) O
          */
          + @Test
          + @SimpleTest
          public final void testUnionAll1() throws Exception {
        • ResultSet res = executeQuery();
        • assertResultSet(res);
        • cleanupQuery(res);
          + Optional<TajoResultSetBase[]> existing = runSimpleTests();
            • End diff –

        How about making the below testing code as a separate method to reuse in every test of this class?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/965#discussion_r55160312 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java — @@ -43,658 +49,760 @@ public TestUnionQuery() { super(TajoConstants.DEFAULT_DATABASE_NAME); } @Test /** S (SA U SA) O */ + @Test + @SimpleTest public final void testUnionAll1() throws Exception { ResultSet res = executeQuery(); assertResultSet(res); cleanupQuery(res); + Optional<TajoResultSetBase[]> existing = runSimpleTests(); End diff – How about making the below testing code as a separate method to reuse in every test of this class?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-193140586

        @jihoonson

        Thank your for your detailed review. I reflected your comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-193140586 @jihoonson Thank your for your detailed review. I reflected your comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/965#issuecomment-193639700

        +1. Please don't forget to change Java's Optional to Google's one when you commit to 0.11.2 branch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/965#issuecomment-193639700 +1. Please don't forget to change Java's Optional to Google's one when you commit to 0.11.2 branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/965

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/965
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #690 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/690/)
        TAJO-1793: result row count unmatched for UNION ALL. (blrunner: rev f115833b9ff97a178febf3753f516888a3161af7)

        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result
        • CHANGES
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #690 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/690/ ) TAJO-1793 : result row count unmatched for UNION ALL. (blrunner: rev f115833b9ff97a178febf3753f516888a3161af7) tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result CHANGES tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1099 (See https://builds.apache.org/job/Tajo-master-build/1099/)
        TAJO-1793: result row count unmatched for UNION ALL. (blrunner: rev f115833b9ff97a178febf3753f516888a3161af7)

        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result
        • CHANGES
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1099 (See https://builds.apache.org/job/Tajo-master-build/1099/ ) TAJO-1793 : result row count unmatched for UNION ALL. (blrunner: rev f115833b9ff97a178febf3753f516888a3161af7) tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result CHANGES tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.2-build #179 (See https://builds.apache.org/job/Tajo-0.11.2-build/179/)
        TAJO-1793: result row count unmatched for UNION ALL. (blrunner: rev fbbe6ee194b82f347af58a94cee9ab7d038f6577)

        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result
        • CHANGES
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result
        • tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java
        • tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.2-build #179 (See https://builds.apache.org/job/Tajo-0.11.2-build/179/ ) TAJO-1793 : result row count unmatched for UNION ALL. (blrunner: rev fbbe6ee194b82f347af58a94cee9ab7d038f6577) tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll10.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll14.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion12.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion6.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithSameAliasNames.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion2.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testAllUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll2.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testRightUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll11.result CHANGES tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAliasAndFunction.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testRightUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testTajo1368Case1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll8.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testThreeJoinInUnion.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionCaseOfFirstEmptyAndJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithCrossJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion14.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testThreeJoinInUnion.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll9.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testAllUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion8.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll15.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll3.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll6.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion13.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion4.result tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll5.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion11.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll12.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll16.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAlias.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testLeftUnionWithJoin.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion3.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case1.sql tajo-core-tests/src/test/resources/queries/TestUnionQuery/testUnionWithCrossJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll7.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion9.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testLeftUnionWithJoin.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll1.result tajo-core-tests/src/test/resources/queries/TestUnionQuery/testTajo1368Case2.sql tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion5.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion7.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionWithDifferentAlias.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion1.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion16.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll13.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAll4.result tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnionAllWithDifferentAliasAndFunction.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java tajo-core-tests/src/test/resources/results/TestUnionQuery/testUnion10.result

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            ykko Youngkyong Ko
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development