Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.0, 0.10.0, 0.10.1
    • Fix Version/s: 0.11.0
    • Component/s: TajoMaster, Worker
    • Labels:
      None

      Description

      Remove and improvement a unnecessary method(getMountPath()).

      • getMountPath() of TajoMaster is not use. So it be remove.
      • getMountPath() of TajoWorker is only use in initCleanupService() of TajoWorker. It is in order that get count of worker temporal dir. But getMountPath() is unobtainable correct count. It can get in WORKER_TEMPORAL_DIR of config.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hys9958 opened a pull request:

        https://github.com/apache/tajo/pull/674

        TAJO-1736: Remove and improvement a unnecessary method(getMountPath()).

        Hi.

        • I have removed getMountPath() of TajoMaster.
        • I have removed getMountPath() of TajoWorker and changed initCleanupService() so that use WORKER_TEMPORAL_DIR of config.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hys9958/tajo TAJO-1736-2

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/674.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #674


        commit ef1835063f1e264f4ba7e7c6d3158d371d422835
        Author: Yeonsu Han <hanyounsu@gmail.com>
        Date: 2015-08-02T18:20:00Z

        TAJO-1736: Remove and improvement a unnecessary method(getMountPath()).


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hys9958 opened a pull request: https://github.com/apache/tajo/pull/674 TAJO-1736 : Remove and improvement a unnecessary method(getMountPath()). Hi. I have removed getMountPath() of TajoMaster. I have removed getMountPath() of TajoWorker and changed initCleanupService() so that use WORKER_TEMPORAL_DIR of config. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hys9958/tajo TAJO-1736 -2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #674 commit ef1835063f1e264f4ba7e7c6d3158d371d422835 Author: Yeonsu Han <hanyounsu@gmail.com> Date: 2015-08-02T18:20:00Z TAJO-1736 : Remove and improvement a unnecessary method(getMountPath()).
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/674#issuecomment-127135265

        +1 LGTM
        Thank you for your contribution!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/674#issuecomment-127135265 +1 LGTM Thank you for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/674

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/674
        Hide
        jhkim Jinho Kim added a comment -

        committed it to master
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it to master Thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #424 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/424/)
        TAJO-1736: Remove unnecessary getMountPath(). (jhkim: rev e44bca79ddc4afdae6898f75f07bda0d3830db53)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #424 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/424/ ) TAJO-1736 : Remove unnecessary getMountPath(). (jhkim: rev e44bca79ddc4afdae6898f75f07bda0d3830db53) tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #786 (See https://builds.apache.org/job/Tajo-master-build/786/)
        TAJO-1736: Remove unnecessary getMountPath(). (jhkim: rev e44bca79ddc4afdae6898f75f07bda0d3830db53)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #786 (See https://builds.apache.org/job/Tajo-master-build/786/ ) TAJO-1736 : Remove unnecessary getMountPath(). (jhkim: rev e44bca79ddc4afdae6898f75f07bda0d3830db53) tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java

          People

          • Assignee:
            hys9958 YeonSu Han
            Reporter:
            hys9958 YeonSu Han
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development