Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1721

Separate routine for CREATE TABLE from DDLExecutor

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      This is a simple refactoring to separate an execution code for CREATE TABLE from DDLExecutor and clean up the code.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #787 (See https://builds.apache.org/job/Tajo-master-build/787/)
        TAJO-1721: Separate routine for CREATE TABLE from DDLExecutor. (hyunsik: rev 1be0e66b298bd969f331719d71785655839810f7)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #787 (See https://builds.apache.org/job/Tajo-master-build/787/ ) TAJO-1721 : Separate routine for CREATE TABLE from DDLExecutor. (hyunsik: rev 1be0e66b298bd969f331719d71785655839810f7) tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #425 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/425/)
        TAJO-1721: Separate routine for CREATE TABLE from DDLExecutor. (hyunsik: rev 1be0e66b298bd969f331719d71785655839810f7)

        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #425 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/425/ ) TAJO-1721 : Separate routine for CREATE TABLE from DDLExecutor. (hyunsik: rev 1be0e66b298bd969f331719d71785655839810f7) tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/666

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/666
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/666#issuecomment-127135106

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/666#issuecomment-127135106 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/666#issuecomment-127122377

        I just rebased.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/666#issuecomment-127122377 I just rebased.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/666#issuecomment-126583221

        Could you rebase this patch?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/666#issuecomment-126583221 Could you rebase this patch?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/666

        TAJO-1721: Separate routine for CREATE TABLE from DDLExecutor.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1721

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/666.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #666


        commit 8248881414a235cb8f5fd80b29113f470a203b9a
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-29T13:59:15Z

        TAJO-1721: Separate routine for CREATE TABLE from DDLExecutor.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/666 TAJO-1721 : Separate routine for CREATE TABLE from DDLExecutor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/666.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #666 commit 8248881414a235cb8f5fd80b29113f470a203b9a Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-29T13:59:15Z TAJO-1721 : Separate routine for CREATE TABLE from DDLExecutor.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development