Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1703

Remove hardcoded value in NodeStatusUpdater

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Resource Manager, Worker
    • Labels:
      None

      Description

      NodeStatusUpdater updates the current status when resources is changed and it determined by threshold.
      If a server is very high spec hardware, lower value is better in order to low latency.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/649

        TAJO-1703: Remove hardcoded value in NodeStatusUpdater

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1703

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/649.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #649


        commit 0ea5ebb231911759a3248e474beea506925e1c6b
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-07-24T03:05:08Z

        TAJO-1703: Remove hardcoded value in NodeStatusUpdater


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/649 TAJO-1703 : Remove hardcoded value in NodeStatusUpdater You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1703 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/649.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #649 commit 0ea5ebb231911759a3248e474beea506925e1c6b Author: Jinho Kim <jhkim@apache.org> Date: 2015-07-24T03:05:08Z TAJO-1703 : Remove hardcoded value in NodeStatusUpdater
        Hide
        jhkim Jinho Kim added a comment -

        Here is my test result.

        • 1 master + 6 worker
          • CPU: 48 core, Memory: 128GB, Disk: SAS 7.2K * 12
        • TPC-H scale 1TB
          Status update rate 50% 30%
          select count from lineitem 110 sec 102 sec
          Master CPU usage 0.3 0.7
          Locality 99.984 99.984
        Show
        jhkim Jinho Kim added a comment - Here is my test result. 1 master + 6 worker CPU: 48 core, Memory: 128GB, Disk: SAS 7.2K * 12 TPC-H scale 1TB Status update rate 50% 30% select count from lineitem 110 sec 102 sec Master CPU usage 0.3 0.7 Locality 99.984 99.984
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/649#issuecomment-124345267

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/649#issuecomment-124345267 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/649

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/649
        Hide
        jhkim Jinho Kim added a comment -

        Committed!
        Thanks.

        Show
        jhkim Jinho Kim added a comment - Committed! Thanks.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #411 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/411/)
        TAJO-1703: Remove hardcoded value in NodeStatusUpdater. (jinho) (jhkim: rev 59cb66fc40b78d1f884f008796b85312d6ae8c72)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/worker/NodeStatusUpdater.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #411 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/411/ ) TAJO-1703 : Remove hardcoded value in NodeStatusUpdater. (jinho) (jhkim: rev 59cb66fc40b78d1f884f008796b85312d6ae8c72) CHANGES tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/worker/NodeStatusUpdater.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #774 (See https://builds.apache.org/job/Tajo-master-build/774/)
        TAJO-1703: Remove hardcoded value in NodeStatusUpdater. (jinho) (jhkim: rev 59cb66fc40b78d1f884f008796b85312d6ae8c72)

        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/NodeStatusUpdater.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #774 (See https://builds.apache.org/job/Tajo-master-build/774/ ) TAJO-1703 : Remove hardcoded value in NodeStatusUpdater. (jinho) (jhkim: rev 59cb66fc40b78d1f884f008796b85312d6ae8c72) tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/NodeStatusUpdater.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development