Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1702

Fix race condition in finished query cache

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: QueryMaster, TajoMaster
    • Labels:
      None

      Description

      org.apache.tajo.engine.query.TestInnerJoinWithSubQuery
      testThetaJoinKeyPairs[3](org.apache.tajo.engine.query.TestInnerJoinWithSubQuery)  Time elapsed: 0.764 sec  <<< ERROR!
      java.sql.SQLException: query q_1437635315217_0415 does not exist
      	at org.apache.tajo.exception.SQLExceptionUtil.toSQLException(SQLExceptionUtil.java:70)
      	at org.apache.tajo.exception.SQLExceptionUtil.throwIfError(SQLExceptionUtil.java:53)
      	at org.apache.tajo.client.QueryClientImpl.getQueryStatus(QueryClientImpl.java:272)
      	at org.apache.tajo.client.TajoClientUtil.waitCompletion(TajoClientUtil.java:71)
      	at org.apache.tajo.client.QueryClientImpl.getQueryResultAndWait(QueryClientImpl.java:239)
      	at org.apache.tajo.client.QueryClientImpl.executeQueryAndGetResult(QueryClientImpl.java:190)
      	at org.apache.tajo.client.TajoClientImpl.executeQueryAndGetResult(TajoClientImpl.java:109)
      	at org.apache.tajo.QueryTestCaseBase.runSimpleTests(QueryTestCaseBase.java:527)
      	at org.apache.tajo.engine.query.TestInnerJoinWithSubQuery.testThetaJoinKeyPairs(TestInnerJoinWithSubQuery.java:131)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
      	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
      	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
      	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
      	at org.junit.runners.Suite.runChild(Suite.java:127)
      	at org.junit.runners.Suite.runChild(Suite.java:26)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
      	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
      	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
      	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
      	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
      	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
      	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/647

        TAJO-1702: Fix race condition in finished query cache

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1702

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/647.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #647


        commit 442ffd9e08b680cef9bbbf82333170e328759530
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-07-24T02:29:12Z

        TAJO-1702: Fix race condition in finished query cache


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/647 TAJO-1702 : Fix race condition in finished query cache You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1702 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/647.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #647 commit 442ffd9e08b680cef9bbbf82333170e328759530 Author: Jinho Kim <jhkim@apache.org> Date: 2015-07-24T02:29:12Z TAJO-1702 : Fix race condition in finished query cache
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/647#issuecomment-124327997

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/647#issuecomment-124327997 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/647

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/647
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #771 (See https://builds.apache.org/job/Tajo-master-build/771/)
        TAJO-1702: Fix race condition in finished query cache. (jinho) (jhkim: rev 009e8e5aee3a28cbfb1e380204bc65fe81acbea2)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #771 (See https://builds.apache.org/job/Tajo-master-build/771/ ) TAJO-1702 : Fix race condition in finished query cache. (jinho) (jhkim: rev 009e8e5aee3a28cbfb1e380204bc65fe81acbea2) CHANGES tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #409 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/409/)
        TAJO-1702: Fix race condition in finished query cache. (jinho) (jhkim: rev 009e8e5aee3a28cbfb1e380204bc65fe81acbea2)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #409 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/409/ ) TAJO-1702 : Fix race condition in finished query cache. (jinho) (jhkim: rev 009e8e5aee3a28cbfb1e380204bc65fe81acbea2) CHANGES tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development