Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1700

Add better exception handling in TajoMasterClientService

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      TajoMasterClientService provides Remote Client API services. I found some API does not correctly handle exceptions in a way of TAJO-1670.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/644

        TAJO-1700: Add better exception handling in TajoMasterClientService.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1700

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/644.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #644


        commit 689aa425f0361813925e70e59406e3c8558ec062
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-23T06:57:45Z

        TAJO-1700: Add better exception handling in TajoMasterClientService.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/644 TAJO-1700 : Add better exception handling in TajoMasterClientService. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1700 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/644.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #644 commit 689aa425f0361813925e70e59406e3c8558ec062 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-23T06:57:45Z TAJO-1700 : Add better exception handling in TajoMasterClientService.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/644#issuecomment-124157297

        I just fixed one wrong implementation in existSessionVariable in client side.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/644#issuecomment-124157297 I just fixed one wrong implementation in existSessionVariable in client side.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/644#issuecomment-124288522

        +1. Recent your work around error propagation is really nice.
        Thanks for your effort.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/644#issuecomment-124288522 +1. Recent your work around error propagation is really nice. Thanks for your effort.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/644

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/644
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #407 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/407/)
        TAJO-1700: Add better exception handling in TajoMasterClientService. (hyunsik: rev 61d1d33047f316cf032714e4dd9bd7e145cd9ade)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #407 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/407/ ) TAJO-1700 : Add better exception handling in TajoMasterClientService. (hyunsik: rev 61d1d33047f316cf032714e4dd9bd7e145cd9ade) tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/proto/TajoMasterClientProtocol.proto tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #769 (See https://builds.apache.org/job/Tajo-master-build/769/)
        TAJO-1700: Add better exception handling in TajoMasterClientService. (hyunsik: rev 61d1d33047f316cf032714e4dd9bd7e145cd9ade)

        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #769 (See https://builds.apache.org/job/Tajo-master-build/769/ ) TAJO-1700 : Add better exception handling in TajoMasterClientService. (hyunsik: rev 61d1d33047f316cf032714e4dd9bd7e145cd9ade) tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development