Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1695

Shuffle fetcher executor should be consider random writing

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: Data Shuffle, Worker
    • Labels:
      None

      Description

      Currently, shuffle fetcher executes simultaneously in same thread pool and It happens a lot of random writing.
      We should change to dedicated thread pool per taskContainer

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/639

        TAJO-1695: Shuffle fetcher executor should be consider random writing

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1695

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/639.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #639


        commit 5b2e144cc2cea540d17440a9ab62a1a06e0dac57
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-07-21T09:47:55Z

        TAJO-1695: Shuffle fetcher executor should be consider random writing


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/639 TAJO-1695 : Shuffle fetcher executor should be consider random writing You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1695 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit 5b2e144cc2cea540d17440a9ab62a1a06e0dac57 Author: Jinho Kim <jhkim@apache.org> Date: 2015-07-21T09:47:55Z TAJO-1695 : Shuffle fetcher executor should be consider random writing
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/639#issuecomment-123546458

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/639#issuecomment-123546458 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/639

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/639
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thank you for your quick review!

        Show
        jhkim Jinho Kim added a comment - committed it. Thank you for your quick review!
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #399 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/399/)
        TAJO-1695: Shuffle fetcher executor should be consider random writing. (jinho) (jhkim: rev 62534a8775ede8949b4b738b99807d4f7a91bd03)

        • tajo-core/src/test/java/org/apache/tajo/worker/MockTaskExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #399 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/399/ ) TAJO-1695 : Shuffle fetcher executor should be consider random writing. (jinho) (jhkim: rev 62534a8775ede8949b4b738b99807d4f7a91bd03) tajo-core/src/test/java/org/apache/tajo/worker/MockTaskExecutor.java tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #759 (See https://builds.apache.org/job/Tajo-master-build/759/)
        TAJO-1695: Shuffle fetcher executor should be consider random writing. (jinho) (jhkim: rev 62534a8775ede8949b4b738b99807d4f7a91bd03)

        • tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/test/java/org/apache/tajo/worker/MockTaskExecutor.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java
        • tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #759 (See https://builds.apache.org/job/Tajo-master-build/759/ ) TAJO-1695 : Shuffle fetcher executor should be consider random writing. (jinho) (jhkim: rev 62534a8775ede8949b4b738b99807d4f7a91bd03) tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/test/java/org/apache/tajo/worker/MockTaskExecutor.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java tajo-core/src/test/java/org/apache/tajo/querymaster/TestKillQuery.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development