Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Metrics
    • Labels:
      None

      Description

      We need to rearrange metric hierarchy and their names. We also need to use enumeration types instead of literal strings.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/642

        TAJO-1693: Rearrange metric names.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1693

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/642.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #642


        commit 44f573bd284df510a75d235e6f2ad96cc8d9c8f1
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-22T15:21:51Z

        TAJO-1693: Rearrange metric names.

        commit 9a61a002f86ac24aae1dee32a1217c8cf957207d
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-22T15:22:00Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1693


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/642 TAJO-1693 : Rearrange metric names. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1693 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/642.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #642 commit 44f573bd284df510a75d235e6f2ad96cc8d9c8f1 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-22T15:21:51Z TAJO-1693 : Rearrange metric names. commit 9a61a002f86ac24aae1dee32a1217c8cf957207d Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-22T15:22:00Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1693
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/642#discussion_r35293297

        — Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java —
        @@ -47,7 +47,7 @@ public void run() {
        try {
        task = executor.getNextTask();

        • task.getExecutionBlockContext().getWorkerContext().getWorkerSystemMetrics().counter("query", "task").inc();
          + //task.getExecutionBlockContext().getWorkerContext().getMetrics().counter(org.apache.tajo.metrics."query", "task").inc();
            • End diff –

        Please remove this line.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/642#discussion_r35293297 — Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java — @@ -47,7 +47,7 @@ public void run() { try { task = executor.getNextTask(); task.getExecutionBlockContext().getWorkerContext().getWorkerSystemMetrics().counter("query", "task").inc(); + //task.getExecutionBlockContext().getWorkerContext().getMetrics().counter(org.apache.tajo.metrics."query", "task").inc(); End diff – Please remove this line.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/642#issuecomment-123998100

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/642#issuecomment-123998100 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/642

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/642
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed, and fixing it as resolved.

        Show
        hyunsik Hyunsik Choi added a comment - committed, and fixing it as resolved.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #404 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/404/)
        TAJO-1693: Rearrange metric names. (hyunsik: rev 3919896e10822929ead6ceb797acfc067137ef05)

        • tajo-metrics/src/main/proto/master_metrics.proto
        • tajo-core/pom.xml
        • CHANGES
        • tajo-metrics/src/test/java/org/apache/tajo/metrics/TestMetricsUtil.java
        • tajo-metrics/src/main/proto/node_metrics.proto
        • tajo-core/src/main/java/org/apache/tajo/session/SessionManager.java
        • tajo-metrics/pom.xml
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskManager.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java
        • tajo-metrics/src/main/java/org/apache/tajo/metrics/MetricsUtil.java
        • tajo-core/src/main/java/org/apache/tajo/metrics/CatalogMetricsGaugeSet.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-core/src/main/java/org/apache/tajo/metrics/ClusterResourceMetricSet.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java
        • tajo-core/src/test/java/org/apache/tajo/worker/MockWorkerContext.java
        • tajo-core/src/main/java/org/apache/tajo/metrics/WorkerResourceMetricsGaugeSet.java
        • tajo-project/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/util/metrics/TestSystemMetrics.java
        • pom.xml
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterManagerService.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java
        • tajo-dist/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestNodeStatusUpdater.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestNodeResourceManager.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoMetrics.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #404 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/404/ ) TAJO-1693 : Rearrange metric names. (hyunsik: rev 3919896e10822929ead6ceb797acfc067137ef05) tajo-metrics/src/main/proto/master_metrics.proto tajo-core/pom.xml CHANGES tajo-metrics/src/test/java/org/apache/tajo/metrics/TestMetricsUtil.java tajo-metrics/src/main/proto/node_metrics.proto tajo-core/src/main/java/org/apache/tajo/session/SessionManager.java tajo-metrics/pom.xml tajo-core/src/test/java/org/apache/tajo/worker/TestTaskManager.java tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java tajo-metrics/src/main/java/org/apache/tajo/metrics/MetricsUtil.java tajo-core/src/main/java/org/apache/tajo/metrics/CatalogMetricsGaugeSet.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-core/src/main/java/org/apache/tajo/metrics/ClusterResourceMetricSet.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java tajo-core/src/test/java/org/apache/tajo/worker/MockWorkerContext.java tajo-core/src/main/java/org/apache/tajo/metrics/WorkerResourceMetricsGaugeSet.java tajo-project/pom.xml tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java tajo-core/src/test/java/org/apache/tajo/util/metrics/TestSystemMetrics.java pom.xml tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterManagerService.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java tajo-dist/pom.xml tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java tajo-core/src/test/java/org/apache/tajo/worker/TestNodeStatusUpdater.java tajo-core/src/test/java/org/apache/tajo/worker/TestNodeResourceManager.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoMetrics.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #766 (See https://builds.apache.org/job/Tajo-master-build/766/)
        TAJO-1693: Rearrange metric names. (hyunsik: rev 3919896e10822929ead6ceb797acfc067137ef05)

        • tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java
        • pom.xml
        • tajo-core/src/test/java/org/apache/tajo/util/metrics/TestSystemMetrics.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestNodeStatusUpdater.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java
        • tajo-metrics/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/test/java/org/apache/tajo/worker/MockWorkerContext.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoMetrics.java
        • tajo-dist/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java
        • tajo-metrics/src/main/proto/node_metrics.proto
        • tajo-core/src/main/java/org/apache/tajo/metrics/WorkerResourceMetricsGaugeSet.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestNodeResourceManager.java
        • tajo-core/src/main/java/org/apache/tajo/metrics/CatalogMetricsGaugeSet.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java
        • tajo-metrics/src/test/java/org/apache/tajo/metrics/TestMetricsUtil.java
        • tajo-core/pom.xml
        • tajo-project/pom.xml
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterManagerService.java
        • tajo-metrics/src/main/java/org/apache/tajo/metrics/MetricsUtil.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/session/SessionManager.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestTaskManager.java
        • tajo-metrics/src/main/proto/master_metrics.proto
        • tajo-core/src/main/java/org/apache/tajo/metrics/ClusterResourceMetricSet.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #766 (See https://builds.apache.org/job/Tajo-master-build/766/ ) TAJO-1693 : Rearrange metric names. (hyunsik: rev 3919896e10822929ead6ceb797acfc067137ef05) tajo-core/src/main/java/org/apache/tajo/master/QueryCoordinatorService.java pom.xml tajo-core/src/test/java/org/apache/tajo/util/metrics/TestSystemMetrics.java tajo-core/src/test/java/org/apache/tajo/worker/TestNodeStatusUpdater.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java tajo-metrics/pom.xml tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/test/java/org/apache/tajo/worker/MockWorkerContext.java tajo-core/src/main/java/org/apache/tajo/worker/TaskExecutor.java tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoMetrics.java tajo-dist/pom.xml tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoSystemMetrics.java tajo-metrics/src/main/proto/node_metrics.proto tajo-core/src/main/java/org/apache/tajo/metrics/WorkerResourceMetricsGaugeSet.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/test/java/org/apache/tajo/worker/TestNodeResourceManager.java tajo-core/src/main/java/org/apache/tajo/metrics/CatalogMetricsGaugeSet.java tajo-core/src/test/java/org/apache/tajo/worker/TestTaskExecutor.java tajo-metrics/src/test/java/org/apache/tajo/metrics/TestMetricsUtil.java tajo-core/pom.xml tajo-project/pom.xml CHANGES tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterManagerService.java tajo-metrics/src/main/java/org/apache/tajo/metrics/MetricsUtil.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/session/SessionManager.java tajo-core/src/test/java/org/apache/tajo/worker/TestTaskManager.java tajo-metrics/src/main/proto/master_metrics.proto tajo-core/src/main/java/org/apache/tajo/metrics/ClusterResourceMetricSet.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development