Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Storage
    • Labels:
      None

      Description

      The current TablespaceManager only allows registered URIs. After TAJO-1616, CREATE EXTERNAL TABLE only allows a full qualified URI. We should allow just a path for compatibility.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/629

        TAJO-1684: TablespaceManager should allow arbitrary URIs.

        This patch does not need unit tests. All unit tests works well, although this patch removed some tablespaces being added automatically to TablespaceManager for unit tests.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1684

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/629.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #629


        commit 36b8195e2f51670dce07e737493cafda6a2e20e6
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-14T08:08:20Z

        TAJO-1684: TablespaceManager should allow arbitrary URIs.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/629 TAJO-1684 : TablespaceManager should allow arbitrary URIs. This patch does not need unit tests. All unit tests works well, although this patch removed some tablespaces being added automatically to TablespaceManager for unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1684 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #629 commit 36b8195e2f51670dce07e737493cafda6a2e20e6 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-14T08:08:20Z TAJO-1684 : TablespaceManager should allow arbitrary URIs.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/629#issuecomment-122841342

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/629#issuecomment-122841342 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/629

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/629
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #396 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/396/)
        TAJO-1684: CREATE EXTERNAL TABLE should allows just a path. (hyunsik: rev bdd102c8f7446c43404ec9bd81d576e3be9dc90c)

        • tajo-common/src/main/java/org/apache/tajo/storage/StorageService.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #396 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/396/ ) TAJO-1684 : CREATE EXTERNAL TABLE should allows just a path. (hyunsik: rev bdd102c8f7446c43404ec9bd81d576e3be9dc90c) tajo-common/src/main/java/org/apache/tajo/storage/StorageService.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #757 (See https://builds.apache.org/job/Tajo-master-build/757/)
        TAJO-1684: CREATE EXTERNAL TABLE should allows just a path. (hyunsik: rev bdd102c8f7446c43404ec9bd81d576e3be9dc90c)

        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-common/src/main/java/org/apache/tajo/storage/StorageService.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #757 (See https://builds.apache.org/job/Tajo-master-build/757/ ) TAJO-1684 : CREATE EXTERNAL TABLE should allows just a path. (hyunsik: rev bdd102c8f7446c43404ec9bd81d576e3be9dc90c) tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-common/src/main/java/org/apache/tajo/storage/StorageService.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development