Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1672

Removing rest api to create table POST /databases/{database-name}/tables interface

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, POST /databases/

      {database-name}

      /tables interface is too hard to use. Because it just serialize TableDesc Class. so I think just using query interface is better than create table interface

      and for them, changed result of query interface
      removing location header, and add response body has query, and ResultCode
      and url.(if query is finished directlry, uri isn't)

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/623

        TAJO-1672 Removing rest api to create table POST /databases/

        {database-name}/tables interface

        Currently, POST /databases/{database-name}

        /tables interface is too hard to use. Because it just serialize TableDesc Class. so I think just using query interface is better than create table interface
        and for them, changed result of query interface
        removing location header, and add response body has query, and ResultCode
        and url.(if query is finished directlry, uri isn't)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/remove-create-table-rest-api

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/623.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #623


        commit 2469f3a419592c420a49a611692c7c51309ce52f
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-07-03T17:01:05Z

        remove create table rest api interface

        remove tajo-env.sh


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/623 TAJO-1672 Removing rest api to create table POST /databases/ {database-name}/tables interface Currently, POST /databases/{database-name} /tables interface is too hard to use. Because it just serialize TableDesc Class. so I think just using query interface is better than create table interface and for them, changed result of query interface removing location header, and add response body has query, and ResultCode and url.(if query is finished directlry, uri isn't) You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/remove-create-table-rest-api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/623.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #623 commit 2469f3a419592c420a49a611692c7c51309ce52f Author: clark.kang <clark.kang@kakao.com> Date: 2015-07-03T17:01:05Z remove create table rest api interface remove tajo-env.sh
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/623#issuecomment-118685436

        Hi @charsyam

        Thanks for your contribution.
        Could you rebase it for the Travis CI build?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/623#issuecomment-118685436 Hi @charsyam Thanks for your contribution. Could you rebase it for the Travis CI build?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam commented on the pull request:

        https://github.com/apache/tajo/pull/623#issuecomment-118746485

        @blrunner I rebased it

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/623#issuecomment-118746485 @blrunner I rebased it
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/623#issuecomment-118746675

        Thanks! I'll check it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/623#issuecomment-118746675 Thanks! I'll check it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/623

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/623
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/623#issuecomment-120055610

        +1

        Thanks @charsyam
        I've just committed it to the master branch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/623#issuecomment-120055610 +1 Thanks @charsyam I've just committed it to the master branch.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #387 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/387/)
        TAJO-1672: Removing rest api to create table POST /databases/

        {database-name}

        /tables interface. (blrunner: rev 2d7212c835c3faaee1004e1447644b722ec13c71)

        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/responses/GetSubmitQueryResponse.java
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResource.java
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #387 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/387/ ) TAJO-1672 : Removing rest api to create table POST /databases/ {database-name} /tables interface. (blrunner: rev 2d7212c835c3faaee1004e1447644b722ec13c71) CHANGES tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/responses/GetSubmitQueryResponse.java tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResource.java tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #747 (See https://builds.apache.org/job/Tajo-master-build/747/)
        TAJO-1672: Removing rest api to create table POST /databases/

        {database-name}

        /tables interface. (blrunner: rev 2d7212c835c3faaee1004e1447644b722ec13c71)

        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/responses/GetSubmitQueryResponse.java
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java
        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResource.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #747 (See https://builds.apache.org/job/Tajo-master-build/747/ ) TAJO-1672 : Removing rest api to create table POST /databases/ {database-name} /tables interface. (blrunner: rev 2d7212c835c3faaee1004e1447644b722ec13c71) tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/responses/GetSubmitQueryResponse.java tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResource.java tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestTablesResource.java tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResource.java CHANGES

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development