Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Storage
    • Labels:
      None

      Description

      TAJO-337 introduces the separation between storage and data formats. We also should rename existing variables using the word 'storeType' and 'storageType'.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.0-build #77 (See https://builds.apache.org/job/Tajo-0.11.0-build/77/)
        TAJO-1663: Change the variable name storeType to dataFormat. (hyunsik: rev b418c499170afe51bf38163876ce71a7aa639bdc)

        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-core/src/main/resources/webapps/admin/catalogview.jsp
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java
        • tajo-plan/src/main/proto/Plan.proto
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
        • tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.0-build #77 (See https://builds.apache.org/job/Tajo-0.11.0-build/77/ ) TAJO-1663 : Change the variable name storeType to dataFormat. (hyunsik: rev b418c499170afe51bf38163876ce71a7aa639bdc) tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-core/src/main/resources/webapps/admin/catalogview.jsp tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java tajo-plan/src/main/proto/Plan.proto tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #912 (See https://builds.apache.org/job/Tajo-master-build/912/)
        TAJO-1663: Change the variable name storeType to dataFormat. (hyunsik: rev 67c4541ee43d00a1418919827cb9065ecc541170)

        • tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
        • tajo-core/src/main/resources/webapps/admin/catalogview.jsp
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • CHANGES
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java
        • tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java
        • tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
        • tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-plan/src/main/proto/Plan.proto
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #912 (See https://builds.apache.org/job/Tajo-master-build/912/ ) TAJO-1663 : Change the variable name storeType to dataFormat. (hyunsik: rev 67c4541ee43d00a1418919827cb9065ecc541170) tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-core/src/main/resources/webapps/admin/catalogview.jsp tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java CHANGES tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-plan/src/main/proto/Plan.proto
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #544 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/544/)
        TAJO-1663: Change the variable name storeType to dataFormat. (hyunsik: rev 67c4541ee43d00a1418919827cb9065ecc541170)

        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
        • tajo-core/src/main/resources/webapps/admin/catalogview.jsp
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java
        • tajo-plan/src/main/proto/Plan.proto
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java
        • tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java
        • tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java
        • tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        • tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #544 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/544/ ) TAJO-1663 : Change the variable name storeType to dataFormat. (hyunsik: rev 67c4541ee43d00a1418919827cb9065ecc541170) tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-plan/src/test/java/org/apache/tajo/plan/TestLogicalNode.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-plan/src/main/java/org/apache/tajo/plan/TablePropertyUtil.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlanUtil.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentConvertor.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/TablesTableDescriptor.java tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/mysql.xml tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java tajo-core/src/main/resources/webapps/admin/catalogview.jsp tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithDataFormat.sql tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/TextLineSerDe.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/CreateTableNode.java tajo-plan/src/main/proto/Plan.proto tajo-core-tests/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java tajo-core/src/main/java/org/apache/tajo/querymaster/Task.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/OldStorageManager.java tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/derby.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogAgainstCaseSensitivity.java tajo-catalog/tajo-catalog-server/src/test/resources/schemas/derbytest/loadtest/derby.xml tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java tajo-core-tests/src/test/resources/queries/TestCTASQuery/CtasWithDataFormat.sql tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/AbstractTableDescriptor.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseFragment.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        I committed it to master and 0.11.0 branches.

        Show
        hyunsik Hyunsik Choi added a comment - I committed it to master and 0.11.0 branches.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/790

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/790
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/790#issuecomment-143877184

        Thank you. I'll commit it soon.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/790#issuecomment-143877184 Thank you. I'll commit it soon.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/790#issuecomment-143729326

        +1 looks good to me.
        Please update the catalog version before you commit.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/790#issuecomment-143729326 +1 looks good to me. Please update the catalog version before you commit.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/790#issuecomment-143533472

        @blrunner You need to upgrade the catalog. I missed to bump up the catalog version.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/790#issuecomment-143533472 @blrunner You need to upgrade the catalog. I missed to bump up the catalog version.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/790#issuecomment-143526580

        Hi @hyunsik

        When I tested a simple query using your patch, the query failed as following:

        ```
        2015-09-27 16:22:49,697 INFO org.apache.tajo.master.GlobalEngine: Query: select * from lineitem limit 10
        2015-09-27 16:22:49,901 ERROR org.apache.tajo.catalog.CatalogServer:
        Stack Trace:
        org.apache.tajo.exception.TajoInternalError: internal error: Unknown column 'DATA_FORMAT' in 'field list'
        at org.apache.tajo.catalog.store.AbstractDBStore.getTable(AbstractDBStore.java:1798)
        at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.getTableDesc(CatalogServer.java:611)
        at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:274)
        at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:288)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitRelation(BaseSchemaBuildPhase.java:415)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitRelation(BaseSchemaBuildPhase.java:74)
        at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:99)
        at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visitRelationList(BaseAlgebraVisitor.java:429)
        at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:96)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitLimit(BaseSchemaBuildPhase.java:277)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitLimit(BaseSchemaBuildPhase.java:74)
        at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:63)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitProjection(BaseSchemaBuildPhase.java:220)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitProjection(BaseSchemaBuildPhase.java:74)
        at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:60)
        at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase.process(BaseSchemaBuildPhase.java:71)
        at org.apache.tajo.plan.rewrite.BaseLogicalPlanPreprocessEngine.process(BaseLogicalPlanPreprocessEngine.java:94)
        at org.apache.tajo.plan.LogicalPlanPreprocessor.process(LogicalPlanPreprocessor.java:43)
        at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:164)
        at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:154)
        at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:274)
        ```

        Could you check it?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/790#issuecomment-143526580 Hi @hyunsik When I tested a simple query using your patch, the query failed as following: ``` 2015-09-27 16:22:49,697 INFO org.apache.tajo.master.GlobalEngine: Query: select * from lineitem limit 10 2015-09-27 16:22:49,901 ERROR org.apache.tajo.catalog.CatalogServer: Stack Trace: org.apache.tajo.exception.TajoInternalError: internal error: Unknown column 'DATA_FORMAT' in 'field list' at org.apache.tajo.catalog.store.AbstractDBStore.getTable(AbstractDBStore.java:1798) at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.getTableDesc(CatalogServer.java:611) at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:274) at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:288) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitRelation(BaseSchemaBuildPhase.java:415) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitRelation(BaseSchemaBuildPhase.java:74) at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:99) at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visitRelationList(BaseAlgebraVisitor.java:429) at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:96) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitLimit(BaseSchemaBuildPhase.java:277) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitLimit(BaseSchemaBuildPhase.java:74) at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:63) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitProjection(BaseSchemaBuildPhase.java:220) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase$Processor.visitProjection(BaseSchemaBuildPhase.java:74) at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:60) at org.apache.tajo.plan.rewrite.BaseSchemaBuildPhase.process(BaseSchemaBuildPhase.java:71) at org.apache.tajo.plan.rewrite.BaseLogicalPlanPreprocessEngine.process(BaseLogicalPlanPreprocessEngine.java:94) at org.apache.tajo.plan.LogicalPlanPreprocessor.process(LogicalPlanPreprocessor.java:43) at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:164) at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:154) at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:274) ``` Could you check it?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/790

        TAJO-1663: Change the variable name storeType to dataFormat.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1663

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/790.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #790


        commit 3f1023abce29be38de820af427a8f6db58b14cf3
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-24T23:47:09Z

        Renamed StoreType enum type to DataFormat.

        commit f5424251f7c597b48bc94687950d283925bbdec4
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-25T00:06:03Z

        Change StoreType to DataFormat in Fragment and TableMeta.

        commit 0f3c6c9f9a0d71ac4e50561b92a81160f2feb18e
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-25T00:36:36Z

        Rename StoreType in TableDescriptorProto to DataFormat.

        commit d65c18aedb11e5d493e04c5ecbbef9e500676994
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-25T11:06:44Z

        Completely changed all storeType names.

        commit 282c9f2238aef5f96d09a091c5e9c9115a9624b8
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-25T11:06:59Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1663


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/790 TAJO-1663 : Change the variable name storeType to dataFormat. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1663 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/790.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #790 commit 3f1023abce29be38de820af427a8f6db58b14cf3 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-24T23:47:09Z Renamed StoreType enum type to DataFormat. commit f5424251f7c597b48bc94687950d283925bbdec4 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-25T00:06:03Z Change StoreType to DataFormat in Fragment and TableMeta. commit 0f3c6c9f9a0d71ac4e50561b92a81160f2feb18e Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-25T00:36:36Z Rename StoreType in TableDescriptorProto to DataFormat. commit d65c18aedb11e5d493e04c5ecbbef9e500676994 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-25T11:06:44Z Completely changed all storeType names. commit 282c9f2238aef5f96d09a091c5e9c9115a9624b8 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-25T11:06:59Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1663
        Hide
        hyunsik Hyunsik Choi added a comment -

        This is very simple issue. I'll fix it in this release.

        Show
        hyunsik Hyunsik Choi added a comment - This is very simple issue. I'll fix it in this release.
        Hide
        jihoonson Jihoon Son added a comment -

        If you aren't working on this issue now, it would be good to reschedule to 0.12.

        Show
        jihoonson Jihoon Son added a comment - If you aren't working on this issue now, it would be good to reschedule to 0.12.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development