Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1649

Change Rest API /databases/{database-name}/functions to /functions

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: REST API
    • Labels:
      None

      Description

      functions is not related with database.
      so GET /functions is more clear.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/606

        TAJO-1649 Change Rest API /databases/

        {database-name}

        /functions to /functions

        functions is not related with database.
        so GET /functions is more clear.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/change-api-functions

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/606.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #606


        commit e052e41e44513ed14988aeb5774b1c50de1e6048
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-06-17T14:22:07Z

        change api functions address


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/606 TAJO-1649 Change Rest API /databases/ {database-name} /functions to /functions functions is not related with database. so GET /functions is more clear. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/change-api-functions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/606.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #606 commit e052e41e44513ed14988aeb5774b1c50de1e6048 Author: clark.kang <clark.kang@kakao.com> Date: 2015-06-17T14:22:07Z change api functions address
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/606#issuecomment-113344758

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/606#issuecomment-113344758 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/606#issuecomment-113344883

        Could you update the specification on the wiki too?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/606#issuecomment-113344883 Could you update the specification on the wiki too?
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/606#issuecomment-113349358

        I just committed the patch to master branch. I missed to add 'close command' in the commit log. Could you close this ticket?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/606#issuecomment-113349358 I just committed the patch to master branch. I missed to add 'close command' in the commit log. Could you close this ticket?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam closed the pull request at:

        https://github.com/apache/tajo/pull/606

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/606
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam commented on the pull request:

        https://github.com/apache/tajo/pull/606#issuecomment-113357040

        I updated wiki

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/606#issuecomment-113357040 I updated wiki
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #371 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/371/)
        TAJO-1649: Change Rest API /databases/

        {database-name}

        /functions to /functions. (hyunsik: rev b0df5e0df1be78cd93b60db014a51a6dc6fed02e)

        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/FunctionsResource.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #371 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/371/ ) TAJO-1649 : Change Rest API /databases/ {database-name} /functions to /functions. (hyunsik: rev b0df5e0df1be78cd93b60db014a51a6dc6fed02e) tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/FunctionsResource.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #732 (See https://builds.apache.org/job/Tajo-master-build/732/)
        TAJO-1649: Change Rest API /databases/

        {database-name}

        /functions to /functions. (hyunsik: rev b0df5e0df1be78cd93b60db014a51a6dc6fed02e)

        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/FunctionsResource.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #732 (See https://builds.apache.org/job/Tajo-master-build/732/ ) TAJO-1649 : Change Rest API /databases/ {database-name} /functions to /functions. (hyunsik: rev b0df5e0df1be78cd93b60db014a51a6dc6fed02e) tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestFunctionsResource.java CHANGES tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/FunctionsResource.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development