Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Unit Test
    • Labels:
      None

      Description

      This is my fault.
      The last time which our CI run to test TAJO-1130 was about 2 months ago. I forgot testing again before commit.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #723 (See https://builds.apache.org/job/Tajo-master-build/723/)
        TAJO-1630: Test failure after TAJO-1130. (jihoon) (jihoonson: rev f4680a933149bb49237e145afd36d2dc18bacbbe)

        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestTPCH/testTPCHQ5.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Hash_NoBroadcast.plan
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
        • CHANGES
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestTPCH/testQ2FourJoins.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash.plan
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestOuterJoinQuery.java
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testFullOuterJoinPredicationCaseByCase1.1.result
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Hash_NoBroadcast.plan
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #723 (See https://builds.apache.org/job/Tajo-master-build/723/ ) TAJO-1630 : Test failure after TAJO-1130 . (jihoon) (jihoonson: rev f4680a933149bb49237e145afd36d2dc18bacbbe) tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestTPCH/testTPCHQ5.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Hash_NoBroadcast.plan tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java CHANGES tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestTPCH/testQ2FourJoins.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash.plan tajo-core/src/test/java/org/apache/tajo/engine/query/TestOuterJoinQuery.java tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testFullOuterJoinPredicationCaseByCase1.1.result tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Hash_NoBroadcast.plan
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #363 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/363/)
        TAJO-1630: Test failure after TAJO-1130. (jihoon) (jihoonson: rev f4680a933149bb49237e145afd36d2dc18bacbbe)

        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testFullOuterJoinPredicationCaseByCase1.1.result
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestTPCH/testTPCHQ5.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Sort_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort_NoBroadcast.plan
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestOuterJoinQuery.java
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort.plan
        • tajo-core/src/test/resources/results/TestTPCH/testQ2FourJoins.plan
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Hash_NoBroadcast.plan
        • CHANGES
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash_NoBroadcast.plan
        • tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Sort_NoBroadcast.plan
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #363 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/363/ ) TAJO-1630 : Test failure after TAJO-1130 . (jihoon) (jihoonson: rev f4680a933149bb49237e145afd36d2dc18bacbbe) tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testFullOuterJoinPredicationCaseByCase1.1.result tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinOnMultipleDatabases.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestTPCH/testTPCHQ5.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testBroadcastTwoPartJoin.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Sort_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort_NoBroadcast.plan tajo-core/src/test/java/org/apache/tajo/engine/query/TestOuterJoinQuery.java tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testJoinWithMultipleJoinQual1.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Hash.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Sort.plan tajo-core/src/test/resources/results/TestTPCH/testQ2FourJoins.plan tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual4.Hash_NoBroadcast.plan CHANGES tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testBroadcastSubquery2.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinQuery/testTPCHQ2Join.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinWithSubQuery/testJoinWithDifferentShuffleKey.1.Sort.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestOuterJoinQuery/testLeftOuterJoinWithEmptyTable4.Hash_NoBroadcast.plan tajo-core/src/test/resources/results/TestInnerJoinWithSubQuery/testJoinWithMultipleJoinQual3.Sort_NoBroadcast.plan
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master.
        Thanks for quick review!

        Show
        jihoonson Jihoon Son added a comment - Committed to master. Thanks for quick review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/592

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/592
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/592#issuecomment-106249496

        +1 ship it!!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/592#issuecomment-106249496 +1 ship it!!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/592

        TAJO-1630: Test failure after TAJO-1130

        I've changed only two lines as follows. Everything else is related to unit tests.
        ```
        diff --git a/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java b/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
        index 22c3751..f8cd1e9 100644
        — a/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
        +++ b/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
        @@ -237,13 +237,13 @@ public class MasterPlan {
        sb.append("Order of Execution\n");
        sb.append("-------------------------------------------------------------------------------");
        int order = 1;

        • for (ExecutionBlock currentEB : cursor) {
          + for (ExecutionBlock currentEB : executionOrderCursor) { sb.append("\n").append(order).append(": ").append(currentEB.getId()); order++; }

          sb.append("\n-------------------------------------------------------------------------------\n");

        • for (ExecutionBlock block : cursor) {
          + for (ExecutionBlock block : executionOrderCursor) {

        boolean terminal = false;
        ```

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1630

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/592.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #592


        commit dc93e22c6e31668f7dceed90d9b294d757264808
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-05-28T08:06:50Z

        TAJO-1630


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/592 TAJO-1630 : Test failure after TAJO-1130 I've changed only two lines as follows. Everything else is related to unit tests. ``` diff --git a/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java b/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java index 22c3751..f8cd1e9 100644 — a/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java +++ b/tajo-core/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java @@ -237,13 +237,13 @@ public class MasterPlan { sb.append("Order of Execution\n"); sb.append("-------------------------------------------------------------------------------"); int order = 1; for (ExecutionBlock currentEB : cursor) { + for (ExecutionBlock currentEB : executionOrderCursor) { sb.append("\n").append(order).append(": ").append(currentEB.getId()); order++; } sb.append("\n-------------------------------------------------------------------------------\n"); for (ExecutionBlock block : cursor) { + for (ExecutionBlock block : executionOrderCursor) { boolean terminal = false; ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1630 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #592 commit dc93e22c6e31668f7dceed90d9b294d757264808 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-05-28T08:06:50Z TAJO-1630

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development