Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1623

INSERT INTO with wrong target columns causes NPE.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1, 0.10.2
    • Component/s: Query Validation
    • Labels:
      None

      Description

      How to reproduce

      CREATE TABLE T1 (col1 int, col2 int);
      INSERT INTO T1 (col1, col3) select l_orderkey, l_partkey from default.lineitem;
      

      When the target column name is wrong (i.e.,, col3 in INSERT statement), the query will cause NPE.

      1. TAJO-1623.patch
        5 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #359 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/359/)
        TAJO-1623: INSERT INTO with wrong target columns causes NPE. (hyunsik: rev 4f3a46c3646ca7a551916c57c980b2862a9dbb4e)

        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #359 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/359/ ) TAJO-1623 : INSERT INTO with wrong target columns causes NPE. (hyunsik: rev 4f3a46c3646ca7a551916c57c980b2862a9dbb4e) tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #719 (See https://builds.apache.org/job/Tajo-master-build/719/)
        TAJO-1623: INSERT INTO with wrong target columns causes NPE. (hyunsik: rev 4f3a46c3646ca7a551916c57c980b2862a9dbb4e)

        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #719 (See https://builds.apache.org/job/Tajo-master-build/719/ ) TAJO-1623 : INSERT INTO with wrong target columns causes NPE. (hyunsik: rev 4f3a46c3646ca7a551916c57c980b2862a9dbb4e) tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/TestQueryValidation.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to all branches.

        Show
        hyunsik Hyunsik Choi added a comment - committed to all branches.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/587

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/587
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/587#issuecomment-105738644

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/587#issuecomment-105738644 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/587

        TAJO-1623: INSERT INTO with wrong target columns causes NPE.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1623

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/587.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #587


        commit 2f0d0898ce975a6ff824defe85c2b7209068aae8
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-26T23:47:16Z

        TAJO-1623: INSERT INTO with wrong target columns causes NPE.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/587 TAJO-1623 : INSERT INTO with wrong target columns causes NPE. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1623 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #587 commit 2f0d0898ce975a6ff824defe85c2b7209068aae8 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-26T23:47:16Z TAJO-1623 : INSERT INTO with wrong target columns causes NPE.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development