Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1593

Add missing stop condition to Taskrunner

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: Worker
    • Labels:
      None

      Description

      A task was completed but taskRunner wait for stop from QueryMaster

      1. TAJO-1593_2.patch
        5 kB
        Jinho Kim
      2. TAJO-1593.patch
        5 kB
        Jinho Kim

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy closed the pull request at:

        https://github.com/apache/tajo/pull/562

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy closed the pull request at: https://github.com/apache/tajo/pull/562
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #698 (See https://builds.apache.org/job/Tajo-master-build/698/)
        TAJO-1593: Add missing stop condition to Taskrunner. (jinho) (jhkim: rev ddd39213d87fd76e9e80099e92010fd71b3d363e)

        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #698 (See https://builds.apache.org/job/Tajo-master-build/698/ ) TAJO-1593 : Add missing stop condition to Taskrunner. (jinho) (jhkim: rev ddd39213d87fd76e9e80099e92010fd71b3d363e) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #339 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/339/)
        TAJO-1593: Add missing stop condition to Taskrunner. (jinho) (jhkim: rev ddd39213d87fd76e9e80099e92010fd71b3d363e)

        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
        • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #339 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/339/ ) TAJO-1593 : Add missing stop condition to Taskrunner. (jinho) (jhkim: rev ddd39213d87fd76e9e80099e92010fd71b3d363e) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java CHANGES
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/562#issuecomment-100129093

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/562#issuecomment-100129093 +1 LGTM!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12731353/TAJO-1593_2.patch
        against master revision release-0.9.0-rc0-285-g2b4c161.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-rpc/tajo-rpc-protobuf.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/777//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/777//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12731353/TAJO-1593_2.patch against master revision release-0.9.0-rc0-285-g2b4c161. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/777//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/777//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/562

        TAJO-1593: Add missing stop condition to Taskrunner

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1593

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/562.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #562


        commit f2b1b6ca4500282dd655cd4146fd92dcf4e84a61
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-05-08T03:06:06Z

        TAJO-1593: Add missing stop condition to Taskrunner


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/562 TAJO-1593 : Add missing stop condition to Taskrunner You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1593 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/562.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #562 commit f2b1b6ca4500282dd655cd4146fd92dcf4e84a61 Author: Jinho Kim <jhkim@apache.org> Date: 2015-05-08T03:06:06Z TAJO-1593 : Add missing stop condition to Taskrunner

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development